| Commit message (Collapse) | Author | Age |
|---|
| | |
|
| |
|
|
| |
And re-run IWYU, adjust #includes.
|
| |
|
|
|
| |
Enable build setting to allow Xcode to complain about invalid
comments.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Cppcheck was complaining about the `return val.c_str()` at the end of the
`wgettext()` function. That would normally a bug since the lifetime of
`val` ends when the function returns. In this particular case that's not
true because the string is interned in a cache. Nonetheless, rather than
suppress the lint warning I decided to modify the API to be more idiomatic.
In the process of fixing the aforementioned lint warning I fixed several other
lint errors in that module.
This required making our copy of `wgetopt()` compatible with the rest of
the fish code. Specifically, by removing its local definitions of the
"_" macro so it uses the same macro used everywhere else in the fish
code. The sooner we kill the use of wide chars the better.
|
| |
|
|
|
|
|
|
| |
This only eliminates errors reported by `make lint`. It shouldn't cause any
functional changes.
This change does remove several functions that are unused. It also removes the
`desc_arr` variable which is both unused and out of date with reality.
|
| | |
|
| |
|
|
|
|
|
|
| |
The autoconf-generated config.h contains a number of directives which
may alter the behaviour of system headers on certain platforms. Always
include it in every C++ file as the first include.
Closes #2993.
|
| |
|
|
|
| |
This removes some pointless parentheses but the primary focus is removing
redundancies like unnecessary "else" clauses.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I missed restyling a few "switch" blocks to make them consistent with the rest
of the code base. This fixes that oversight. This should be the final step in
restyling the C++ code to have a consistent style. This also includes a few
trivial cleanups elsewhere.
I also missed restyling the "complete" module when working my way from a to z
so this final change includes restyling that module.
Total lint errors decreased 36%. Cppcheck errors went from 47 to 24. Oclint P2
errors went from 819 to 778. Oclint P3 errors went from 3252 to 1842.
Resolves #2902.
|
| |
|
|
|
|
|
|
|
| |
Remove the "make iwyu" build target. Move the functionality into the
recently introduced lint.fish script. Fix a lot, but not all, of the
include-what-you-use errors. Specifically, it fixes all of the IWYU errors
on my OS X server but only removes some of them on my Ubuntu 14.04 server.
Fixes #2957
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Prior to this fix, when completing a command that doesn't have a /, we
would prepend each component of PATH and then expand the whole thing. So
any special characters in the PATH would be interpreted when performing
tab completion.
With this fix, we pull the PATH resolution out of complete.cpp and
migrate it to expand.cpp. This unifies nicely with the CDPATH resolution
already in that file. This requires introducing a new expand flag
EXPAND_SPECIAL_FOR_COMMAND, which is analogous to EXPAND_SPECIAL_CD
(which is renamed to EXPAND_SPECIAL_FOR_CD). This flag tells expand to
resolve paths against PATH instead of the working directory.
Fixes #952
|
| |
|
|
|
|
|
|
|
|
| |
This fixes all memory leaks found by compiling with
clang++ -g -fsanitize=address and running the tests.
Method:
Ensure that memory is freed by the destructor of its respective container,
either by storing objects directly instead of by pointer, or implementing
the required destructor.
|
| |
|
|
| |
It doesn't use any properties of parser_t
|
| |
|
|
| |
Errors are now unconditionally shown
|
| |
|
|
| |
It was never fully implemented and wasn't used for anything
|
| |
|
|
|
| |
Previously there had to be some variable text, now you can
tab complete from just a naked $.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
This will simplify some code and make the cd autosuggestion smarter
|
| |
|
|
|
| |
Rather than passing a triple of short, long, is_old, pass an option
as a string and then a type
|
| | |
|
| | |
|
| |
|
|
|
|
|
| |
Rather than storing short and long options separately, using
a complicated set of invariants, store them in a single string
and use an explicit type complete_option_type_t to track how they
are interpreted.
|
| |
|
|
|
|
|
|
|
| |
This was a "cache" of dubious value that was also very confusing.
The idea was to express in one place all of the short options that
were allowed for a command, in a big string. But it's simpler to
just construct that on-demand by walking the list of
complete_entry_opt_t.
Also remove some other dead code as part of cleanup.
|
| |
|
|
| |
Preparing to remove short_opt_string
|
| |
|
|
|
| |
Fixes a case where a --wraps declaration would be missed
because the function would not be loaded. Fixes #2466.
|
| |
|
|
|
| |
When expanding an executable with $PATH, don't attempt to
interpret the directories in PATH as fuzzy matching. Fixes #2413.
|
| |
|
|
|
|
|
| |
This change eliminates global variables like stdout_buffer. Instead we wrap up
the IO information into a new struct io_streams_t, and thread that through
every builtin. This makes the intent clearer, gives us a place to hang new IO
data, and eliminates the ugly global state management like builtin_push_io.
|
| |
|
|
| |
Makes it harder to cause issues with aliases, see fish-shell#2245
|
| |
|
|
| |
Make it simpler, and use wcstring instead of wcsdup
|
| |
|
|
| |
Enable -Wunused-macros, and remove said unused macros
|
| |
|
|
| |
This is yet clearer
|
| |
|
|
|
|
| |
In a few places, we need to add a prefix to completions that
replace the token. This change factors that logic into its
own function prepend_token_prefix.
|
| | |
|
| |\
| |
| |
| | |
http://include-what-you-use.org/
|
| | |
| |
| |
| |
| | |
Replace uses of vector<completion_t>& with vector<completion_t>*
This makes it clear at the call site that the object may be mutated.
|
| | |
| |
| |
| |
| |
| | |
For example, env VAR=/usr<tab> will now work as expected
Fixes #2178
|
| | | |
|
| |/ |
|
|
|
This change moves source files into a src/ directory,
and puts object files into an obj/ directory. The Makefile
and xcode project are updated accordingly.
Fixes #1866
|
Aaron Gyes
Kurtis Rader
David Adam
ridiculousfish
Andreas Nordal
Fabian Homborg