diff options
| author |  Kurtis Rader <krader@skepticism.us> | 2016-05-08 15:57:56 -0700 |
|---|---|---|
| committer | Kurtis Rader <krader@skepticism.us> | 2016-05-14 20:38:32 -0700 |
| commit | 51468b764689e7d724a87e6c2b8cdb4e599a3604 (patch) | |
| tree | 75fe13dbad791e0d143a3610bfe7ed7d0136ad38 /tests/function.err | |
| parent | ff1d651415a2752e82ec417294f9bdf8c234c10f (diff) | |
add `function --shadow-builtin` flag
It's currently too easy for someone to bork their shell by doing something
like `function test; return 0; end`. That's obviously a silly, contrived,
example but the point is that novice users who learn about functions are
prone to do something like that without realizing it will bork the shell. Even
expert users who know about the `test` builtin might forget that, say, `pwd`
is a builtin.
This change adds a `--shadow-builtin` flag that must be specified to
indicate you know what you're doing.
Fixes #3000
Diffstat (limited to 'tests/function.err')
| -rw-r--r-- | tests/function.err | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/tests/function.err b/tests/function.err index e69de29b..72671ac9 100644 --- a/tests/function.err +++ b/tests/function.err @@ -0,0 +1,8 @@ +function: function name shadows a builtin so you must use '--shadow-builtin' +fish: function pwd; end + ^ +yes, it failed as expected +function: function name does not shadow a builtin so you must not use '--shadow-builtin' +fish: function not_builtin --shadow-builtin; end + ^ +yes, it failed as expected |