diff options
| author |  ridiculousfish <corydoras@ridiculousfish.com> | 2016-03-03 18:49:12 -0800 |
|---|---|---|
| committer | ridiculousfish <corydoras@ridiculousfish.com> | 2016-03-03 18:49:24 -0800 |
| commit | 1e7c3fe70964711918bcf13553ae9fb66ed73a17 (patch) | |
| tree | 99541c6a121f0868834f1cceb35c36092515cc6c /src/postfork.cpp | |
| parent | 333415f42a8fb837b4867edda7118cd50d59a485 (diff) | |
A few fixes suggested by Coverity Scan
Diffstat (limited to 'src/postfork.cpp')
| -rw-r--r-- | src/postfork.cpp | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/src/postfork.cpp b/src/postfork.cpp index 43c33d56..40a0bffb 100644 --- a/src/postfork.cpp +++ b/src/postfork.cpp @@ -138,7 +138,6 @@ static int handle_child_io(const io_chain_t &io_chain) for (size_t idx = 0; idx < io_chain.size(); idx++) { const io_data_t *io = io_chain.at(idx).get(); - int tmp; if (io->io_mode == IO_FD && io->fd == static_cast<const io_fd_t*>(io)->old_fd) { @@ -162,8 +161,8 @@ static int handle_child_io(const io_chain_t &io_chain) { // Here we definitely do not want to set CLO_EXEC because our child needs access CAST_INIT(const io_file_t *, io_file, io); - if ((tmp=open(io_file->filename_cstr, - io_file->flags, OPEN_MASK))==-1) + int tmp = open(io_file->filename_cstr, io_file->flags, OPEN_MASK); + if (tmp < 0) { if ((io_file->flags & O_EXCL) && (errno ==EEXIST)) |