diff options
author | Jeff Kowalski <jeff.kowalski@gmail.com> | 2016-03-12 11:21:52 -0800 |
---|---|---|
committer | Jeff Kowalski <jeff.kowalski@gmail.com> | 2016-03-12 11:21:52 -0800 |
commit | 46b9f263ac780ae6a921fc24611c75bbec92ebca (patch) | |
tree | c406d1655e5542ffa481147c77959207fae2f086 /src/history.cpp | |
parent | 540bdfcb026dfadf8d6fc8bde91cddc886b2c677 (diff) |
Handle return values from fchown
The function fchown is annotated with warn_unused_result. As
formerly used in the code, it would emit a compiler warning
```warning: ignoring return value of ‘fchown’, declared with
attribute warn_unused_result [-Wunused-result]```
This commit notes the return value and emits appropriate error/logging
messages if the call fails, creating more traceable results and
satisfying the compiler.
Diffstat (limited to 'src/history.cpp')
-rw-r--r-- | src/history.cpp | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/src/history.cpp b/src/history.cpp index 1bada96d..022524c3 100644 --- a/src/history.cpp +++ b/src/history.cpp @@ -1453,7 +1453,10 @@ bool history_t::save_internal_via_rewrite() if (wstat(new_name, &sbuf) >= 0) { /* Success */ - fchown(out_fd, sbuf.st_uid, sbuf.st_gid); + if (0 > fchown(out_fd, sbuf.st_uid, sbuf.st_gid)) + { + debug(2, L"Error when changing ownership of history file"); + } fchmod(out_fd, sbuf.st_mode); } |