fix random lint issues

This only eliminates errors reported by `make lint`. It shouldn't cause any
functional changes.

This change does remove several functions that are unused. It also removes the
`desc_arr` variable which is both unused and out of date with reality.

1 files changed, 2 insertions, 2 deletions

diff --git a/src/env.cpp b/src/env.cpp
index 381b4588..e09064ad 100644
--- a/src/env.cpp
+++ b/src/env.cpp
@@ -699,7 +699,7 @@ env_var_t env_get_string(const wcstring &key, env_mode_flags_t mode) {
 
     if (search_local || search_global) {
         /* Lock around a local region */
-        scoped_lock lock(env_lock);
+        scoped_lock lock(env_lock);  //!OCLINT(has side effects)
 
         env_node_t *env = search_local ? top : global_env;
 
@@ -869,7 +869,7 @@ static void add_key_to_string_set(const var_table_t &envs, std::set<wcstring> *s
 }
 
 wcstring_list_t env_get_names(int flags) {
-    scoped_lock lock(env_lock);
+    scoped_lock lock(env_lock);  //!OCLINT(has side effects)
 
     wcstring_list_t result;
     std::set<wcstring> names;