add better support for IWYU and fix things

Remove the "make iwyu" build target. Move the functionality into the
recently introduced lint.fish script. Fix a lot, but not all, of the
include-what-you-use errors. Specifically, it fixes all of the IWYU errors
on my OS X server but only removes some of them on my Ubuntu 14.04 server.

Fixes #2957

1 files changed, 7 insertions, 10 deletions

diff --git a/src/common.h b/src/common.h
index d6eb0191..dc6e0236 100644
--- a/src/common.h
+++ b/src/common.h
@@ -1,29 +1,26 @@
 /** \file common.h
 	Prototypes for various functions, mostly string utilities, that are used by most parts of fish.
 */
-
 #ifndef FISH_COMMON_H
-/**
-   Header guard
-*/
 #define FISH_COMMON_H
+#include "config.h"
 
 #include <stdlib.h>
 #include <stdio.h>
 #include <wchar.h>
-#include <termios.h>
 #include <string>
 #include <sstream>
 #include <vector>
 #include <pthread.h>
 #include <string.h>
-#include <stdarg.h>
-#include <stddef.h>
 #include <sys/types.h>
-
 #include <errno.h>
-#include "config.h"
-#include "fallback.h"
+#include <termios.h>
+#include <memory>
+#include <stdbool.h>
+
+#include "fallback.h"  // IWYU pragma: keep
+#include "signal.h"  // IWYU pragma: keep
 
 /**
    Avoid writing the type name twice in a common "static_cast-initialization".