aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/builtin_complete.cpp
diff options
context:
space:
mode:
authorGravatar ridiculousfish <corydoras@ridiculousfish.com>2015-09-10 18:08:42 -0700
committerGravatar ridiculousfish <corydoras@ridiculousfish.com>2015-09-10 18:08:42 -0700
commit025b45b91ee3cbedfa99d02c414ecfe4756cdd1f (patch)
treedde0f1199b987e0d9a9fa1a0bf5eba8ff7e439d8 /src/builtin_complete.cpp
parent31d1e04301f9266aa040a78030992fdaa5995e6e (diff)
Don't crash on complete -C in non-interactive mode
Fixes #2361
Diffstat (limited to 'src/builtin_complete.cpp')
-rw-r--r--src/builtin_complete.cpp12
1 files changed, 11 insertions, 1 deletions
diff --git a/src/builtin_complete.cpp b/src/builtin_complete.cpp
index 6c4ccbcb..e206f9ab 100644
--- a/src/builtin_complete.cpp
+++ b/src/builtin_complete.cpp
@@ -433,9 +433,19 @@ static int builtin_complete(parser_t &parser, wchar_t **argv)
break;
case 'C':
+ {
do_complete = true;
- do_complete_param = w.woptarg ? w.woptarg : reader_get_buffer();
+ const wchar_t *arg = w.woptarg ? w.woptarg : reader_get_buffer();
+ if (arg == NULL)
+ {
+ // This corresponds to using 'complete -C' in non-interactive mode
+ // See #2361
+ builtin_missing_argument(parser, argv[0], argv[w.woptind-1]);
+ return STATUS_BUILTIN_ERROR;
+ }
+ do_complete_param = arg;
break;
+ }
case 'h':
builtin_print_help(parser, argv[0], stdout_buffer);