Mark jobs as completed when all processes have finished, not just the last one.

Fixes https://github.com/fish-shell/fish-shell/issues/876 , and coincidentally also https://github.com/fish-shell/fish-shell/issues/848

1 files changed, 11 insertions, 7 deletions

diff --git a/proc.cpp b/proc.cpp
index 749f38c2..d0412414 100644
--- a/proc.cpp
+++ b/proc.cpp
@@ -296,15 +296,19 @@ int job_is_stopped(const job_t *j)
 
    \param j the job to test
 */
-int job_is_completed(const job_t *j)
+bool job_is_completed(const job_t *j)
 {
-    process_t *p;
     assert(j->first_process != NULL);
-    for (p = j->first_process; p->next; p = p->next)
-        ;
-
-    return p->completed;
-
+    bool result = true;
+    for (process_t *p = j->first_process; p != NULL; p = p->next)
+    {
+        if (! p->completed)
+        {
+            result = false;
+            break;
+        }
+    }
+    return result;
 }
 
 void job_set_flag(job_t *j, unsigned int flag, int set)