Check return value of a few write calls and retry on EINTR, and fix a few other warnings, mostly by printing error messages before giving up.

darcs-hash:20090222202852-ac50b-b0e79142af5b7a99e55271d4001fa252d9684a1d.gz

1 files changed, 10 insertions, 2 deletions

diff --git a/print_help.c b/print_help.c
index 72344cde..06270d20 100644
--- a/print_help.c
+++ b/print_help.c
@@ -5,18 +5,26 @@
 
 #include <stdlib.h>
 #include <stdio.h>
-
+#include <string.h>
 
 #include "print_help.h"
 
 #define CMD_LEN 1024
 
+#define HELP_ERR "Could not show help message\n"
+
 void print_help( char *c, int fd )
 {
 	char cmd[ CMD_LEN];
 	int printed = snprintf( cmd, CMD_LEN, "fish -c '__fish_print_help %s >&%d'", c, fd );
 	
 	if( printed < CMD_LEN )
-		system( cmd );
+	{
+		if( (system( cmd ) == -1) )
+		{
+			write_loop(2, HELP_ERR, strlen(HELP_ERR));
+		}
 		
+	}
+	
 }