diff options
| author |  ridiculousfish <corydoras@ridiculousfish.com> | 2013-02-16 00:02:40 -0800 |
|---|---|---|
| committer | ridiculousfish <corydoras@ridiculousfish.com> | 2013-02-16 00:02:40 -0800 |
| commit | 6d522e6ed6b2e87b193e928e888ca4747a4f974d (patch) | |
| tree | e052a6ee43d9111d08373e12bcc7515cc4030266 /builtin_set.cpp | |
| parent | 635c87d6298d7c30651e266105ef72f3e1876209 (diff) | |
First round of fixes based on cppcheck
Diffstat (limited to 'builtin_set.cpp')
| -rw-r--r-- | builtin_set.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/builtin_set.cpp b/builtin_set.cpp index a094dd1c..dca0dbc5 100644 --- a/builtin_set.cpp +++ b/builtin_set.cpp @@ -125,7 +125,7 @@ static int my_env_set(const wchar_t *key, const wcstring_list_t &val, int scope) } wcstring sb; - if (val.size()) + if (! val.empty()) { for (i=0; i< val.size() ; i++) { @@ -313,7 +313,7 @@ static void erase_values(wcstring_list_t &list, const std::vector<long> &indexes // Now walk the set backwards, so we encounter larger indexes first, and remove elements at the given (1-based) indexes. std::set<long>::const_reverse_iterator iter; - for (iter = indexes_set.rbegin(); iter != indexes_set.rend(); iter++) + for (iter = indexes_set.rbegin(); iter != indexes_set.rend(); ++iter) { long val = *iter; if (val > 0 && (size_t)val <= list.size()) |