diff options
author | ridiculousfish <corydoras@ridiculousfish.com> | 2013-02-16 00:02:40 -0800 |
---|---|---|
committer | ridiculousfish <corydoras@ridiculousfish.com> | 2013-02-16 00:02:40 -0800 |
commit | 6d522e6ed6b2e87b193e928e888ca4747a4f974d (patch) | |
tree | e052a6ee43d9111d08373e12bcc7515cc4030266 /builtin.cpp | |
parent | 635c87d6298d7c30651e266105ef72f3e1876209 (diff) |
First round of fixes based on cppcheck
Diffstat (limited to 'builtin.cpp')
-rw-r--r-- | builtin.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/builtin.cpp b/builtin.cpp index 007adc12..619fc20a 100644 --- a/builtin.cpp +++ b/builtin.cpp @@ -1171,7 +1171,7 @@ static void functions_def(const wcstring &name, wcstring &out) wcstring_list_t named = function_get_named_arguments(name); - if (named.size() > 0) + if (! named.empty()) { append_format(out, L" --argument"); for (size_t i=0; i < named.size(); i++) @@ -3531,7 +3531,7 @@ static int builtin_end(parser_t &parser, wchar_t **argv) const wcstring val = for_vars.back(); for_vars.pop_back(); const wcstring &for_variable = fb->variable; - env_set(for_variable.c_str(), val.c_str(), ENV_LOCAL); + env_set(for_variable, val.c_str(), ENV_LOCAL); parser.current_block->loop_status = LOOP_NORMAL; parser.current_block->skip = 0; |