Fix crash bug from calling eval builtin with no arguments

darcs-hash:20051214134644-ac50b-5872ff628bf4f5d4f22f912d7ce7e9ed25d48b58.gz

1 files changed, 12 insertions, 20 deletions

diff --git a/builtin.c b/builtin.c
index 42a54059..d5fff50e 100644
--- a/builtin.c
+++ b/builtin.c
@@ -1750,28 +1750,20 @@ static int builtin_status( wchar_t **argv )
 */
 static int builtin_eval( wchar_t **argv )
 {
-	wchar_t *tot, **ptr, *next;
-	int totlen=0;
-
-	for( ptr = argv+1; *ptr; ptr++ )
-	{
-		totlen += wcslen( *ptr) + 1;
-	}
-	tot = malloc( sizeof(wchar_t)*totlen );
-	if( !tot )
-	{
-		die_mem();
-	}
-	for( ptr = argv+1, next=tot; *ptr; ptr++ )
+	string_buffer_t sb;
+	int i;
+	int argc = builtin_count_args( argv );
+	sb_init( &sb );
+	
+	for( i=1; i<argc; i++ )
 	{
-		int len = wcslen( *ptr );
-		wcscpy( next, *ptr );
-		next+=len;
-		*next++=L' ';
+		sb_append( &sb, argv[i] );
+		sb_append( &sb, L" " );
 	}
-	*(next-1)=L'\0';
-	eval( tot, block_io, TOP );
-	free( tot );
+	
+	eval( (wchar_t *)sb.buff, block_io, TOP );
+	sb_destroy( &sb );
+	
 	return proc_get_last_status();
 }