diff options
| author |  Kurtis Rader <krader@skepticism.us> | 2016-06-17 20:16:21 -0700 |
|---|---|---|
| committer | Kurtis Rader <krader@skepticism.us> | 2016-06-17 20:16:21 -0700 |
| commit | dc58edd521942c0a5a42541d5b5c39b09c226665 (patch) | |
| tree | f68df7afd78e084ae4771219ac658c3a18427a7b /CONTRIBUTING.md | |
| parent | e6d4ac5ee25f09bd661e0360844ca107fb6c3491 (diff) | |
implement custom cppcheck rules
I recently noticed there were several invocations of `wcwidth()` that should
have been `fish_wcwidth()`. This adds custom cppcheck rules to detect that
mistake.
Diffstat (limited to 'CONTRIBUTING.md')
| -rw-r--r-- | CONTRIBUTING.md | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 2e7733ab..bac0e467 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -30,6 +30,8 @@ Ultimately we want lint free code. However, at the moment a lot of cleanup is re To make linting the code easy there are two make targets: `lint` and `lint-all`. The latter does just what the name implies. The former will lint any modified but not committed `*.cpp` files. If there is no uncommitted work it will lint the files in the most recent commit. +Fish has custom cppcheck rules in the file `.cppcheck.rule`. These help catch mistakes such as using `wcwidth()` rather than `fish_wcwidth()`. Please add a new rule if you find similar mistakes being made. + ### Dealing With Lint Warnings You are strongly encouraged to address a lint warning by refactoring the code, changing variable names, or whatever action is implied by the warning. |