another wcstring to wchar_t * change

In keeping with the change made by @ridiculousfish earlier today modify
the `keyword_description()` function to return a const wchar_t pointer.

Also, simplify the `token_type_description()` function to use the recently
introduced mapping array. This changes the wording of many of the token
type descriptions. However, I can't see this as being a problem since
the original descriptions (e.g., "token_redirection") are no clearer to
someone not acquainted with the implementation.

5 files changed, 32 insertions, 117 deletions

diff --git a/src/fish_indent.cpp b/src/fish_indent.cpp
index 39d296e5..a469ccf7 100644
--- a/src/fish_indent.cpp
+++ b/src/fish_indent.cpp
@@ -104,7 +104,7 @@ static void dump_node(indent_t node_indent, const parse_node_t &node, const wcst
     }
     fwprintf(stderr, L"{off %4d, len %4d, indent %2u, kw %ls, %ls} [%ls|%ls|%ls]\n",
             node.source_start, node.source_length, node_indent,
-            keyword_description(node.keyword).c_str(), parser_token_types[node.type],
+            keyword_description(node.keyword), token_type_description(node.type),
             prevc_str, source.substr(node.source_start, node.source_length).c_str(), nextc_str);
 }
 
diff --git a/src/fish_tests.cpp b/src/fish_tests.cpp
index 6250513c..ef1956cc 100644
--- a/src/fish_tests.cpp
+++ b/src/fish_tests.cpp
@@ -3628,11 +3628,11 @@ static void test_new_parser_ll2(void)
         const parse_node_tree_t::parse_node_list_t node_list = tree.find_nodes(tree.at(0), tests2[i].type);
         if (node_list.size() == 0)
         {
-            err(L"Failed to find node of type '%ls'", token_type_description(tests2[i].type).c_str());
+            err(L"Failed to find node of type '%ls'", token_type_description(tests2[i].type));
         }
         else if (node_list.size() > 1)
         {
-            err(L"Found too many nodes of type '%ls'", token_type_description(tests2[i].type).c_str());
+            err(L"Found too many nodes of type '%ls'", token_type_description(tests2[i].type));
         }
     }
 }
diff --git a/src/parse_productions.cpp b/src/parse_productions.cpp
index 1a44ff48..6ec8e56a 100644
--- a/src/parse_productions.cpp
+++ b/src/parse_productions.cpp
@@ -409,7 +409,7 @@ const production_t *parse_productions::production_for_token(parse_token_type_t n
     const bool log_it = false;
     if (log_it)
     {
-        fprintf(stderr, "Resolving production for %ls with input token <%ls>\n", token_type_description(node_type).c_str(), input1.describe().c_str());
+        fprintf(stderr, "Resolving production for %ls with input token <%ls>\n", token_type_description(node_type), input1.describe().c_str());
     }
 
     /* Fetch the function to resolve the list of productions */
@@ -452,14 +452,14 @@ const production_t *parse_productions::production_for_token(parse_token_type_t n
         case parse_token_type_background:
         case parse_token_type_end:
         case parse_token_type_terminate:
-            fprintf(stderr, "Terminal token type %ls passed to %s\n", token_type_description(node_type).c_str(), __FUNCTION__);
+            fprintf(stderr, "Terminal token type %ls passed to %s\n", token_type_description(node_type), __FUNCTION__);
             PARSER_DIE();
             break;
 
         case parse_special_type_parse_error:
         case parse_special_type_tokenizer_error:
         case parse_special_type_comment:
-            fprintf(stderr, "Special type %ls passed to %s\n", token_type_description(node_type).c_str(), __FUNCTION__);
+            fprintf(stderr, "Special type %ls passed to %s\n", token_type_description(node_type), __FUNCTION__);
             PARSER_DIE();
             break;
 
@@ -477,7 +477,7 @@ const production_t *parse_productions::production_for_token(parse_token_type_t n
     {
         if (log_it)
         {
-            fprintf(stderr, "Node type '%ls' has no production for input '%ls' (in %s)\n", token_type_description(node_type).c_str(), input1.describe().c_str(), __FUNCTION__);
+            fprintf(stderr, "Node type '%ls' has no production for input '%ls' (in %s)\n", token_type_description(node_type), input1.describe().c_str(), __FUNCTION__);
         }
     }
 
diff --git a/src/parse_tree.cpp b/src/parse_tree.cpp
index adb2984f..95493955 100644
--- a/src/parse_tree.cpp
+++ b/src/parse_tree.cpp
@@ -17,7 +17,7 @@
 #include <algorithm>
 
 // This array provides strings for each symbol in enum parse_token_type_t in parse_constants.h.
-const wchar_t * const parser_token_types[] = {
+const wchar_t * const token_type_map[] = {
     L"token_type_invalid",
     L"symbol_job_list",
     L"symbol_job",
@@ -165,101 +165,16 @@ void parse_error_offset_source_start(parse_error_list_t *errors, size_t amt)
     }
 }
 
-/** Returns a string description of the given token type */
-wcstring token_type_description(parse_token_type_t type)
+// Returns a string description for the given token type.
+const wchar_t *token_type_description(parse_token_type_t type)
 {
-    switch (type)
-    {
-        case token_type_invalid:
-            return L"invalid";
-
-        case symbol_job_list:
-            return L"job_list";
-        case symbol_job:
-            return L"job";
-        case symbol_job_continuation:
-            return L"job_continuation";
-
-        case symbol_statement:
-            return L"statement";
-        case symbol_block_statement:
-            return L"block_statement";
-        case symbol_block_header:
-            return L"block_header";
-        case symbol_for_header:
-            return L"for_header";
-        case symbol_while_header:
-            return L"while_header";
-        case symbol_begin_header:
-            return L"begin_header";
-        case symbol_function_header:
-            return L"function_header";
-
-        case symbol_if_statement:
-            return L"if_statement";
-        case symbol_if_clause:
-            return L"if_clause";
-        case symbol_else_clause:
-            return L"else_clause";
-        case symbol_else_continuation:
-            return L"else_continuation";
-
-        case symbol_switch_statement:
-            return L"switch_statement";
-        case symbol_case_item_list:
-            return L"case_item_list";
-        case symbol_case_item:
-            return L"case_item";
-
-        case symbol_andor_job_list:
-            return L"andor_job_list";
-        case symbol_argument_list:
-            return L"argument_list";
-        case symbol_freestanding_argument_list:
-            return L"freestanding_argument_list";
-
-        case symbol_boolean_statement:
-            return L"boolean_statement";
-        case symbol_decorated_statement:
-            return L"decorated_statement";
-        case symbol_plain_statement:
-            return L"plain_statement";
-        case symbol_arguments_or_redirections_list:
-            return L"arguments_or_redirections_list";
-        case symbol_argument_or_redirection:
-            return L"argument_or_redirection";
-        case symbol_argument:
-            return L"symbol_argument";
-        case symbol_redirection:
-            return L"symbol_redirection";
-        case symbol_optional_background:
-            return L"optional_background";
-        case symbol_end_command:
-            return L"symbol_end_command";
-
+    if (type >= 0 && type <= LAST_TOKEN_TYPE) return token_type_map[type];
 
-        case parse_token_type_string:
-            return L"token_string";
-        case parse_token_type_pipe:
-            return L"token_pipe";
-        case parse_token_type_redirection:
-            return L"token_redirection";
-        case parse_token_type_background:
-            return L"token_background";
-        case parse_token_type_end:
-            return L"token_end";
-        case parse_token_type_terminate:
-            return L"token_terminate";
-
-        case parse_special_type_parse_error:
-            return L"parse_error";
-        case parse_special_type_tokenizer_error:
-            return L"tokenizer_error";
-        case parse_special_type_comment:
-            return L"comment";
-
-    }
-    return format_string(L"Unknown token type %ld", static_cast<long>(type));
+    // This leaks memory but it should never be run unless we have a bug elsewhere in the code.
+    const wcstring d = format_string(L"unknown_token_type_%ld", static_cast<long>(type));
+    wchar_t *d2 = new wchar_t[d.size() + 1];
+    // cppcheck-suppress memleak
+    return std::wcscpy(d2, d.c_str());
 }
 
 #define LONGIFY(x) L ## x
@@ -291,23 +206,22 @@ keyword_map[] =
     KEYWORD_MAP(while)
 };
 
-wcstring keyword_description(parse_keyword_t k)
+const wchar_t *keyword_description(parse_keyword_t type)
 {
-    if (k >= 0 && k <= LAST_KEYWORD)
-    {
-        return keyword_map[k].name;
-    }
-    else
-    {
-        return format_string(L"Unknown keyword type %ld", static_cast<long>(k));
-    }
+    if (type >= 0 && type <= LAST_KEYWORD) return keyword_map[type].name;
+
+    // This leaks memory but it should never be run unless we have a bug elsewhere in the code.
+    const wcstring d = format_string(L"unknown_keyword_%ld", static_cast<long>(type));
+    wchar_t *d2 = new wchar_t[d.size() + 1];
+    // cppcheck-suppress memleak
+    return std::wcscpy(d2, d.c_str());
 }
 
 static wcstring token_type_user_presentable_description(parse_token_type_t type, parse_keyword_t keyword = parse_keyword_none)
 {
     if (keyword != parse_keyword_none)
     {
-        return format_string(L"keyword '%ls'", keyword_description(keyword).c_str());
+        return format_string(L"keyword '%ls'", keyword_description(keyword));
     }
 
     switch (type)
@@ -338,7 +252,7 @@ static wcstring token_type_user_presentable_description(parse_token_type_t type,
             return L"end of the input";
 
         default:
-            return format_string(L"a %ls", token_type_description(type).c_str());
+            return format_string(L"a %ls", token_type_description(type));
     }
 }
 
@@ -383,7 +297,7 @@ wcstring parse_token_t::describe() const
     wcstring result = token_type_description(type);
     if (keyword != parse_keyword_none)
     {
-        append_format(result, L" <%ls>", keyword_description(keyword).c_str());
+        append_format(result, L" <%ls>", keyword_description(keyword));
     }
     return result;
 }
@@ -542,7 +456,7 @@ struct parse_stack_element_t
         wcstring result = token_type_description(type);
         if (keyword != parse_keyword_none)
         {
-            append_format(result, L" <%ls>", keyword_description(keyword).c_str());
+            append_format(result, L" <%ls>", keyword_description(keyword));
         }
         return result;
     }
@@ -611,7 +525,8 @@ class parse_ll_t
                 {
                     parse_token_type_t type = production_element_type(elem);
                     parse_keyword_t keyword = production_element_keyword(elem);
-                    fprintf(stderr, "\t%ls <%ls>\n", token_type_description(type).c_str(), keyword_description(keyword).c_str());
+                    fprintf(stderr, "\t%ls <%ls>\n", token_type_description(type),
+                            keyword_description(keyword));
                     count++;
                 }
             }
diff --git a/src/parse_tree.h b/src/parse_tree.h
index 67632685..8ae9ee88 100644
--- a/src/parse_tree.h
+++ b/src/parse_tree.h
@@ -63,8 +63,8 @@ typedef unsigned int parse_tree_flags_t;
 
 wcstring parse_dump_tree(const parse_node_tree_t &tree, const wcstring &src);
 
-wcstring token_type_description(parse_token_type_t type);
-wcstring keyword_description(parse_keyword_t type);
+const wchar_t *token_type_description(parse_token_type_t type);
+const wchar_t *keyword_description(parse_keyword_t type);
 
 /* Node flags */
 enum