Tests and fix to allow return to work correctly within if statements. Closes #1297.

3 files changed, 16 insertions, 0 deletions

diff --git a/parse_execution.cpp b/parse_execution.cpp
index 08f222ed..11aa5325 100644
--- a/parse_execution.cpp
+++ b/parse_execution.cpp
@@ -325,6 +325,12 @@ parse_execution_result_t parse_execution_context_t::run_if_statement(const parse
     {
         run_job_list(*job_list_to_execute, ib);
     }
+    
+    /* It's possible there's a last-minute cancellation, in which case we should not stomp the exit status (#1297) */
+    if (should_cancel_execution(ib))
+    {
+        result = parse_execution_cancelled;
+    }
 
     /* Done */
     parser->pop_block(ib);
diff --git a/tests/test1.in b/tests/test1.in
index 7f60a4da..529baea1 100644
--- a/tests/test1.in
+++ b/tests/test1.in
@@ -121,3 +121,12 @@ echo -e Catch your breath
 
 echo -e 'abc\x21def'
 echo -e 'abc\x211def'
+
+function always_fails
+    if true
+        return 1
+    end
+end
+
+always_fails ; echo $status
+
diff --git a/tests/test1.out b/tests/test1.out
index b3460cdd..893e0464 100644
--- a/tests/test1.out
+++ b/tests/test1.out
@@ -36,3 +36,4 @@ abc
 Catch your breath
 abc!def
 abc!1def
+1