diff options
author | rsgowman <rgowman@google.com> | 2018-02-16 09:47:30 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-02-16 09:47:30 -0500 |
commit | 7a97f6c2abf39752bb66a520d57bc6e9c11b269d (patch) | |
tree | 1f2b91790187da1f97a5fcd3b5841d0d769c4991 /cmake | |
parent | 81ee594e325a922a91557d82563132f22977c947 (diff) |
Enable -Wcomma for our build; disable it for abseil. (#799)
In order to use different cflags for abseil, this patch splits it out
into a subspec within the pod.
The cmake side of things "just works" since Firestore/CMakeLists.txt
includes abseil before setting our compiler flags.
Diffstat (limited to 'cmake')
-rw-r--r-- | cmake/CompilerSetup.cmake | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/cmake/CompilerSetup.cmake b/cmake/CompilerSetup.cmake index aa4289a..b560027 100644 --- a/cmake/CompilerSetup.cmake +++ b/cmake/CompilerSetup.cmake @@ -61,6 +61,9 @@ if(CLANG OR GNU) APPEND common_flags -Wconditional-uninitialized -Werror=return-type -Winfinite-recursion -Wmove -Wrange-loop-analysis -Wunreachable-code + + # Options added to match apple recommended project settings + -Wcomma ) endif() |