From 7a97f6c2abf39752bb66a520d57bc6e9c11b269d Mon Sep 17 00:00:00 2001 From: rsgowman Date: Fri, 16 Feb 2018 09:47:30 -0500 Subject: Enable -Wcomma for our build; disable it for abseil. (#799) In order to use different cflags for abseil, this patch splits it out into a subspec within the pod. The cmake side of things "just works" since Firestore/CMakeLists.txt includes abseil before setting our compiler flags. --- cmake/CompilerSetup.cmake | 3 +++ 1 file changed, 3 insertions(+) (limited to 'cmake') diff --git a/cmake/CompilerSetup.cmake b/cmake/CompilerSetup.cmake index aa4289a..b560027 100644 --- a/cmake/CompilerSetup.cmake +++ b/cmake/CompilerSetup.cmake @@ -61,6 +61,9 @@ if(CLANG OR GNU) APPEND common_flags -Wconditional-uninitialized -Werror=return-type -Winfinite-recursion -Wmove -Wrange-loop-analysis -Wunreachable-code + + # Options added to match apple recommended project settings + -Wcomma ) endif() -- cgit v1.2.3