Port PrimitiveValueTest test for core::Query (#1530)

(From java.)

Also fix a bug uncovered by the test. (oops)

1 files changed, 2 insertions, 2 deletions

diff --git a/Firestore/core/src/firebase/firestore/core/filter.cc b/Firestore/core/src/firebase/firestore/core/filter.cc
index 4c27f27..ea0fab3 100644
--- a/Firestore/core/src/firebase/firestore/core/filter.cc
+++ b/Firestore/core/src/firebase/firestore/core/filter.cc
@@ -29,11 +29,11 @@ using model::FieldValue;
 
 std::shared_ptr<Filter> Filter::Create(FieldPath path,
                                        Operator op,
-                                       FieldValue value) {
+                                       FieldValue value_rhs) {
   // TODO(rsgowman): Java performs a number of checks here, and then invokes the
   // ctor of the relevant Filter subclass. Port those checks here.
   return std::make_shared<RelationFilter>(std::move(path), op,
-                                          std::move(value));
+                                          std::move(value_rhs));
 }
 
 }  // namespace core