From 890321214cc8340c9eb02712f63799085f3ea112 Mon Sep 17 00:00:00 2001 From: rsgowman Date: Tue, 17 Jul 2018 10:28:25 -0400 Subject: Port PrimitiveValueTest test for core::Query (#1530) (From java.) Also fix a bug uncovered by the test. (oops) --- Firestore/core/src/firebase/firestore/core/filter.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'Firestore/core/src/firebase/firestore/core/filter.cc') diff --git a/Firestore/core/src/firebase/firestore/core/filter.cc b/Firestore/core/src/firebase/firestore/core/filter.cc index 4c27f27..ea0fab3 100644 --- a/Firestore/core/src/firebase/firestore/core/filter.cc +++ b/Firestore/core/src/firebase/firestore/core/filter.cc @@ -29,11 +29,11 @@ using model::FieldValue; std::shared_ptr Filter::Create(FieldPath path, Operator op, - FieldValue value) { + FieldValue value_rhs) { // TODO(rsgowman): Java performs a number of checks here, and then invokes the // ctor of the relevant Filter subclass. Port those checks here. return std::make_shared(std::move(path), op, - std::move(value)); + std::move(value_rhs)); } } // namespace core -- cgit v1.2.3