diff options
author | Tal Hadad <tal_hd@hotmail.com> | 2016-06-02 22:12:57 +0300 |
---|---|---|
committer | Tal Hadad <tal_hd@hotmail.com> | 2016-06-02 22:12:57 +0300 |
commit | 2aaaf22623cdd92a772fc7e0f6523ae2c423e5de (patch) | |
tree | 5dc29c221a88504f805830d80cb6a16b1f25a727 /unsupported/Eigen/EulerAngles | |
parent | c006ecace15602e8c4b9a543af108a1dadc080db (diff) |
Fix Gael reports (except documention)
- "Scalar angle(int) const" should be "const Vector& angles() const"
- then method "coeffs" could be removed.
- avoid one letter names like h, p, r -> use alpha(), beta(), gamma() ;)
- about the "fromRotation" methods:
- replace the ones which are not static by operator= (as in Quaternion)
- the others are actually static methods: use a capital F: FromRotation
- method "invert" should be removed.
- use a macro to define both float and double EulerAnglesXYZ* typedefs
- AddConstIf -> not used
- no needs for NegateIfXor, compilers are extremely good at optimizing away branches based on compile time constants:
if(IsHeadingOpposite-=IsEven) res.alpha() = -res.alpha();
Diffstat (limited to 'unsupported/Eigen/EulerAngles')
-rw-r--r-- | unsupported/Eigen/EulerAngles | 18 |
1 files changed, 12 insertions, 6 deletions
diff --git a/unsupported/Eigen/EulerAngles b/unsupported/Eigen/EulerAngles index a1aa5d829..08cc74237 100644 --- a/unsupported/Eigen/EulerAngles +++ b/unsupported/Eigen/EulerAngles @@ -16,13 +16,19 @@ #include "Eigen/src/Core/util/DisableStupidWarnings.h" +namespace Eigen { + /** - * \defgroup EulerAngles_Module EulerAngles module - * - * - * - * - */ + * \defgroup EulerAngles_Module EulerAngles module + * \brief This module provides generic euler angles rotation. + * + * \code + * #include <unsupported/Eigen/EulerAngles> + * \endcode + * + */ + +} #include "src/EulerAngles/EulerSystem.h" #include "src/EulerAngles/EulerAngles.h" |