src/tools/skylark/java/com/google/devtools/skylark/skylint/BadOperationChecker.java


1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66

// Copyright 2017 The Bazel Authors. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
//    http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package com.google.devtools.skylark.skylint;

import com.google.devtools.build.lib.syntax.AugmentedAssignmentStatement;
import com.google.devtools.build.lib.syntax.BinaryOperatorExpression;
import com.google.devtools.build.lib.syntax.BuildFileAST;
import com.google.devtools.build.lib.syntax.DictComprehension;
import com.google.devtools.build.lib.syntax.DictionaryLiteral;
import com.google.devtools.build.lib.syntax.Operator;
import com.google.devtools.build.lib.syntax.SyntaxTreeVisitor;
import java.util.ArrayList;
import java.util.List;

/** Checks for operations that are deprecated */
public class BadOperationChecker extends SyntaxTreeVisitor {
  private final List<Issue> issues = new ArrayList<>();

  private BadOperationChecker() {}

  public static List<Issue> check(BuildFileAST ast) {
    BadOperationChecker checker = new BadOperationChecker();
    checker.visit(ast);
    return checker.issues;
  }

  @Override
  public void visit(BinaryOperatorExpression node) {
    super.visit(node);
    if (node.getOperator() == Operator.PLUS) {
      if (node.getLhs() instanceof DictionaryLiteral
          || node.getLhs() instanceof DictComprehension
          || node.getRhs() instanceof DictionaryLiteral
          || node.getRhs() instanceof DictComprehension) {
        issues.add(
            new Issue(
                "'+' operator is deprecated and should not be used on dictionaries",
                node.getLocation()));
      }
    }
  }

  @Override
  public void visit(AugmentedAssignmentStatement node) {
    super.visit(node);
    if (node.getExpression() instanceof DictionaryLiteral
        || node.getExpression() instanceof DictComprehension) {
      issues.add(
          new Issue(
              "'+' operator is deprecated and should not be used on dictionaries",
              node.getLocation()));
    }
  }
}