1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
|
#!/bin/bash
#
# Copyright 2018 The Bazel Authors. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
# Load the test setup defined in the parent directory
CURRENT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
source "${CURRENT_DIR}/../integration_test_setup.sh" \
|| { echo "integration_test_setup.sh not found!" >&2; exit 1; }
test_result_recorded() {
mkdir result_recorded && cd result_recorded
rm -rf fetchrepo
mkdir fetchrepo
cd fetchrepo
cat > rule.bzl <<'EOF'
def _rule_impl(ctx):
ctx.symlink(ctx.attr.build_file, "BUILD")
return {"build_file": ctx.attr.build_file, "extra_arg": "foobar"}
trivial_rule = repository_rule(
implementation = _rule_impl,
attrs = { "build_file" : attr.label() },
)
EOF
cat > ext.BUILD <<'EOF'
genrule(
name = "foo",
outs = ["foo.txt"],
cmd = "echo bar > $@",
)
EOF
touch BUILD
cat > WORKSPACE <<'EOF'
load("//:rule.bzl", "trivial_rule")
trivial_rule(
name = "ext",
build_file = "//:ext.BUILD",
)
EOF
bazel clean --expunge
bazel build --experimental_repository_resolved_file=../repo.bzl @ext//... \
|| fail "Expected success"
# some of the file systems on our test machines are really slow to
# notice the creation of a file---even after the call to sync(1).
bazel shutdown; sync; sleep 10
# Verify that bazel can read the generated repo.bzl file and that it contains
# the expected information
cd ..
echo; cat repo.bzl; echo; echo
mkdir analysisrepo
mv repo.bzl analysisrepo
cd analysisrepo
touch WORKSPACE
cat > BUILD <<'EOF'
load("//:repo.bzl", "resolved")
[ genrule(
name = "out",
outs = ["out.txt"],
cmd = "echo %s > $@" % entry["repositories"][0]["attributes"]["extra_arg"],
) for entry in resolved if entry["original_rule_class"] == "//:rule.bzl%trivial_rule"
]
[ genrule(
name = "origcount",
outs = ["origcount.txt"],
cmd = "echo %s > $@" % len(entry["original_attributes"])
) for entry in resolved if entry["original_rule_class"] == "//:rule.bzl%trivial_rule"
]
EOF
bazel build :out :origcount || fail "Expected success"
grep "foobar" `bazel info bazel-genfiles`/out.txt \
|| fail "Did not find the expected value"
[ $(cat `bazel info bazel-genfiles`/origcount.txt) -eq 2 ] \
|| fail "Not the correct number of original attributes"
}
test_git_return_value() {
EXTREPODIR=`pwd`
export GIT_CONFIG_NOSYSTEM=YES
mkdir extgit
(cd extgit && git init \
&& git config user.email 'me@example.com' \
&& git config user.name 'E X Ample' )
echo Hello World > extgit/hello.txt
(cd extgit
git add .
git commit --author="A U Thor <author@example.com>" -m 'initial commit'
git tag mytag)
# Check out the external git repository at the given tag, and record
# the return value of the git rule.
mkdir tagcheckout
cd tagcheckout
cat > WORKSPACE <<EOF
load("@bazel_tools//tools/build_defs/repo:git.bzl", "new_git_repository")
new_git_repository(
name="ext",
remote="file://${EXTREPODIR}/extgit/.git",
tag="mytag",
build_file_content="exports_files([\"hello.txt\"])",
)
EOF
bazel sync --experimental_repository_resolved_file=../repo.bzl
# some of the file systems on our test machines are really slow to
# notice the creation of a file---even after the call to sync(1).
bazel shutdown; sync; sleep 10
cd ..
echo; cat repo.bzl; echo
# Now add an additional commit to the upstream repository and
# force update the tag
echo CHANGED > extgit/hello.txt
(cd extgit
git add .
git commit --author="A U Thor <author@example.com>" -m 'change hello.txt'
git tag -f mytag)
# Verify that the recorded resolved information is what we expect. In
# particular, verify that we don't get the new upstream commit.
mkdir analysisrepo
cd analysisrepo
cp ../repo.bzl .
cat > workspace.bzl <<'EOF'
load("@bazel_tools//tools/build_defs/repo:git.bzl", "new_git_repository")
load("//:repo.bzl", "resolved")
def repo():
for entry in resolved:
if entry["original_attributes"]["name"] == "ext":
new_git_repository(**(entry["repositories"][0]["attributes"]))
EOF
cat > WORKSPACE <<'EOF'
load("//:workspace.bzl", "repo")
repo()
EOF
cat > BUILD <<'EOF'
genrule(
name = "out",
outs = ["out.txt"],
srcs = ["@ext//:hello.txt"],
cmd = "cp $< $@",
)
EOF
bazel build //:out
grep "Hello World" `bazel info bazel-genfiles`/out.txt \
|| fail "ext not taken at the right commit"
grep "CHANGED" `bazel info bazel-genfiles`/out.txt \
&& fail "not taking the frozen commit" || :
}
test_git_follow_branch() {
EXTREPODIR=`pwd`
export GIT_CONFIG_NOSYSTEM=YES
mkdir extgit
(cd extgit && git init \
&& git config user.email 'me@example.com' \
&& git config user.name 'E X Ample' )
echo Hello World > extgit/hello.txt
(cd extgit
git add .
git commit --author="A U Thor <author@example.com>" -m 'initial commit')
# Check out the external git repository at the given branch, and record
# the return value of the git rule.
mkdir branchcheckout
cd branchcheckout
cat > WORKSPACE <<EOF
load("@bazel_tools//tools/build_defs/repo:git.bzl", "new_git_repository")
new_git_repository(
name="ext",
remote="file://${EXTREPODIR}/extgit/.git",
branch="master",
build_file_content="exports_files([\"hello.txt\"])",
)
EOF
cat > BUILD <<'EOF'
genrule(
name = "out",
outs = ["out.txt"],
srcs = ["@ext//:hello.txt"],
cmd = "cp $< $@",
)
EOF
bazel sync --experimental_repository_resolved_file=../repo.bzl
bazel build :out
grep "CHANGED" `bazel info bazel-genfiles`/out.txt \
&& fail "Unexpected content in out.txt" || :
cd ..
echo; cat repo.bzl; echo
# Now add an additional commit to the upstream repository
echo CHANGED > extgit/hello.txt
(cd extgit
git add .
git commit --author="A U Thor <author@example.com>" -m 'change hello.txt')
# First verify that `bazel sync` sees the new commit (we don't record it).
cd branchcheckout
bazel sync
bazel build :out
grep "CHANGED" `bazel info bazel-genfiles`/out.txt \
|| fail "sync did not update the external repository"
bazel shutdown; sync; sleep 10
cd ..
echo
# Verify that the recorded resolved information is what we expect. In
# particular, verify that we don't get the new upstream commit.
mkdir analysisrepo
cd analysisrepo
cp ../repo.bzl .
cat > workspace.bzl <<'EOF'
load("@bazel_tools//tools/build_defs/repo:git.bzl", "new_git_repository")
load("//:repo.bzl", "resolved")
def repo():
for entry in resolved:
if entry["original_attributes"]["name"] == "ext":
new_git_repository(**(entry["repositories"][0]["attributes"]))
EOF
cat > WORKSPACE <<'EOF'
load("//:workspace.bzl", "repo")
repo()
EOF
cat > BUILD <<'EOF'
genrule(
name = "out",
outs = ["out.txt"],
srcs = ["@ext//:hello.txt"],
cmd = "cp $< $@",
)
EOF
bazel build //:out
grep "Hello World" `bazel info bazel-genfiles`/out.txt \
|| fail "ext not taken at the right commit"
grep "CHANGED" `bazel info bazel-genfiles`/out.txt \
&& fail "not taking the frozen commit" || :
}
test_sync_follows_git_branch() {
EXTREPODIR=`pwd`
export GIT_CONFIG_NOSYSTEM=YES
rm -f gitdir
mkdir gitdir
(cd gitdir && git init \
&& git config user.email 'me@example.com' \
&& git config user.name 'E X Ample' )
echo Hello World > gitdir/hello.txt
(cd gitdir
git add .
git commit --author="A U Thor <author@example.com>" -m 'initial commit')
echo Hello Stable World > gitdir/hello.txt
(cd gitdir
git checkout -b stable
git add .
git commit --author="A U Thor <author@example.com>" -m 'stable commit')
# Follow the stable branch of the git repository
mkdir followbranch
cat > followbranch/WORKSPACE <<EOF
load("@bazel_tools//tools/build_defs/repo:git.bzl", "new_git_repository")
new_git_repository(
name="ext",
remote="file://${EXTREPODIR}/gitdir/.git",
branch="stable",
build_file_content="exports_files([\"hello.txt\"])",
)
EOF
cat > followbranch/BUILD <<'EOF'
genrule(
name = "out",
outs = ["out.txt"],
srcs = ["@ext//:hello.txt"],
cmd = "cp $< $@",
)
EOF
(cd followbranch && bazel build :out \
&& cat `bazel info bazel-genfiles`/out.txt > "${TEST_log}")
expect_log 'Hello Stable World'
# New upstream commits on the branch followed
echo CHANGED > gitdir/hello.txt
(cd gitdir
git checkout stable
git add .
git commit --author="A U Thor <author@example.com>" -m 'stable commit')
# Verify that sync followed by build gets the correct version
(cd followbranch && bazel sync && bazel build :out \
&& cat `bazel info bazel-genfiles`/out.txt > "${TEST_log}")
expect_log 'CHANGED'
expect_not_log 'Hello Stable World'
}
test_sync_calls_all() {
mkdir sync_calls_all && cd sync_calls_all
rm -rf fetchrepo
mkdir fetchrepo
rm -f repo.bzl
cd fetchrepo
cat > rule.bzl <<'EOF'
def _rule_impl(ctx):
ctx.file("foo.bzl", """
it = "foo"
other = "bar"
""")
ctx.file("BUILD", "")
return {"comment" : ctx.attr.comment }
trivial_rule = repository_rule(
implementation = _rule_impl,
attrs = { "comment" : attr.string() },
)
EOF
touch BUILD
cat > WORKSPACE <<'EOF'
load("//:rule.bzl", "trivial_rule")
trivial_rule(name = "a", comment = "bootstrap")
load("@a//:foo.bzl", "it")
trivial_rule(name = "b", comment = it)
trivial_rule(name = "c", comment = it)
load("@c//:foo.bzl", "other")
trivial_rule(name = "d", comment = other)
EOF
bazel clean --expunge
bazel sync --experimental_repository_resolved_file=../repo.bzl
# some of the file systems on our test machines are really slow to
# notice the creation of a file---even after the call to sync(1).
bazel shutdown; sync; sleep 10
cd ..
echo; cat repo.bzl; echo
touch WORKSPACE
cat > BUILD <<'EOF'
load("//:repo.bzl", "resolved")
names = [entry["original_attributes"]["name"] for entry in resolved]
[
genrule(
name = name,
outs = [ "%s.txt" % (name,) ],
cmd = "echo %s > $@" % (name,),
) for name in names
]
EOF
bazel build :a :b :c :d || fail "Expected all 4 repositories to be present"
}
test_sync_call_invalidates() {
mkdir sync_call_invalidates && cd sync_call_invalidates
rm -rf fetchrepo
mkdir fetchrepo
rm -f repo.bzl
touch BUILD
cat > rule.bzl <<'EOF'
def _rule_impl(ctx):
ctx.file("BUILD", """
genrule(
name = "it",
outs = ["it.txt"],
cmd = "echo hello world > $@",
)
""")
ctx.file("WORKSPACE", "")
trivial_rule = repository_rule(
implementation = _rule_impl,
attrs = {},
)
EOF
cat > WORKSPACE <<'EOF'
load("//:rule.bzl", "trivial_rule")
trivial_rule(name = "a")
trivial_rule(name = "b")
EOF
bazel build @a//... @b//...
echo; echo sync run; echo
bazel sync --experimental_repository_resolved_file=../repo.bzl
# some of the file systems on our test machines are really slow to
# notice the creation of a file---even after the call to sync(1).
bazel shutdown; sync; sleep 10
cd ..
echo; cat repo.bzl; echo
touch WORKSPACE
cat > BUILD <<'EOF'
load("//:repo.bzl", "resolved")
names = [entry["original_attributes"]["name"] for entry in resolved]
[
genrule(
name = name,
outs = [ "%s.txt" % (name,) ],
cmd = "echo %s > $@" % (name,),
) for name in names
]
EOF
bazel build :a :b || fail "Expected both repositories to be present"
}
test_sync_load_errors_reported() {
rm -rf fetchrepo
mkdir fetchrepo
cd fetchrepo
cat > WORKSPACE <<'EOF'
load("//does/not:exist.bzl", "randomfunction")
radomfunction(name="foo")
EOF
bazel sync > "${TEST_log}" 2>&1 && fail "Expected failure" || :
expect_log '//does/not:exist.bzl'
}
test_sync_debug_and_errors_printed() {
rm -rf fetchrepo
mkdir fetchrepo
cd fetchrepo
cat > rule.bzl <<'EOF'
def _broken_rule_impl(ctx):
print("DEBUG-message")
fail("Failure-message")
broken_rule = repository_rule(
implementation = _broken_rule_impl,
attrs = {},
)
EOF
touch BUILD
cat > WORKSPACE <<'EOF'
load("//:rule.bzl", "broken_rule")
broken_rule(name = "broken")
EOF
bazel sync > "${TEST_log}" 2>&1 && fail "expected failure" || :
expect_log "DEBUG-message"
expect_log "Failure-message"
}
test_indirect_call() {
rm -rf fetchrepo
mkdir fetchrepo
cd fetchrepo
touch BUILD
cat > rule.bzl <<'EOF'
def _trivial_rule_impl(ctx):
ctx.file("BUILD","genrule(name='hello', outs=['hello.txt'], cmd=' echo hello world > $@')")
trivial_rule = repository_rule(
implementation = _trivial_rule_impl,
attrs = {},
)
EOF
cat > indirect.bzl <<'EOF'
def call(fn_name, **args):
fn_name(**args)
EOF
cat > WORKSPACE <<'EOF'
load("//:rule.bzl", "trivial_rule")
load("//:indirect.bzl", "call")
call(trivial_rule, name="foo")
EOF
bazel sync --experimental_repository_resolved_file=../repo.bzl
bazel shutdown; sync; sleep 10
cd ..
echo; cat repo.bzl; echo
touch WORKSPACE
cat > BUILD <<'EOF'
load("//:repo.bzl", "resolved")
ruleclass = "".join([entry["original_rule_class"] for entry in resolved if entry["original_attributes"]["name"]=="foo"])
genrule(
name = "ruleclass",
outs = ["ruleclass.txt"],
cmd = "echo %s > $@" % (ruleclass,)
)
EOF
bazel build //:ruleclass
cat `bazel info bazel-genfiles`/ruleclass.txt > ${TEST_log}
expect_log '//:rule.bzl%trivial_rule'
expect_not_log 'fn_name'
}
create_sample_repository() {
# Create, in the current direcotry, a repository that creates an external
# repository `foo` containing
# - file with fixed data, generated by ctx.file,
# - a BUILD file linked from the main repository
# - a symlink to ., and
# - danling absolute and reproducible symlink.
touch BUILD
cat > rule.bzl <<'EOF'
def _trivial_rule_impl(ctx):
ctx.symlink(ctx.attr.build_file, "BUILD")
ctx.file("data.txt", "some data")
ctx.execute(["ln", "-s", ".", "self_link"])
ctx.execute(["ln", "-s", "/does/not/exist", "dangling"])
trivial_rule = repository_rule(
implementation = _trivial_rule_impl,
attrs = { "build_file" : attr.label() },
)
EOF
echo '# fixed contents' > BUILD.remote
cat > WORKSPACE <<'EOF'
load("//:rule.bzl", "trivial_rule")
trivial_rule(name="foo", build_file="@//:BUILD.remote")
EOF
}
test_hash_included_and_reproducible() {
# Verify that a hash of the output directory is included, that
# the hash is invariant under
# - change of the working directory, and
# - and current time.
rm -rf fetchrepoA
mkdir fetchrepoA
cd fetchrepoA
create_sample_repository
bazel sync --experimental_repository_resolved_file=../repo.bzl
bazel shutdown; sync; sleep 10
cd ..
echo; cat repo.bzl; echo
touch WORKSPACE
cat > BUILD <<'EOF'
load("//:repo.bzl", "resolved")
hashes = [entry["repositories"][0]["output_tree_hash"]
for entry in resolved if entry["original_attributes"]["name"]=="foo"]
[genrule(
name="hash",
outs=["hash.txt"],
cmd="echo '%s' > $@" % (hash,),
) for hash in hashes]
EOF
bazel build //:hash
cp `bazel info bazel-genfiles`/hash.txt hashA.txt
cat hashA.txt > "${TEST_log}"
[ `cat hashA.txt | wc -c` -gt 2 ] \
|| fail "A hash of reasonable length expected"
bazel clean --expunge
rm repo.bzl
rm -rf fetchrepoB
mkdir fetchrepoB
cd fetchrepoB
create_sample_repository
bazel sync --experimental_repository_resolved_file=../repo.bzl
bazel shutdown; sync; sleep 10
cd ..
echo; cat repo.bzl; echo
bazel build //:hash
cp `bazel info bazel-genfiles`/hash.txt hashB.txt
cat hashB.txt > "${TEST_log}"
diff hashA.txt hashB.txt || fail "Expected hash to be reproducible"
}
test_non_reproducibility_detected() {
# Verify that a non-reproducible rule is detected by hash verification
mkdir repo
cd repo
touch BUILD
cat > rule.bzl <<'EOF'
def _time_rule_impl(ctx):
ctx.execute(["bash", "-c", "date +%s > timestamp"])
time_rule = repository_rule(
implementation = _time_rule_impl,
attrs = {},
)
EOF
cat > WORKSPACE <<'EOF'
load("//:rule.bzl", "time_rule")
time_rule(name="timestamprepo")
EOF
bazel sync --experimental_repository_resolved_file=resolved.bzl
sync; sleep 10
bazel sync --experimental_repository_hash_file=`pwd`/resolved.bzl \
--experimental_verify_repository_rules='//:rule.bzl%time_rule' \
> "${TEST_log}" 2>&1 && fail "expected failure" || :
expect_log "timestamprepo.*hash"
}
run_suite "workspace_resolved_test tests"
|