1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
|
// Copyright 2016 The Bazel Authors. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package com.google.devtools.build.lib.runtime;
import static com.google.common.truth.Truth.assertWithMessage;
import com.google.common.collect.Collections2;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableMap;
import com.google.common.collect.ImmutableSet;
import com.google.common.collect.Iterables;
import com.google.common.collect.Lists;
import com.google.devtools.build.lib.analysis.BlazeDirectories;
import com.google.devtools.build.lib.analysis.ConfiguredRuleClassProvider;
import com.google.devtools.build.lib.analysis.ServerDirectories;
import com.google.devtools.build.lib.analysis.config.BuildConfiguration;
import com.google.devtools.build.lib.analysis.config.BuildOptions;
import com.google.devtools.build.lib.analysis.config.FragmentOptions;
import com.google.devtools.build.lib.bazel.rules.DefaultBuildOptionsForDiffing;
import com.google.devtools.build.lib.cmdline.Label;
import com.google.devtools.build.lib.testutil.Scratch;
import com.google.devtools.build.lib.testutil.TestConstants;
import com.google.devtools.build.lib.util.ExitCode;
import com.google.devtools.build.lib.util.io.RecordingOutErr;
import com.google.devtools.common.options.Option;
import com.google.devtools.common.options.OptionDocumentationCategory;
import com.google.devtools.common.options.OptionEffectTag;
import com.google.devtools.common.options.OptionsBase;
import com.google.devtools.common.options.OptionsParser;
import com.google.devtools.common.options.OptionsProvider;
import java.util.List;
import java.util.Map;
import java.util.Set;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
/** Tests the handling of rc-options in {@link BlazeCommandDispatcher}. */
@RunWith(JUnit4.class)
public class BlazeCommandDispatcherRcoptionsTest {
/**
* Example options to be used by the tests.
*/
public static class FooOptions extends OptionsBase {
@Option(
name = "numoption",
documentationCategory = OptionDocumentationCategory.UNCATEGORIZED,
effectTags = {OptionEffectTag.NO_OP},
defaultValue = "0"
)
public int numOption;
@Option(
name = "stringoption",
documentationCategory = OptionDocumentationCategory.UNCATEGORIZED,
effectTags = {OptionEffectTag.NO_OP},
defaultValue = "[unspecified]"
)
public String stringOption;
}
@Command(
name = "reportnum",
options = {FooOptions.class},
shortDescription = "",
help = ""
)
private static class ReportNumCommand implements BlazeCommand {
@Override
public BlazeCommandResult exec(CommandEnvironment env, OptionsProvider options) {
FooOptions fooOptions = options.getOptions(FooOptions.class);
env.getReporter().getOutErr().printOut("" + fooOptions.numOption);
return BlazeCommandResult.exitCode(ExitCode.SUCCESS);
}
@Override
public void editOptions(OptionsParser optionsParser) {}
}
@Command(
name = "reportall",
options = {FooOptions.class},
shortDescription = "",
help = ""
)
private static class ReportAllCommand implements BlazeCommand {
@Override
public BlazeCommandResult exec(CommandEnvironment env, OptionsProvider options) {
FooOptions fooOptions = options.getOptions(FooOptions.class);
env.getReporter()
.getOutErr()
.printOut("" + fooOptions.numOption + " " + fooOptions.stringOption);
return BlazeCommandResult.exitCode(ExitCode.SUCCESS);
}
@Override
public void editOptions(OptionsParser optionsParser) {}
}
@Command(
name = "reportallinherited",
options = {FooOptions.class},
shortDescription = "",
help = "",
inherits = ReportAllCommand.class
)
private static class ReportAllInheritedCommand extends ReportAllCommand {
}
private final Scratch scratch = new Scratch();
private final RecordingOutErr outErr = new RecordingOutErr();
private final ReportNumCommand reportNum = new ReportNumCommand();
private final ReportAllCommand reportAll = new ReportAllCommand();
private final ReportAllCommand reportAllInherited = new ReportAllInheritedCommand();
private BlazeRuntime runtime;
@Before
public final void initializeRuntime() throws Exception {
String productName = TestConstants.PRODUCT_NAME;
ServerDirectories serverDirectories =
new ServerDirectories(
scratch.dir("install_base"),
scratch.dir("output_base"),
scratch.dir("user_output_root"));
this.runtime =
new BlazeRuntime.Builder()
.setFileSystem(scratch.getFileSystem())
.setProductName(productName)
.setServerDirectories(serverDirectories)
.setStartupOptionsProvider(
OptionsParser.newOptionsParser(BlazeServerStartupOptions.class))
.addBlazeModule(
new BlazeModule() {
@Override
public void initializeRuleClasses(ConfiguredRuleClassProvider.Builder builder) {
// We must add these options so that the defaults package can be created.
builder.addConfigurationOptions(BuildConfiguration.Options.class);
// The defaults package asserts that it is not empty, so we provide options.
builder.addConfigurationOptions(MockFragmentOptions.class);
// The tools repository is needed for createGlobals
builder.setToolsRepository(TestConstants.TOOLS_REPOSITORY);
}
})
.addBlazeModule(
new BlazeModule() {
@Override
public BuildOptions getDefaultBuildOptions(BlazeRuntime runtime) {
return DefaultBuildOptionsForDiffing.getDefaultBuildOptionsForFragments(
runtime.getRuleClassProvider().getConfigurationOptions());
}
})
.build();
BlazeDirectories directories =
new BlazeDirectories(
serverDirectories, scratch.dir("pkg"), /* defaultSystemJavabase= */ null, productName);
this.runtime.initWorkspace(directories, /*binTools=*/null);
}
@Test
public void testCommonUsed() throws Exception {
List<String> blazercOpts =
ImmutableList.of(
"--rc_source=/home/jrluser/.blazerc", "--default_override=0:common=--numoption=99");
BlazeCommandDispatcher dispatch = new BlazeCommandDispatcher(runtime, reportNum);
List<String> cmdLine = Lists.newArrayList("reportnum");
cmdLine.addAll(blazercOpts);
dispatch.exec(cmdLine, "test", outErr);
String out = outErr.outAsLatin1();
assertWithMessage("Common options should be used").that(out).isEqualTo("99");
}
@Test
public void testSpecificOptionsWin() throws Exception {
List<String> blazercOpts =
ImmutableList.of(
"--rc_source=/home/jrluser/.blazerc",
"--default_override=0:reportnum=--numoption=42",
"--default_override=0:common=--numoption=99");
BlazeCommandDispatcher dispatch = new BlazeCommandDispatcher(runtime, reportNum);
List<String> cmdLine = Lists.newArrayList("reportnum");
cmdLine.addAll(blazercOpts);
dispatch.exec(cmdLine, "test", outErr);
String out = outErr.outAsLatin1();
assertWithMessage("Specific options should dominate common options").that(out).isEqualTo("42");
}
@Test
public void testSpecificOptionsWinOtherOrder() throws Exception {
List<String> blazercOpts =
ImmutableList.of(
"--rc_source=/home/jrluser/.blazerc",
"--default_override=0:common=--numoption=99",
"--default_override=0:reportnum=--numoption=42");
BlazeCommandDispatcher dispatch = new BlazeCommandDispatcher(runtime, reportNum);
List<String> cmdLine = Lists.newArrayList("reportnum");
cmdLine.addAll(blazercOpts);
dispatch.exec(cmdLine, "test", outErr);
String out = outErr.outAsLatin1();
assertWithMessage("Specific options should dominate common options").that(out).isEqualTo("42");
}
@Test
public void testOptionsCombined() throws Exception {
List<String> blazercOpts =
ImmutableList.of(
"--rc_source=/etc/bazelrc",
"--default_override=0:common=--stringoption=foo",
"--rc_source=/home/jrluser/.blazerc",
"--default_override=1:common=--numoption=99");
BlazeCommandDispatcher dispatch = new BlazeCommandDispatcher(runtime, reportNum, reportAll);
List<String> cmdLine = Lists.newArrayList("reportall");
cmdLine.addAll(blazercOpts);
dispatch.exec(cmdLine, "test", outErr);
String out = outErr.outAsLatin1();
assertWithMessage("Options should get accumulated over different rc files")
.that(out)
.isEqualTo("99 foo");
}
@Test
public void testOptionsCombinedWithOverride() throws Exception {
List<String> blazercOpts =
ImmutableList.of(
"--rc_source=/etc/bazelrc",
"--default_override=0:common=--stringoption=foo",
"--default_override=0:common=--numoption=42",
"--rc_source=/home/jrluser/.blazerc",
"--default_override=1:common=--numoption=99");
BlazeCommandDispatcher dispatch = new BlazeCommandDispatcher(runtime, reportNum, reportAll);
List<String> cmdLine = Lists.newArrayList("reportall");
cmdLine.addAll(blazercOpts);
dispatch.exec(cmdLine, "test", outErr);
String out = outErr.outAsLatin1();
assertWithMessage("The more specific rc-file should override").that(out).isEqualTo("99 foo");
}
@Test
public void testOptionsCombinedWithOverrideOtherName() throws Exception {
List<String> blazercOpts =
ImmutableList.of(
"--rc_source=/home/jrluser/.blazerc",
"--default_override=0:common=--stringoption=foo",
"--default_override=0:common=--numoption=42",
"--rc_source=/etc/bazelrc",
"--default_override=1:common=--numoption=99");
BlazeCommandDispatcher dispatch = new BlazeCommandDispatcher(runtime, reportNum, reportAll);
List<String> cmdLine = Lists.newArrayList("reportall");
cmdLine.addAll(blazercOpts);
dispatch.exec(cmdLine, "test", outErr);
String out = outErr.outAsLatin1();
assertWithMessage("The more specific rc-file should override irrespective of name")
.that(out)
.isEqualTo("99 foo");
}
@Test
public void testInheritedOptionsWithSpecificOverride() throws Exception {
ImmutableList<ImmutableList<String>> blazercOpts =
ImmutableList.of(
ImmutableList.of(
"--rc_source=/doesnt/matter/0/bazelrc",
"--default_override=0:common=--stringoption=common",
"--default_override=0:common=--numoption=42"),
ImmutableList.of(
"--rc_source=/doesnt/matter/1/bazelrc",
"--default_override=0:reportall=--stringoption=reportall"),
ImmutableList.of(
"--rc_source=/doesnt/matter/2/bazelrc",
"--default_override=0:reportallinherited=--stringoption=reportallinherited"));
for (List<ImmutableList<String>> e : Collections2.permutations(blazercOpts)) {
outErr.reset();
BlazeCommandDispatcher dispatch =
new BlazeCommandDispatcher(runtime, reportNum, reportAll, reportAllInherited);
List<String> cmdLine = Lists.newArrayList("reportallinherited");
List<String> orderedOpts = ImmutableList.copyOf(Iterables.concat(e));
cmdLine.addAll(orderedOpts);
dispatch.exec(cmdLine, "test", outErr);
String out = outErr.outAsLatin1();
assertWithMessage(String.format(
"The more specific option should override, irrespective of source file or order. %s",
orderedOpts))
.that(out)
.isEqualTo("42 reportallinherited");
}
}
/** Options class for testing, so that defaults package has some content. */
public static class MockFragmentOptions extends FragmentOptions {
public MockFragmentOptions() {}
@Option(
name = "fake_opt",
documentationCategory = OptionDocumentationCategory.UNCATEGORIZED,
effectTags = {OptionEffectTag.NO_OP},
defaultValue = "false"
)
public boolean fakeOpt;
@Override
public Map<String, Set<Label>> getDefaultsLabels() {
return ImmutableMap.<String, Set<Label>>of(
"mock_target", ImmutableSet.of(Label.parseAbsoluteUnchecked("//mock:target")));
}
}
}
|