1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
|
// Copyright 2016 The Bazel Authors. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package com.google.devtools.build.lib.rules.cpp;
import static com.google.common.truth.Truth.assertThat;
import com.google.common.collect.Iterables;
import com.google.devtools.build.lib.actions.Artifact;
import com.google.devtools.build.lib.analysis.ConfiguredTarget;
import com.google.devtools.build.lib.analysis.util.AnalysisMock;
import com.google.devtools.build.lib.analysis.util.BuildViewTestCase;
import com.google.devtools.build.lib.rules.cpp.CcToolchainFeatures.FeatureConfiguration;
import com.google.devtools.build.lib.rules.cpp.CcToolchainFeatures.Variables;
import com.google.devtools.build.lib.rules.cpp.Link.LinkTargetType;
import java.util.List;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
/** Tests that {@code CppLinkAction} is populated with the correct build variables. */
@RunWith(JUnit4.class)
public class LinkBuildVariablesTest extends BuildViewTestCase {
private CppLinkAction getCppLinkAction(ConfiguredTarget target, Link.LinkTargetType type) {
Artifact linkerOutput = null;
switch (type) {
case STATIC_LIBRARY:
case ALWAYS_LINK_STATIC_LIBRARY:
linkerOutput = getBinArtifact("lib" + target.getLabel().getName() + ".a", target);
break;
case PIC_STATIC_LIBRARY:
case ALWAYS_LINK_PIC_STATIC_LIBRARY:
linkerOutput = getBinArtifact("lib" + target.getLabel().getName() + "pic.a", target);
break;
case DYNAMIC_LIBRARY:
linkerOutput = getBinArtifact("lib" + target.getLabel().getName() + ".so", target);
break;
case EXECUTABLE:
linkerOutput = getExecutable(target);
break;
default:
throw new IllegalArgumentException(
String.format("Cannot get CppLinkAction for link type %s", type));
}
return (CppLinkAction) getGeneratingAction(linkerOutput);
}
private Variables getLinkBuildVariables(ConfiguredTarget target, Link.LinkTargetType type) {
return getCppLinkAction(target, type).getLinkCommandLine().getBuildVariables();
}
private List<String> getVariableValue(Variables variables, String variable) throws Exception {
FeatureConfiguration mockFeatureConfiguration =
CcToolchainFeaturesTest.buildFeatures(
"feature {",
" name: 'a'",
" flag_set {",
" action: 'foo'",
" flag_group {",
" flag: '%{" + variable + "}'",
" }",
" }",
"}")
.getFeatureConfiguration("a");
return mockFeatureConfiguration.getCommandLine("foo", variables);
}
@Test
public void testLinkstampBuildVariable() throws Exception {
scratch.file(
"x/BUILD",
"cc_binary(",
" name = 'bin',",
" srcs = ['a.cc'],",
" deps = [':lib'],",
")",
"cc_library(",
" name = 'lib',",
" srcs = ['b.cc'],",
" linkstamp = 'c.cc',",
")");
scratch.file("x/a.cc");
scratch.file("x/b.cc");
scratch.file("x/c.cc");
ConfiguredTarget target = getConfiguredTarget("//x:bin");
Variables variables = getLinkBuildVariables(target, Link.LinkTargetType.EXECUTABLE);
List<String> variableValue =
getVariableValue(variables, CppLinkActionBuilder.LINKSTAMP_PATHS_VARIABLE);
assertThat(Iterables.getOnlyElement(variableValue)).contains("c.o");
}
@Test
public void testForcePicBuildVariable() throws Exception {
useConfiguration("--force_pic");
scratch.file("x/BUILD", "cc_binary(", " name = 'bin',", " srcs = ['a.cc'],", ")");
scratch.file("x/a.cc");
ConfiguredTarget target = getConfiguredTarget("//x:bin");
Variables variables = getLinkBuildVariables(target, Link.LinkTargetType.EXECUTABLE);
List<String> variableValue =
getVariableValue(variables, CppLinkActionBuilder.FORCE_PIC_VARIABLE);
assertThat(variableValue).contains("");
}
@Test
public void testWholeArchiveBuildVariables() throws Exception {
scratch.file(
"x/BUILD",
"cc_binary(",
" name = 'bin.so',",
" srcs = ['a.cc'],",
" linkopts = ['-shared'],",
" linkstatic = 1",
")");
scratch.file("x/a.cc");
ConfiguredTarget target = getConfiguredTarget("//x:bin.so");
Variables variables = getLinkBuildVariables(target, Link.LinkTargetType.EXECUTABLE);
List<String> variableValue =
getVariableValue(variables, CppLinkActionBuilder.GLOBAL_WHOLE_ARCHIVE_VARIABLE);
assertThat(variableValue).contains("");
}
/**
* Tests that "--whole_archive" is not propagated twice through whole archive inputs and global
* whole archive.
*/
@Test
public void testGlobalWholeArchiveOrWholeArchiveBuildVariables() throws Exception {
scratch.file(
"x/BUILD",
"cc_binary(",
" name = 'bin',",
" srcs = ['a.cc', 'b.lo'],",
" linkopts = ['-shared'],",
" linkstatic = 1,",
")");
scratch.file("x/a.cc");
scratch.file("x/b.lo");
ConfiguredTarget target = getConfiguredTarget("//x:bin");
Variables variables = getLinkBuildVariables(target, Link.LinkTargetType.EXECUTABLE);
List<String> globalWholeArchiveVariableValue =
getVariableValue(variables, CppLinkActionBuilder.GLOBAL_WHOLE_ARCHIVE_VARIABLE);
List<String> wholeArchiveInputVariableValue =
getVariableValue(
variables, CppLinkActionBuilder.WHOLE_ARCHIVE_LINKER_INPUT_PARAMS_VARIABLE);
assertThat(globalWholeArchiveVariableValue).contains("");
assertThat(wholeArchiveInputVariableValue).isEmpty();
;
}
@Test
public void testInterfaceLibraryBuildingVariablesWhenGenerationPossible() throws Exception {
// Make sure the interface shared object generation is enabled in the configuration
// (which it is not by default for some windows toolchains)
AnalysisMock.get()
.ccSupport()
.setupCrosstool(mockToolsConfig, "supports_interface_shared_objects: true");
useConfiguration();
scratch.file("x/BUILD", "cc_library(", " name = 'foo',", " srcs = ['a.cc'],", ")");
scratch.file("x/a.cc");
ConfiguredTarget target = getConfiguredTarget("//x:foo");
Variables variables = getLinkBuildVariables(target, LinkTargetType.DYNAMIC_LIBRARY);
String interfaceLibraryBuilder =
Iterables.getOnlyElement(
getVariableValue(variables, CppLinkActionBuilder.INTERFACE_LIBRARY_BUILDER_VARIABLE));
String interfaceLibraryInput =
Iterables.getOnlyElement(
getVariableValue(variables, CppLinkActionBuilder.INTERFACE_LIBRARY_INPUT_VARIABLE));
String interfaceLibraryOutput =
Iterables.getOnlyElement(
getVariableValue(variables, CppLinkActionBuilder.INTERFACE_LIBRARY_OUTPUT_VARIABLE));
String generateInterfaceLibrary =
Iterables.getOnlyElement(
getVariableValue(variables, CppLinkActionBuilder.GENERATE_INTERFACE_LIBRARY_VARIABLE));
assertThat(generateInterfaceLibrary).isEqualTo("yes");
assertThat(interfaceLibraryInput).endsWith("libfoo.so");
assertThat(interfaceLibraryOutput).endsWith("libfoo.ifso");
assertThat(interfaceLibraryBuilder).endsWith("build_interface_so");
}
@Test
public void testInterfaceLibraryBuildingVariablesWhenGenerationNotAllowed() throws Exception {
// Make sure the interface shared object generation is enabled in the configuration
// (which it is not by default for some windows toolchains)
AnalysisMock.get()
.ccSupport()
.setupCrosstool(mockToolsConfig, "supports_interface_shared_objects: true");
useConfiguration();
scratch.file("x/BUILD", "cc_library(", " name = 'foo',", " srcs = ['a.cc'],", ")");
scratch.file("x/a.cc");
ConfiguredTarget target = getConfiguredTarget("//x:foo");
Variables variables = getLinkBuildVariables(target, LinkTargetType.STATIC_LIBRARY);
String interfaceLibraryBuilder =
Iterables.getOnlyElement(
getVariableValue(variables, CppLinkActionBuilder.INTERFACE_LIBRARY_BUILDER_VARIABLE));
String interfaceLibraryInput =
Iterables.getOnlyElement(
getVariableValue(variables, CppLinkActionBuilder.INTERFACE_LIBRARY_INPUT_VARIABLE));
String interfaceLibraryOutput =
Iterables.getOnlyElement(
getVariableValue(variables, CppLinkActionBuilder.INTERFACE_LIBRARY_OUTPUT_VARIABLE));
String generateInterfaceLibrary =
Iterables.getOnlyElement(
getVariableValue(variables, CppLinkActionBuilder.GENERATE_INTERFACE_LIBRARY_VARIABLE));
assertThat(generateInterfaceLibrary).isEqualTo("no");
assertThat(interfaceLibraryInput).endsWith("ignored");
assertThat(interfaceLibraryOutput).endsWith("ignored");
assertThat(interfaceLibraryBuilder).endsWith("ignored");
}
}
|
