1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
|
// Copyright 2017 The Bazel Authors. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package com.google.devtools.build.lib.rules.cpp;
import static com.google.common.truth.Truth.assertThat;
import com.google.common.base.Predicate;
import com.google.common.collect.ImmutableSet;
import com.google.devtools.build.lib.actions.Artifact;
import com.google.devtools.build.lib.actions.ArtifactRoot;
import com.google.devtools.build.lib.analysis.util.BuildViewTestCase;
import com.google.devtools.build.lib.rules.cpp.CcToolchainFeatures.FeatureConfiguration;
import com.google.devtools.build.lib.rules.cpp.CompileCommandLine.Builder;
import com.google.devtools.build.lib.rules.cpp.CppCompileAction.DotdFile;
import com.google.devtools.build.lib.vfs.Path;
import java.io.IOException;
import java.util.List;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
/**
* Tests for {@link CompileCommandLine}, for example testing the ordering of individual command
* line flags, or that command line is emitted differently subject to the presence of certain
* build variables. Also used to test migration logic (removing hardcoded flags and expressing
* them using feature configuration.
*/
@RunWith(JUnit4.class)
public class CompileCommandLineTest extends BuildViewTestCase {
private Artifact scratchArtifact(String s) {
Path execRoot = outputBase.getRelative("exec");
Path outputRoot = execRoot.getRelative("root");
ArtifactRoot root = ArtifactRoot.asDerivedRoot(execRoot, outputRoot);
try {
return new Artifact(scratch.overwriteFile(outputRoot.getRelative(s).toString()), root);
} catch (IOException e) {
throw new RuntimeException(e);
}
}
private static FeatureConfiguration getMockFeatureConfiguration(String... crosstool)
throws Exception {
return CcToolchainFeaturesTest.buildFeatures(crosstool)
.getFeatureConfiguration(
ImmutableSet.of(
CppCompileAction.ASSEMBLE,
CppCompileAction.PREPROCESS_ASSEMBLE,
CppCompileAction.C_COMPILE,
CppCompileAction.CPP_COMPILE,
CppCompileAction.CPP_HEADER_PARSING,
CppCompileAction.CPP_HEADER_PREPROCESSING,
CppCompileAction.CPP_MODULE_CODEGEN,
CppCompileAction.CPP_MODULE_COMPILE));
}
@Test
public void testFeatureConfigurationCommandLineIsUsed() throws Exception {
CompileCommandLine compileCommandLine =
makeCompileCommandLineBuilder()
.setFeatureConfiguration(
getMockFeatureConfiguration(
"",
"action_config {",
" config_name: 'c++-compile'",
" action_name: 'c++-compile'",
" implies: 'some_foo_feature'",
" tool {",
" tool_path: 'foo/bar/DUMMY_COMPILER'",
" }",
"}",
"feature {",
" name: 'some_foo_feature'",
" flag_set {",
" action: 'c++-compile'",
" flag_group {",
" flag: '-some_foo_flag'",
" }",
" }",
"}"))
.build();
assertThat(compileCommandLine.getArgv(scratchArtifact("a/FakeOutput").getExecPath(), null))
.contains("-some_foo_flag");
}
@Test
public void testUnfilteredFlagsAreNotFiltered() throws Exception {
List<String> actualCommandLine =
getCompileCommandLineWithCoptsFilter(CppRuleClasses.UNFILTERED_COMPILE_FLAGS_FEATURE_NAME);
assertThat(actualCommandLine).contains("-i_am_a_flag");
}
@Test
public void testNonUnfilteredFlagsAreFiltered() throws Exception {
List<String> actualCommandLine = getCompileCommandLineWithCoptsFilter("filtered_flags");
assertThat(actualCommandLine).doesNotContain("-i_am_a_flag");
}
private List<String> getCompileCommandLineWithCoptsFilter(String featureName) throws Exception {
CompileCommandLine compileCommandLine =
makeCompileCommandLineBuilder()
.setFeatureConfiguration(
getMockFeatureConfiguration(
"",
"action_config {",
" config_name: 'c++-compile'",
" action_name: 'c++-compile'",
" implies: '" + featureName + "'",
" tool {",
" tool_path: 'foo/bar/DUMMY_COMPILER'",
" }",
"}",
"feature {",
" name: '" + featureName + "'",
" flag_set {",
" action: 'c++-compile'",
" flag_group {",
" flag: '-i_am_a_flag'",
" }",
" }",
"}"))
.setCoptsFilter(flag -> !flag.contains("i_am_a_flag"))
.build();
return compileCommandLine.getArgv(scratchArtifact("a/FakeOutput").getExecPath(), null);
}
private Builder makeCompileCommandLineBuilder() throws Exception {
return CompileCommandLine.builder(
scratchArtifact("a/FakeInput"),
scratchArtifact("a/FakeOutput"),
new Predicate<String>() {
@Override
public boolean apply(String s) {
return true;
}
},
"c++-compile",
getTargetConfiguration().getFragment(CppConfiguration.class),
new DotdFile(scratchArtifact("a/dotD")));
}
}
|
