1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
|
// Copyright 2015 The Bazel Authors. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package com.google.devtools.build.lib.pkgcache;
import com.google.common.collect.ImmutableSet;
import com.google.common.truth.Truth;
import com.google.devtools.build.lib.clock.BlazeClock;
import com.google.devtools.build.lib.events.EventKind;
import com.google.devtools.build.lib.vfs.Dirent;
import com.google.devtools.build.lib.vfs.FileStatus;
import com.google.devtools.build.lib.vfs.FileSystem;
import com.google.devtools.build.lib.vfs.FileSystemUtils;
import com.google.devtools.build.lib.vfs.Path;
import com.google.devtools.build.lib.vfs.PathFragment;
import com.google.devtools.build.lib.vfs.inmemoryfs.InMemoryContentInfo;
import com.google.devtools.build.lib.vfs.inmemoryfs.InMemoryFileSystem;
import java.io.IOException;
import java.util.Collection;
import java.util.concurrent.atomic.AtomicBoolean;
import javax.annotation.Nullable;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
/** TargetPatternEvaluator tests that require a custom filesystem. */
@RunWith(JUnit4.class)
public class TargetPatternEvaluatorIOTest extends AbstractTargetPatternEvaluatorTest {
private static final String FS_ROOT = "/fsg";
private static class Transformer {
@SuppressWarnings("unused")
@Nullable
public FileStatus stat(FileStatus stat, Path path, boolean followSymlinks) throws IOException {
return stat;
}
@SuppressWarnings("unused")
@Nullable
public Collection<Dirent> readdir(Collection<Dirent> readdir, Path path, boolean followSymlinks)
throws IOException {
return readdir;
}
}
private Transformer transformer = new Transformer();
@Override
protected FileSystem createFileSystem() {
return new InMemoryFileSystem(BlazeClock.instance(), PathFragment.create(FS_ROOT)) {
@Override
public FileStatus stat(Path path, boolean followSymlinks) throws IOException {
FileStatus defaultResult = super.stat(path, followSymlinks);
return transformer.stat(defaultResult, path, followSymlinks);
}
@Override
protected Collection<Dirent> readdir(Path path, boolean followSymlinks) throws IOException {
Collection<Dirent> defaultResult = super.readdir(path, followSymlinks);
return transformer.readdir(defaultResult, path, followSymlinks);
}
};
}
/**
* Test that a child with an inconsistent stat (first a directory, then not) does not prevent
* evaluation of the remaining packages beneath a directory and the return of a partial result.
*/
@Test
public void testBadStatKeepGoing() throws Exception {
reporter.removeHandler(failFastHandler);
// Given a package, "parent",
Path parent = scratch.file("parent/BUILD", "sh_library(name = 'parent')").getParentDirectory();
// And a child, "badstat",
FileSystemUtils.createDirectoryAndParents(parent.getRelative("badstat"));
// Such that badstat first reports that it is a directory, and then reports that it isn't,
this.transformer = createInconsistentFileStateTransformer("parent/badstat");
// When we find all the targets beneath parent in keep_going mode, we get the valid target
// parent:parent, even though processing badstat threw an InconsistentFilesystemException,
Truth.assertThat(parseListKeepGoing("//parent/...").getFirst())
.containsExactlyElementsIn(labels("//parent:parent"));
// And the TargetPatternEvaluator reported the expected ERROR event to the handler.
assertContainsEvent(
"Failed to get information about path, for parent/badstat, skipping: Inconsistent "
+ "filesystem operations",
ImmutableSet.of(EventKind.ERROR));
}
/**
* Test that a package subdirectory that throws an IOException when it is listed via readdir
* does not prevent evaluation of the remaining packages beneath a directory and the return of
* a partial result.
*/
@Test
public void testBadReaddirKeepGoing() throws Exception {
reporter.removeHandler(failFastHandler);
// Given a package, "parent",
Path parent = scratch.file("parent/BUILD", "sh_library(name = 'parent')").getParentDirectory();
// And a child, "badstat",
FileSystemUtils.createDirectoryAndParents(parent.getRelative("badstat"));
// Such that badstat reports that it is a directory, but throws an error when its Dirents are
// collected,
this.transformer = createBadDirectoryListingTransformer("parent/badstat");
// When we find all the targets beneath parent in keep_going mode, we get the valid target
// parent:parent, even though processing badstat threw an IOException,
Truth.assertThat(parseListKeepGoing("//parent/...").getFirst())
.containsExactlyElementsIn(labels("//parent:parent"));
// And the TargetPatternEvaluator reported the expected ERROR event to the handler.
assertContainsEvent(
"Failed to list directory contents, for parent/badstat, skipping: Path ended in "
+ "parent/badstat, so readdir failed",
ImmutableSet.of(EventKind.ERROR));
}
private Transformer createInconsistentFileStateTransformer(final String badPathSuffix) {
final AtomicBoolean isDirectory = new AtomicBoolean(true);
return new Transformer() {
@Nullable
@Override
public FileStatus stat(final FileStatus stat, Path path, boolean followSymlinks)
throws IOException {
if (path.getPathString().endsWith(badPathSuffix)) {
return new InMemoryContentInfo(BlazeClock.instance()) {
@Override
public boolean isDirectory() {
// Trigger inconsistent filesystem exception.
return isDirectory.getAndSet(false);
}
@Override
public boolean isFile() {
return stat.isFile();
}
@Override
public boolean isSpecialFile() {
return stat.isSpecialFile();
}
@Override
public boolean isSymbolicLink() {
return stat.isSymbolicLink();
}
@Override
public long getSize() throws IOException {
return stat.getSize();
}
@Override
public synchronized long getLastModifiedTime() {
try {
return stat.getLastModifiedTime();
} catch (IOException e) {
throw new IllegalStateException(e);
}
}
@Override
public synchronized long getLastChangeTime() {
try {
return stat.getLastChangeTime();
} catch (IOException e) {
throw new IllegalStateException(e);
}
}
@Override
public long getNodeId() {
try {
return stat.getNodeId();
} catch (IOException e) {
throw new IllegalStateException(e);
}
}
};
}
return stat;
}
};
}
private Transformer createBadDirectoryListingTransformer(final String badPathSuffix) {
return new Transformer() {
@Nullable
@Override
public Collection<Dirent> readdir(Collection<Dirent> readdir, Path path,
boolean followSymlinks) throws IOException {
if (path.getPathString().endsWith(badPathSuffix)) {
throw new IOException("Path ended in " + badPathSuffix + ", so readdir failed.");
}
return readdir;
}
};
}
}
|
