1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
|
// Copyright 2015 The Bazel Authors. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package com.google.devtools.build.lib.packages;
import static com.google.common.truth.Truth.assertThat;
import com.google.common.testing.EqualsTester;
import com.google.devtools.build.lib.cmdline.PackageIdentifier;
import com.google.devtools.build.lib.packages.util.PackageLoadingTestCase;
import com.google.devtools.build.lib.vfs.Path;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
@RunWith(JUnit4.class)
public class OutputFileTest extends PackageLoadingTestCase {
private Package pkg;
private Rule rule;
@Before
public final void createRule() throws Exception {
Path buildfile =
scratch.file(
"pkg/BUILD",
"genrule(name='foo', ",
" srcs=[], ",
" cmd='', ",
" outs=['x', 'subdir/y'])");
this.pkg =
packageFactory.createPackageForTesting(
PackageIdentifier.createInMainRepo("pkg"), buildfile, getPackageManager(), reporter);
assertNoEvents();
this.rule = (Rule) pkg.getTarget("foo");
}
private void checkTargetRetainsGeneratingRule(OutputFile output) throws Exception {
assertThat(output.getGeneratingRule()).isSameAs(rule);
}
private void checkName(OutputFile output, String expectedName) throws Exception {
assertThat(output.getName()).isEqualTo(expectedName);
}
private void checkLabel(OutputFile output, String expectedLabelString) throws Exception {
assertThat(output.getLabel().toString()).isEqualTo(expectedLabelString);
}
@Test
public void testGetAssociatedRule() throws Exception {
assertThat(pkg.getTarget("x").getAssociatedRule()).isSameAs(rule);
}
@Test
public void testOutputFileInPackageDir() throws Exception {
OutputFile outputFileX = (OutputFile) pkg.getTarget("x");
checkTargetRetainsGeneratingRule(outputFileX);
checkName(outputFileX, "x");
checkLabel(outputFileX, "//pkg:x");
assertThat(outputFileX.getTargetKind()).isEqualTo("generated file");
}
@Test
public void testOutputFileInSubdirectory() throws Exception {
OutputFile outputFileY = (OutputFile) pkg.getTarget("subdir/y");
checkTargetRetainsGeneratingRule(outputFileY);
checkName(outputFileY, "subdir/y");
checkLabel(outputFileY, "//pkg:subdir/y");
}
@Test
public void testEquivalenceRelation() throws Exception {
OutputFile outputFileX1 = (OutputFile) pkg.getTarget("x");
OutputFile outputFileX2 = (OutputFile) pkg.getTarget("x");
OutputFile outputFileY1 = (OutputFile) pkg.getTarget("subdir/y");
OutputFile outputFileY2 = (OutputFile) pkg.getTarget("subdir/y");
assertThat(outputFileX2).isSameAs(outputFileX1);
assertThat(outputFileY2).isSameAs(outputFileY1);
new EqualsTester()
.addEqualityGroup(outputFileX1, outputFileX2)
.addEqualityGroup(outputFileY1, outputFileY2)
.testEquals();
}
@Test
public void testDuplicateOutputFilesInDifferentRules() throws Exception {
Path buildfile =
scratch.file(
"two_outs/BUILD",
"genrule(name='a',",
" cmd='ls >$(location out)',",
" outs=['out'])",
"",
"genrule(name='b',",
" cmd='ls >$(location out)',",
" outs=['out'])");
reporter.removeHandler(failFastHandler);
packageFactory.createPackageForTesting(
PackageIdentifier.createInMainRepo("two_outs"),
buildfile,
getPackageManager(),
reporter);
assertContainsEvent(
"generated file 'out' in rule 'b' conflicts with "
+ "existing generated file from rule 'a'");
}
@Test
public void testOutputFileNameConflictsWithExistingRule() throws Exception {
Path buildfile =
scratch.file(
"out_is_rule/BUILD",
"genrule(name='a',",
" cmd='ls >$(location out)',",
" outs=['out'])",
"",
"genrule(name='b',",
" cmd='ls >$(location out)',",
" outs=['a'])");
reporter.removeHandler(failFastHandler);
packageFactory.createPackageForTesting(
PackageIdentifier.createInMainRepo("out_is_rule"),
buildfile,
getPackageManager(),
reporter);
assertContainsEvent("generated file 'a' in rule 'b' conflicts with existing genrule rule");
}
@Test
public void testDuplicateOutputFilesInSameRule() throws Exception {
Path buildfile =
scratch.file(
"two_outs/BUILD",
"genrule(name='a',",
" cmd='ls >$(location out)',",
" outs=['out', 'out'])");
reporter.removeHandler(failFastHandler);
packageFactory.createPackageForTesting(
PackageIdentifier.createInMainRepo("two_outs"),
buildfile,
getPackageManager(),
reporter);
assertContainsEvent(
"generated file 'out' in rule 'a' conflicts with "
+ "existing generated file from rule 'a'");
}
@Test
public void testOutputFileWithIllegalName() throws Exception {
Path buildfile =
scratch.file(
"bad_out_name/BUILD",
"genrule(name='a',",
" cmd='ls',",
" outs=['!@#:'])");
reporter.removeHandler(failFastHandler);
packageFactory.createPackageForTesting(
PackageIdentifier.createInMainRepo("bad_out_name"),
buildfile,
getPackageManager(),
reporter);
assertContainsEvent("illegal output file name '!@#:' in rule //bad_out_name:a");
}
@Test
public void testOutputFileWithCrossPackageLabel() throws Exception {
Path buildfile =
scratch.file(
"cross_package_out/BUILD",
"genrule(name='a',",
" cmd='ls',",
" outs=['//foo:bar'])");
reporter.removeHandler(failFastHandler);
packageFactory.createPackageForTesting(
PackageIdentifier.createInMainRepo("cross_package_out"),
buildfile,
getPackageManager(),
reporter);
assertContainsEvent("label '//foo:bar' is not in the current package");
}
@Test
public void testOutputFileNamedBUILD() throws Exception {
Path buildfile =
scratch.file(
"output_called_build/BUILD",
"genrule(name='a',",
" cmd='ls',",
" outs=['BUILD'])");
reporter.removeHandler(failFastHandler);
packageFactory.createPackageForTesting(
PackageIdentifier.createInMainRepo("output_called_build"), buildfile,
getPackageManager(), reporter);
assertContainsEvent("generated file 'BUILD' in rule 'a' conflicts with existing source file");
}
}
|
