1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
|
// Copyright 2016 The Bazel Authors. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package com.google.devtools.build.lib.packages;
import static com.google.common.truth.Truth.assertThat;
import static com.google.devtools.build.lib.packages.Attribute.attr;
import static com.google.devtools.build.lib.syntax.Type.STRING;
import static org.junit.Assert.fail;
import com.google.devtools.build.lib.events.Location;
import com.google.devtools.build.lib.packages.Attribute.ComputedDefault;
import com.google.devtools.build.lib.packages.Attribute.LateBoundDefault;
import com.google.devtools.build.lib.syntax.EvalException;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
/**
* Test class for {@link AttributeValueSource}.
*/
@RunWith(JUnit4.class)
public class AttributeValueSourceTest {
@Test
public void testValidateSkylarkName() throws Exception {
// Success means "no exception is being thrown".
AttributeValueSource.COMPUTED_DEFAULT.validateSkylarkName("_name", Location.BUILTIN);
AttributeValueSource.LATE_BOUND.validateSkylarkName("_name", Location.BUILTIN);
AttributeValueSource.DIRECT.validateSkylarkName("_name", Location.BUILTIN);
AttributeValueSource.DIRECT.validateSkylarkName("name", Location.BUILTIN);
}
@Test
public void testValidateSkylarkName_EmptyName() throws Exception {
for (AttributeValueSource source : AttributeValueSource.values()) {
assertNameIsNotValid(source, "", "Attribute name must not be empty.");
}
}
@Test
public void testValidateSkylarkName_MissingPrefix() throws Exception {
String msg =
"When an attribute value is a function, the attribute must be private "
+ "(i.e. start with '_'). Found 'my_name'";
assertNameIsNotValid(AttributeValueSource.COMPUTED_DEFAULT, "my_name", msg);
assertNameIsNotValid(AttributeValueSource.LATE_BOUND, "my_name", msg);
}
private void assertNameIsNotValid(
AttributeValueSource source, String name, String expectedExceptionMessage) throws Exception {
try {
source.validateSkylarkName(name, Location.BUILTIN);
fail("Expected an exception because of an invalid name.");
} catch (EvalException ex) {
assertThat(ex).hasMessage(expectedExceptionMessage);
}
}
@Test
public void testConvertToNativeName() throws Exception {
assertConvertsToCorrectNativeName(AttributeValueSource.COMPUTED_DEFAULT, "_name", "$name");
assertConvertsToCorrectNativeName(AttributeValueSource.LATE_BOUND, "_name", ":name");
assertConvertsToCorrectNativeName(AttributeValueSource.DIRECT, "_name", "$name");
assertConvertsToCorrectNativeName(AttributeValueSource.DIRECT, "name", "name");
}
private void assertConvertsToCorrectNativeName(
AttributeValueSource source, String skylarkName, String expectedNativeName) throws Exception {
assertThat(source.convertToNativeName(skylarkName, Location.BUILTIN))
.isEqualTo(expectedNativeName);
}
@Test
public void testConvertToNativeName_InvalidName() throws Exception {
assertTranslationFails(AttributeValueSource.COMPUTED_DEFAULT, "name");
assertTranslationFails(AttributeValueSource.LATE_BOUND, "name");
}
private void assertTranslationFails(AttributeValueSource source, String invalidName)
throws Exception {
try {
source.convertToNativeName(invalidName, Location.BUILTIN);
fail("Expected an exception because of an invalid name.");
} catch (EvalException ex) {
assertThat(ex)
.hasMessage(
String.format("When an attribute value is a function, the attribute must be private "
+ "(i.e. start with '_'). Found '%s'", invalidName));
}
}
@Test
public void testBuilderGetValueSource() throws Exception {
assertBuilderHasCorrectSource(COMPUTED_DEFAULT_BUILDER, AttributeValueSource.COMPUTED_DEFAULT);
assertBuilderHasCorrectSource(LATE_BOUND_BUILDER, AttributeValueSource.LATE_BOUND);
assertBuilderHasCorrectSource(DIRECT_BUILDER, AttributeValueSource.DIRECT);
}
private void assertBuilderHasCorrectSource(
Attribute.Builder<?> builder, AttributeValueSource expectedSource) throws Exception {
assertThat(builder.getValueSource()).isEqualTo(expectedSource);
}
private static final Attribute.Builder<?> COMPUTED_DEFAULT_BUILDER =
attr("x", STRING)
.value(
new ComputedDefault() {
@Override
public Object getDefault(AttributeMap rule) {
return null;
}
});
private static final Attribute.Builder<?> LATE_BOUND_BUILDER =
attr(":x", STRING).value(LateBoundDefault.alwaysNull());
private static final Attribute.Builder<?> DIRECT_BUILDER = attr("x", STRING).value("value");
}
|
