1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
|
// Copyright 2015 The Bazel Authors. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package com.google.devtools.build.lib.cmdline;
import static com.google.common.truth.Truth.assertThat;
import static com.google.common.truth.Truth.assertWithMessage;
import com.google.devtools.build.lib.cmdline.LabelValidator.PackageAndTarget;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
/**
* Tests for {@link LabelValidator}.
*/
@RunWith(JUnit4.class)
public class LabelValidatorTest {
private PackageAndTarget newFooTarget() {
return new PackageAndTarget("foo", "foo");
}
private PackageAndTarget newBarTarget() {
return new PackageAndTarget("bar", "bar");
}
@Test
public void testValidatePackageName() throws Exception {
// OK:
assertThat(LabelValidator.validatePackageName("foo")).isNull();
assertThat(LabelValidator.validatePackageName("Foo")).isNull();
assertThat(LabelValidator.validatePackageName("FOO")).isNull();
assertThat(LabelValidator.validatePackageName("foO")).isNull();
assertThat(LabelValidator.validatePackageName("foo-bar")).isNull();
assertThat(LabelValidator.validatePackageName("Foo-Bar")).isNull();
assertThat(LabelValidator.validatePackageName("FOO-BAR")).isNull();
assertThat(LabelValidator.validatePackageName("bar.baz")).isNull();
assertThat(LabelValidator.validatePackageName("a/..b")).isNull();
assertThat(LabelValidator.validatePackageName("a/.b")).isNull();
assertThat(LabelValidator.validatePackageName("a/b.")).isNull();
assertThat(LabelValidator.validatePackageName("a/b..")).isNull();
assertThat(LabelValidator.validatePackageName("a$( )/b..")).isNull();
// These are in ascii code order.
assertThat(LabelValidator.validatePackageName("foo!bar")).isNull();
assertThat(LabelValidator.validatePackageName("foo\"bar")).isNull();
assertThat(LabelValidator.validatePackageName("foo#bar")).isNull();
assertThat(LabelValidator.validatePackageName("foo$bar")).isNull();
assertThat(LabelValidator.validatePackageName("foo%bar")).isNull();
assertThat(LabelValidator.validatePackageName("foo&bar")).isNull();
assertThat(LabelValidator.validatePackageName("foo'bar")).isNull();
assertThat(LabelValidator.validatePackageName("foo(bar")).isNull();
assertThat(LabelValidator.validatePackageName("foo)bar")).isNull();
assertThat(LabelValidator.validatePackageName("foo*bar")).isNull();
assertThat(LabelValidator.validatePackageName("foo+bar")).isNull();
assertThat(LabelValidator.validatePackageName("foo,bar")).isNull();
assertThat(LabelValidator.validatePackageName("foo-bar")).isNull();
assertThat(LabelValidator.validatePackageName("foo.bar")).isNull();
assertThat(LabelValidator.validatePackageName("foo+bar")).isNull();
assertThat(LabelValidator.validatePackageName("foo;bar")).isNull();
assertThat(LabelValidator.validatePackageName("foo<bar")).isNull();
assertThat(LabelValidator.validatePackageName("foo=bar")).isNull();
assertThat(LabelValidator.validatePackageName("foo>bar")).isNull();
assertThat(LabelValidator.validatePackageName("foo?bar")).isNull();
assertThat(LabelValidator.validatePackageName("foo@bar")).isNull();
assertThat(LabelValidator.validatePackageName("foo[bar")).isNull();
assertThat(LabelValidator.validatePackageName("foo]bar")).isNull();
assertThat(LabelValidator.validatePackageName("foo^bar")).isNull();
assertThat(LabelValidator.validatePackageName("foo_bar")).isNull();
assertThat(LabelValidator.validatePackageName("foo`bar")).isNull();
assertThat(LabelValidator.validatePackageName("foo{bar")).isNull();
assertThat(LabelValidator.validatePackageName("foo|bar")).isNull();
assertThat(LabelValidator.validatePackageName("foo}bar")).isNull();
assertThat(LabelValidator.validatePackageName("foo~bar")).isNull();
// Bad:
assertThat(LabelValidator.validatePackageName("/foo"))
.isEqualTo("package names may not start with '/'");
assertThat(LabelValidator.validatePackageName("foo/"))
.isEqualTo("package names may not end with '/'");
assertThat(LabelValidator.validatePackageName("foo:bar"))
.isEqualTo(LabelValidator.PACKAGE_NAME_ERROR);
assertThat(LabelValidator.validatePackageName("bar/../baz"))
.isEqualTo(LabelValidator.PACKAGE_NAME_DOT_ERROR);
assertThat(LabelValidator.validatePackageName("bar/.."))
.isEqualTo(LabelValidator.PACKAGE_NAME_DOT_ERROR);
assertThat(LabelValidator.validatePackageName("../bar"))
.isEqualTo(LabelValidator.PACKAGE_NAME_DOT_ERROR);
assertThat(LabelValidator.validatePackageName("bar/..."))
.isEqualTo(LabelValidator.PACKAGE_NAME_DOT_ERROR);
assertThat(LabelValidator.validatePackageName("bar/./baz"))
.isEqualTo(LabelValidator.PACKAGE_NAME_DOT_ERROR);
assertThat(LabelValidator.validatePackageName("bar/."))
.isEqualTo(LabelValidator.PACKAGE_NAME_DOT_ERROR);
assertThat(LabelValidator.validatePackageName("./bar"))
.isEqualTo(LabelValidator.PACKAGE_NAME_DOT_ERROR);
}
@Test
public void testValidateTargetName() throws Exception {
assertThat(LabelValidator.validateTargetName("foo")).isNull();
assertThat(LabelValidator.validateTargetName("foo!bar")).isNull();
assertThat(LabelValidator.validateTargetName("foo\"bar")).isNull();
assertThat(LabelValidator.validateTargetName("foo#bar")).isNull();
assertThat(LabelValidator.validateTargetName("foo$bar")).isNull();
assertThat(LabelValidator.validateTargetName("foo%bar")).isNull();
assertThat(LabelValidator.validateTargetName("foo&bar")).isNull();
assertThat(LabelValidator.validateTargetName("foo'bar")).isNull();
assertThat(LabelValidator.validateTargetName("foo(bar")).isNull();
assertThat(LabelValidator.validateTargetName("foo)bar")).isNull();
assertThat(LabelValidator.validateTargetName("foo*bar")).isNull();
assertThat(LabelValidator.validateTargetName("foo+bar")).isNull();
assertThat(LabelValidator.validateTargetName("foo,bar")).isNull();
assertThat(LabelValidator.validateTargetName("foo-bar")).isNull();
assertThat(LabelValidator.validateTargetName("foo.bar")).isNull();
assertThat(LabelValidator.validateTargetName("foo+bar")).isNull();
assertThat(LabelValidator.validateTargetName("foo;bar")).isNull();
assertThat(LabelValidator.validateTargetName("foo<bar")).isNull();
assertThat(LabelValidator.validateTargetName("foo=bar")).isNull();
assertThat(LabelValidator.validateTargetName("foo>bar")).isNull();
assertThat(LabelValidator.validateTargetName("foo?bar")).isNull();
assertThat(LabelValidator.validateTargetName("foo[bar")).isNull();
assertThat(LabelValidator.validateTargetName("foo]bar")).isNull();
assertThat(LabelValidator.validateTargetName("foo^bar")).isNull();
assertThat(LabelValidator.validateTargetName("foo_bar")).isNull();
assertThat(LabelValidator.validateTargetName("foo`bar")).isNull();
assertThat(LabelValidator.validateTargetName("foo{bar")).isNull();
assertThat(LabelValidator.validateTargetName("foo|bar")).isNull();
assertThat(LabelValidator.validateTargetName("foo}bar")).isNull();
assertThat(LabelValidator.validateTargetName("foo~bar")).isNull();
assertThat(LabelValidator.validateTargetName("foo/bar")).isNull();
assertThat(LabelValidator.validateTargetName("foo@bar")).isNull();
assertThat(LabelValidator.validateTargetName("foo/"))
.isEqualTo("target names may not end with '/'");
assertThat(LabelValidator.validateTargetName("bar:baz"))
.isEqualTo("target names may not contain ':'");
assertThat(LabelValidator.validateTargetName("bar:"))
.isEqualTo("target names may not contain ':'");
}
@Test
public void testValidateAbsoluteLabel() throws Exception {
PackageAndTarget emptyPackage = new PackageAndTarget("", "bar");
assertThat(LabelValidator.validateAbsoluteLabel("//:bar")).isEqualTo(emptyPackage);
assertThat(LabelValidator.validateAbsoluteLabel("@repo//:bar")).isEqualTo(emptyPackage);
assertThat(LabelValidator.validateAbsoluteLabel("@repo//foo:bar"))
.isEqualTo(new PackageAndTarget("foo", "bar"));
assertThat(LabelValidator.validateAbsoluteLabel("@//foo:bar"))
.isEqualTo(new PackageAndTarget("foo", "bar"));
emptyPackage = new PackageAndTarget("", "b$() ar");
assertThat(LabelValidator.validateAbsoluteLabel("//:b$() ar")).isEqualTo(emptyPackage);
assertThat(LabelValidator.validateAbsoluteLabel("@repo//:b$() ar")).isEqualTo(emptyPackage);
assertThat(LabelValidator.validateAbsoluteLabel("@repo//f$( )oo:b$() ar"))
.isEqualTo(new PackageAndTarget("f$( )oo", "b$() ar"));
assertThat(LabelValidator.validateAbsoluteLabel("@//f$( )oo:b$() ar"))
.isEqualTo(new PackageAndTarget("f$( )oo", "b$() ar"));
assertThat(LabelValidator.validateAbsoluteLabel("//f@oo"))
.isEqualTo(new PackageAndTarget("f@oo", "f@oo"));
assertThat(LabelValidator.validateAbsoluteLabel("//@foo"))
.isEqualTo(new PackageAndTarget("@foo", "@foo"));
assertThat(LabelValidator.validateAbsoluteLabel("//@foo:@bar"))
.isEqualTo(new PackageAndTarget("@foo", "@bar"));
}
@Test
public void testPackageAndTargetHashCode_distinctButEqualObjects() {
PackageAndTarget fooTarget1 = newFooTarget();
PackageAndTarget fooTarget2 = newFooTarget();
assertThat(fooTarget2).isNotSameAs(fooTarget1);
assertWithMessage("Should have same hash code")
.that(fooTarget1.hashCode())
.isEqualTo(fooTarget2.hashCode());
}
@Test
public void testPackageAndTargetEquals_distinctButEqualObjects() {
PackageAndTarget fooTarget1 = newFooTarget();
PackageAndTarget fooTarget2 = newFooTarget();
assertThat(fooTarget2).isNotSameAs(fooTarget1);
assertWithMessage("Should be equal").that(fooTarget1).isEqualTo(fooTarget2);
}
@Test
public void testPackageAndTargetEquals_unequalObjects() {
assertWithMessage("should be unequal").that(newFooTarget().equals(newBarTarget())).isFalse();
}
@Test
public void testPackageAndTargetToString() {
assertThat(newFooTarget().toString()).isEqualTo("//foo:foo");
assertThat(newBarTarget().toString()).isEqualTo("//bar:bar");
}
@Test
public void testSlashlessLabel_infersTargetNameFromRepoName() throws Exception {
assertThat(LabelValidator.parseAbsoluteLabel("@foo").toString()).isEqualTo("//:foo");
}
}
|
