1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
|
// Copyright 2015 The Bazel Authors. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package com.google.devtools.build.lib.cmdline;
import static com.google.common.truth.Truth.assertThat;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotSame;
import static org.junit.Assert.assertNull;
import static org.junit.Assert.fail;
import com.google.devtools.build.lib.cmdline.LabelValidator.PackageAndTarget;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
/**
* Tests for {@link LabelValidator}.
*/
@RunWith(JUnit4.class)
public class LabelValidatorTest {
private static final String BAD_PACKAGE_CHARS =
"package names may contain only A-Z, a-z, 0-9, '/', '-' and '_'";
private PackageAndTarget newFooTarget() {
return new PackageAndTarget("foo", "foo");
}
private PackageAndTarget newBarTarget() {
return new PackageAndTarget("bar", "bar");
}
@Test
public void testValidatePackageName() throws Exception {
// OK:
assertNull(LabelValidator.validatePackageName("foo"));
assertNull(LabelValidator.validatePackageName("Foo"));
assertNull(LabelValidator.validatePackageName("FOO"));
assertNull(LabelValidator.validatePackageName("foO"));
assertNull(LabelValidator.validatePackageName("foo-bar"));
assertNull(LabelValidator.validatePackageName("Foo-Bar"));
assertNull(LabelValidator.validatePackageName("FOO-BAR"));
// Bad:
assertEquals("package names may not start with '/'",
LabelValidator.validatePackageName("/foo"));
assertEquals("package names may not end with '/'",
LabelValidator.validatePackageName("foo/"));
assertEquals(BAD_PACKAGE_CHARS,
LabelValidator.validatePackageName("bar baz"));
assertEquals(BAD_PACKAGE_CHARS,
LabelValidator.validatePackageName("foo:bar"));
assertEquals(BAD_PACKAGE_CHARS,
LabelValidator.validatePackageName("baz@12345"));
assertEquals(BAD_PACKAGE_CHARS,
LabelValidator.validatePackageName("baz(foo)"));
assertEquals(BAD_PACKAGE_CHARS,
LabelValidator.validatePackageName("bazfoo)"));
}
@Test
public void testValidateTargetName() throws Exception {
assertNull(LabelValidator.validateTargetName("foo"));
assertNull(LabelValidator.validateTargetName("foo+bar"));
assertNull(LabelValidator.validateTargetName("foo_bar"));
assertNull(LabelValidator.validateTargetName("foo=bar"));
assertNull(LabelValidator.validateTargetName("foo-bar"));
assertNull(LabelValidator.validateTargetName("foo.bar"));
assertNull(LabelValidator.validateTargetName("foo@bar"));
assertNull(LabelValidator.validateTargetName("foo~bar"));
assertEquals("target names may not end with '/'",
LabelValidator.validateTargetName("foo/"));
assertEquals("target names may not contain ' '",
LabelValidator.validateTargetName("bar baz"));
assertEquals("target names may not contain ':'",
LabelValidator.validateTargetName("bar:baz"));
assertEquals("target names may not contain ':'",
LabelValidator.validateTargetName("bar:"));
assertEquals("target names may not contain '&'",
LabelValidator.validateTargetName("bar&"));
assertEquals("target names may not contain '$'",
LabelValidator.validateTargetName("baz$a"));
assertEquals("target names may not contain '('",
LabelValidator.validateTargetName("baz(foo)"));
assertEquals("target names may not contain ')'",
LabelValidator.validateTargetName("bazfoo)"));
}
@Test
public void testValidateAbsoluteLabel() throws Exception {
PackageAndTarget emptyPackage = new PackageAndTarget("", "bar");
assertEquals(emptyPackage, LabelValidator.validateAbsoluteLabel("//:bar"));
assertEquals(emptyPackage, LabelValidator.validateAbsoluteLabel("@repo//:bar"));
assertEquals(new PackageAndTarget("foo", "bar"),
LabelValidator.validateAbsoluteLabel("@repo//foo:bar"));
assertEquals(new PackageAndTarget("foo", "bar"),
LabelValidator.validateAbsoluteLabel("@//foo:bar"));
try {
LabelValidator.validateAbsoluteLabel("@foo");
fail("Should not have been able to validate @foo");
} catch (LabelValidator.BadLabelException expected) {
assertThat(expected.getMessage()).contains("invalid fully-qualified label");
}
}
@Test
public void testPackageAndTargetHashCode_distinctButEqualObjects() {
PackageAndTarget fooTarget1 = newFooTarget();
PackageAndTarget fooTarget2 = newFooTarget();
assertNotSame(fooTarget1, fooTarget2);
assertEquals("Should have same hash code", fooTarget2.hashCode(), fooTarget1.hashCode());
}
@Test
public void testPackageAndTargetEquals_distinctButEqualObjects() {
PackageAndTarget fooTarget1 = newFooTarget();
PackageAndTarget fooTarget2 = newFooTarget();
assertNotSame(fooTarget1, fooTarget2);
assertEquals("Should be equal", fooTarget2, fooTarget1);
}
@Test
public void testPackageAndTargetEquals_unequalObjects() {
assertFalse("should be unequal", newFooTarget().equals(newBarTarget()));
}
@Test
public void testPackageAndTargetToString() {
assertEquals("//foo:foo", newFooTarget().toString());
assertEquals("//bar:bar", newBarTarget().toString());
}
}
|
