1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
|
// Copyright 2016 The Bazel Authors. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package com.google.devtools.build.lib.analysis;
import com.google.devtools.build.lib.analysis.util.BuildViewTestCase;
import java.io.OutputStream;
import java.nio.charset.StandardCharsets;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
/** Tests for deprecation warnings in Bazel. */
@RunWith(JUnit4.class)
public final class DeprecationValidatorTest extends BuildViewTestCase {
@Test
public void noDeprecationWarningForTopLevelTarget() throws Exception {
scratchConfiguredTarget(
"a",
"a",
"filegroup(name='a', deprecation='ignored because this target is on the top level')");
assertNoEvents();
}
@Test
public void noDeprecationWarningWithinPackage() throws Exception {
scratchConfiguredTarget(
"a",
"a",
"filegroup(name='a', srcs=[':b'])",
"filegroup(name='b', deprecation='ignored because depending target is in same package')");
assertNoEvents();
}
@Test
public void noDeprecationWarningForDeprecatedTarget() throws Exception {
scratchConfiguredTarget(
"b",
"b",
"filegroup(name='b', deprecation='ignored because depending target is deprecated')");
scratchConfiguredTarget(
"a",
"a",
"filegroup(name='a', srcs=['//b:b'], deprecation='ignored for a top level target')");
assertNoEvents();
}
@Test
public void noDeprecationWarningForJavatestsCompanionOfJavaPackage() throws Exception {
scratchConfiguredTarget(
"java/a",
"b",
"filegroup(name='b', deprecation='ignored because depending target is javatests match')");
scratchConfiguredTarget("javatests/a", "a", "filegroup(name='a', srcs=['//java/a:b'])");
assertNoEvents();
}
@Test
public void deprecationWarningForJavaCompanionOfJavatestsPackage() throws Exception {
scratchConfiguredTarget(
"javatests/a",
"b",
"filegroup(name='b', deprecation='deprecation warning printed', testonly=0)");
checkWarning(
"java/a",
"a",
"target '//java/a:a' depends on deprecated target '//javatests/a:b': "
+ "deprecation warning printed",
"filegroup(name='a', srcs=['//javatests/a:b'])");
}
@Test
public void deprecationWarningForDifferentPackage() throws Exception {
scratchConfiguredTarget(
"b", "b", "filegroup(name='b', deprecation='deprecation warning printed')");
checkWarning(
"a",
"a",
"target '//a:a' depends on deprecated target '//b:b': deprecation warning printed",
"filegroup(name='a', srcs=['//b:b'])");
}
@Test
public void deprecationWarningForSamePackageInDifferentRepository() throws Exception {
try (OutputStream output = scratch.resolve("WORKSPACE").getOutputStream(true /* append */)) {
output.write(
"\nlocal_repository(name = 'r', path = '/r')\n".getBytes(StandardCharsets.UTF_8));
}
scratch.file("/r/WORKSPACE", "workspace(name = 'r')");
scratch.file("/r/a/BUILD", "filegroup(name='b', deprecation='deprecation warning printed')");
invalidatePackages();
checkWarning(
"a",
"a",
"target '//a:a' depends on deprecated target '@r//a:b': deprecation warning printed",
"filegroup(name='a', srcs=['@r//a:b'])");
}
@Test
public void deprecationWarningForJavatestsCompanionOfJavaPackageInDifferentRepository()
throws Exception {
try (OutputStream output = scratch.resolve("WORKSPACE").getOutputStream(true /* append */)) {
output.write(
"\nlocal_repository(name = 'r', path = '/r')\n".getBytes(StandardCharsets.UTF_8));
}
scratch.file("/r/WORKSPACE", "workspace(name = 'r')");
scratch.file(
"/r/java/a/BUILD", "filegroup(name='b', deprecation='deprecation warning printed')");
invalidatePackages();
checkWarning(
"javatests/a",
"a",
"target '//javatests/a:a' depends on deprecated target '@r//java/a:b': "
+ "deprecation warning printed",
"filegroup(name='a', srcs=['@r//java/a:b'])");
}
}
|
