1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
|
// Copyright 2017 The Bazel Authors. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package com.google.devtools.build.lib.analysis;
import static com.google.common.truth.Truth.assertThat;
import static com.google.devtools.build.lib.packages.Attribute.attr;
import static com.google.devtools.build.lib.packages.BuildType.LABEL;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.Iterables;
import com.google.devtools.build.lib.analysis.config.BuildOptions;
import com.google.devtools.build.lib.analysis.config.transitions.PatchTransition;
import com.google.devtools.build.lib.analysis.util.AnalysisTestCase;
import com.google.devtools.build.lib.analysis.util.MockRule;
import com.google.devtools.build.lib.cmdline.Label;
import com.google.devtools.build.lib.packages.Attribute;
import com.google.devtools.build.lib.skyframe.util.SkyframeExecutorTestUtils;
import com.google.devtools.build.lib.testutil.Suite;
import com.google.devtools.build.lib.testutil.TestOnlyInNormalExecutionMode;
import com.google.devtools.build.lib.testutil.TestRuleClassProvider;
import com.google.devtools.build.lib.testutil.TestSpec;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
/**
* Tests <target, sourceConfig> -> <dep, depConfig> relationships over latebound attributes.
*
* <p>Ideally these tests would be in {@link
* com.google.devtools.build.lib.skyframe.ConfigurationsForTargetsTest}. But that's a Skyframe test
* (ConfiguredTargetFunction is a Skyframe function). And the Skyframe library doesn't know anything
* about latebound attributes. So we need to place these properly under the analysis package.
*/
@TestOnlyInNormalExecutionMode // TODO(b/67651960): fix or justify disabling.
@TestSpec(size = Suite.SMALL_TESTS)
@RunWith(JUnit4.class)
public class ConfigurationsForLateBoundTargetsTest extends AnalysisTestCase {
private static final PatchTransition CHANGE_FOO_FLAG_TRANSITION = options -> {
BuildOptions toOptions = options.clone();
toOptions.get(LateBoundSplitUtil.TestOptions.class).fooFlag = "PATCHED!";
return toOptions;
};
/** Rule definition with a latebound dependency. */
private static final RuleDefinition LATE_BOUND_DEP_RULE =
(MockRule)
() ->
MockRule.define(
"rule_with_latebound_attr",
(builder, env) -> {
builder
.add(
attr(":latebound_attr", LABEL)
.value(
Attribute.LateBoundDefault.fromConstantForTesting(
Label.parseAbsoluteUnchecked("//foo:latebound_dep")))
.cfg(CHANGE_FOO_FLAG_TRANSITION))
.requiresConfigurationFragments(LateBoundSplitUtil.TestFragment.class);
});
@Before
public void setupCustomLateBoundRules() throws Exception {
ConfiguredRuleClassProvider.Builder builder = new ConfiguredRuleClassProvider.Builder();
TestRuleClassProvider.addStandardRules(builder);
builder.addRuleDefinition(LateBoundSplitUtil.RULE_WITH_LATEBOUND_SPLIT_ATTR);
builder.addRuleDefinition(LateBoundSplitUtil.RULE_WITH_TEST_FRAGMENT);
builder.addConfigurationFragment(new LateBoundSplitUtil.FragmentLoader());
builder.addConfigurationOptions(LateBoundSplitUtil.TestOptions.class);
builder.addRuleDefinition(LATE_BOUND_DEP_RULE);
useRuleClassProvider(builder.build());
}
@Test
public void lateBoundAttributeInTargetConfiguration() throws Exception {
scratch.file("foo/BUILD",
"rule_with_latebound_attr(",
" name = 'foo')",
"rule_with_test_fragment(",
" name = 'latebound_dep')");
update("//foo:foo");
assertThat(getConfiguredTarget("//foo:foo", getTargetConfiguration())).isNotNull();
ConfiguredTarget dep = Iterables.getOnlyElement(
SkyframeExecutorTestUtils.getExistingConfiguredTargets(
skyframeExecutor, Label.parseAbsolute("//foo:latebound_dep")));
assertThat(dep.getConfiguration()).isNotEqualTo(getTargetConfiguration());
assertThat(LateBoundSplitUtil.getOptions(dep.getConfiguration()).fooFlag).isEqualTo("PATCHED!");
}
@Test
public void lateBoundAttributeInHostConfiguration() throws Exception {
scratch.file("foo/BUILD",
"genrule(",
" name = 'gen',",
" srcs = [],",
" outs = ['gen.out'],",
" cmd = 'echo hi > $@',",
" tools = [':foo'])",
"rule_with_latebound_attr(",
" name = 'foo')",
"rule_with_test_fragment(",
" name = 'latebound_dep')");
update("//foo:gen");
assertThat(getConfiguredTarget("//foo:foo", getHostConfiguration())).isNotNull();
ConfiguredTarget dep = Iterables.getOnlyElement(
SkyframeExecutorTestUtils.getExistingConfiguredTargets(
skyframeExecutor, Label.parseAbsolute("//foo:latebound_dep")));
assertThat(dep.getConfiguration()).isEqualTo(getHostConfiguration());
// This is technically redundant, but slightly stronger in sanity checking that the host
// configuration doesn't happen to match what the patch would have done.
assertThat(LateBoundSplitUtil.getOptions(dep.getConfiguration()).fooFlag).isEmpty();
}
@Test
public void lateBoundSplitAttributeInTargetConfiguration() throws Exception {
scratch.file("foo/BUILD",
"rule_with_latebound_split(",
" name = 'foo')",
"rule_with_test_fragment(",
" name = 'latebound_dep')");
update("//foo:foo");
assertThat(getConfiguredTarget("//foo:foo")).isNotNull();
Iterable<ConfiguredTarget> deps = SkyframeExecutorTestUtils.getExistingConfiguredTargets(
skyframeExecutor, Label.parseAbsolute("//foo:latebound_dep"));
assertThat(deps).hasSize(2);
assertThat(
ImmutableList.of(
LateBoundSplitUtil.getOptions(Iterables.get(deps, 0).getConfiguration()).fooFlag,
LateBoundSplitUtil.getOptions(Iterables.get(deps, 1).getConfiguration()).fooFlag))
.containsExactly("one", "two");
}
@Test
public void lateBoundSplitAttributeInHostConfiguration() throws Exception {
scratch.file("foo/BUILD",
"genrule(",
" name = 'gen',",
" srcs = [],",
" outs = ['gen.out'],",
" cmd = 'echo hi > $@',",
" tools = [':foo'])",
"rule_with_latebound_split(",
" name = 'foo')",
"rule_with_test_fragment(",
" name = 'latebound_dep')");
update("//foo:gen");
assertThat(getConfiguredTarget("//foo:foo", getHostConfiguration())).isNotNull();
ConfiguredTarget dep = Iterables.getOnlyElement(
SkyframeExecutorTestUtils.getExistingConfiguredTargets(
skyframeExecutor, Label.parseAbsolute("//foo:latebound_dep")));
assertThat(dep.getConfiguration()).isEqualTo(getHostConfiguration());
// This is technically redundant, but slightly stronger in sanity checking that the host
// configuration doesn't happen to match what the split would have done.
assertThat(LateBoundSplitUtil.getOptions(dep.getConfiguration()).fooFlag).isEmpty();
}
}
|
