aboutsummaryrefslogtreecommitdiffhomepage
path: root/src
Commit message (Collapse)AuthorAge
...
* Add missing dash for -finline-limit=300Gravatar Steven Dee2015-10-22
| | | | | | | -- Change-Id: Ic19a8292e1c57623085daa6ce3cbf280cdf7129e Reviewed-on: https://bazel-review.googlesource.com/2180 MOS_MIGRATED_REVID=106035838
* Increase visibility of BuildingState methodGravatar Mark Schaller2015-10-22
| | | | | -- MOS_MIGRATED_REVID=106004898
* Have @SkylarkCallable methods accept Iterable instead of CollectionGravatar Francois-Rene Rideau2015-10-22
| | | | | | | This makes it possible to call these methods with lists from Skylark, which are internally Iterable<>'s but not Collection<>'s. -- MOS_MIGRATED_REVID=106003065
* Singleton-ify ErrorTransienceValueGravatar Michajlo Matijkiw2015-10-22
| | | | | | | | | | | | | | We rely on ErrorTransienceValue being different across evaluations by way of java reference inequality, instead make it a singleton and make it so that ErrorTransienceValue compares equal to nothing, including itself. Alternatively we could attach the corresponding Version to ErrorTransienceValue and use that to force inequality across evaluations. However this gets into the different possible Version implementations and their varying semantics, so go with the simplest approach first and see how it works out. -- MOS_MIGRATED_REVID=106001826
* Description redacted.Gravatar Alex Humesky2015-10-22
| | | | | -- MOS_MIGRATED_REVID=105999401
* Fix broken / backwards logic in the blaze launcher when trying to kill a ↵Gravatar Eric Fellheimer2015-10-22
| | | | | | | | | | | running server (because startup flags changed, different Blaze version, etc.). Currently, we do a SIGTERM then fallback to a SIGKILL. Our logic to check if the server was still up after the fallback was backwards, so in some cases we would connect to the old server even though we just sent it a SIGKILL. Not really ideal. Note that this only occurred if the SIGTERM failed to kill the Blaze process within 10s, so this failure mode happened rarely. Also: Check for the expected errno from the kill(), and exit with an "internal error" exit code instead of "1" if we are unable to kill the old server. -- MOS_MIGRATED_REVID=105999230
* Process tasks in the AbstractQueueVisitor in LIFO order as opposed to FIFO ↵Gravatar Janak Ramakrishnan2015-10-22
| | | | | | | | | order. In general, there's no advantage in Blaze to FIFO, and it means that we effectively do breadth-first graph traversal. When we must hold state for incomplete nodes (as we do with action execution, or more generally, as we do in Skyframe), this increases our memory footprint. LIFO is not exactly depth-first traversal, since we are multithreaded, but to a first approximation, it looks like a depth-first traversal with "width" the number of threads (at each level of the graph, #(threads) nodes are visited). -- MOS_MIGRATED_REVID=105995014
* Memoize TRANSITIVE_TRAVERSAL nodes to save memory.Gravatar Miguel Alcon Pinto2015-10-22
| | | | | -- MOS_MIGRATED_REVID=105994907
* Remove wildcard of SkyFunctionName, as it is finalGravatar Mark Schaller2015-10-22
| | | | | | | Nothing can extend SkyFunctionName. It's final. -- MOS_MIGRATED_REVID=105989976
* Add Skylark aspect tests.Gravatar Dmitry Lomov2015-10-22
| | | | | -- MOS_MIGRATED_REVID=105986411
* Introduce an AspectClass: a representation of a class of aspects.Gravatar Dmitry Lomov2015-10-22
| | | | | | | For native aspects, AspectClass is a facade for Class<AspectFactory<...>>. -- MOS_MIGRATED_REVID=105986390
* Minor cleanups to GraphTesterGravatar Mark Schaller2015-10-22
| | | | | | | | Refactors SkyFunction map creation into the tester from tests. Encapsulates modifiedValues better. -- MOS_MIGRATED_REVID=105982046
* In SkyQueryEnvironment, check TransitiveTraversalValues for errorsGravatar Mark Schaller2015-10-22
| | | | | | | | | | | | | | | In SkyQueryEnvironment, the buildTransitiveClosure method ignored the error messages in successfully evaluated TransitiveTraversalValues, under the belief that any such error messages are also obtainable by calling getMissingAndExceptions. This happens to be true right now, but may not be true in the future. If, in particular, the TransitiveTraversal skyfunction inlines its call to the TargetMarker skyfunction, those error messages won't be available through getMissingAndExceptions. -- MOS_MIGRATED_REVID=105980430
* Retain first error message during transitive traversalGravatar Mark Schaller2015-10-22
| | | | | | | | | | | | | | | | | | | | | | | | | Previously, a TransitiveTraversalFunction computed a value that contained an exception only if the exception resulted from a failure to load the function's immediate target. If the target had transitive dependencies on other targets, those other targets would be loaded, but any errors resulting from loading those targets would not be retained. SkyQueryEnvironment impromperly used a SkyFrame mechanism (which was solely intended to ensure equivalent semantics between keep-going and no-keep-going evaluations) to discover errors in the set of transitive children of TransitiveTraversal nodes. In order to transition SkyQueryEnvironment away from that mechanism, this CL changes TransitiveTraversalFunction to remember the first error message encountered while loading its target and its transitive dependencies. By remembering just the error message as a string, and not the full exception object, this also helps TransitiveTraversalValue have more consistent equality semantics for change-pruning. -- MOS_MIGRATED_REVID=105977182
* Description redacted.Gravatar Googler2015-10-22
| | | | | -- MOS_MIGRATED_REVID=105975871
* Remove transitive data from Android Studio aspect.Gravatar Googler2015-10-22
| | | | | | | | The cost-benefit isn't there to pay a square cost to roll these up on the blaze side. Android Studio has to do it on its end instead. -- MOS_MIGRATED_REVID=105971068
* Narrow return type of ContainingPackageLookupValue.withContainingPackageGravatar Michajlo Matijkiw2015-10-22
| | | | | -- MOS_MIGRATED_REVID=105969015
* Open source more tests for packages/Gravatar Han-Wen Nienhuys2015-10-22
| | | | | | | | | | Tested: bazel test on merge-to-os-blaze.sh checked total test method count on blaze test //javatests/com/google/devtools/build/lib:PackagesTests //third_party/bazel/src/test/java/com/google/devtools/build/lib:packages-tests -- MOS_MIGRATED_REVID=105963077
* Trying again with checking for the presence of the "resources" attribute and ↵Gravatar Googler2015-10-21
| | | | | | | | | | | | | | | | | deduplication of transitive and direct dependencies in the AndroidProcessingAction. Change the resource dependency handling to separate between the transitive and direct resources from libraries. This slightly increases the complexity of resource propagation. The initial algorithm was to simply merge all transitive ResourceContainers together with any new ResourceContainer and propagate them via the AndroidResourcesProvider. The new algorithm is encapsulated inside a new ResourceDependencies class which works as follows: 1. Collect resources from the deps into transitive and direct NestedSets 2. If a rule provides a ResourceContainer, merge the transitive and direct into a new transitive set 3. Export the provider This results having a rule without resources "forward" the merged sets of transitive and direct resources to the next rule. -- MOS_MIGRATED_REVID=105960655
* Lexer: Handle triple quoted raw strings (e.g. r"""abc""").Gravatar Laurent Le Brun2015-10-21
| | | | | -- MOS_MIGRATED_REVID=105956734
* Remove the repository name from PACKAGE_NAME and move it to the new ↵Gravatar Lukacs Berki2015-10-21
| | | | | | | REPOSITORY_NAME symbol. -- MOS_MIGRATED_REVID=105954652
* Replace "Google Inc" with "The Bazel Authors" in every copyright notice.Gravatar Lukacs Berki2015-10-21
| | | | | -- MOS_MIGRATED_REVID=105949508
* Adds an oldName attribute and a wrapperOption attribute to the @Option ↵Gravatar Alex Humesky2015-10-21
| | | | | | | annotation for the options parser. oldName indicates the old name for the option, and the option will be parsed under both name and oldName. wrapperOption indicates that the option is a wrapper for other options. For example, in "--foo=--bar=baz", --foo wraps --bar=baz. With wrapperOption set to true for --foo, the options parser will "unwrap" --bar=baz and parse them as top-level flags. -- MOS_MIGRATED_REVID=105924412
* Change the preprocessor interface to take the byte[] contents of the BUILD ↵Gravatar Nathan Harmata2015-10-21
| | | | | | | | | file rather than a ParserInputSource. This is part of a series of changes with the net result being that we open, read, and parse each BUILD file exactly once. -- MOS_MIGRATED_REVID=105911557
* Introduce Path#isSpecialFile, FileSystem#isSpecialFile, and ↵Gravatar Nathan Harmata2015-10-21
| | | | | | | FileStatus#isSpecialFile to help disambiguate between a regular file and a special file, since the file size of a special file cannot be trusted. -- MOS_MIGRATED_REVID=105903622
* Keep track of any RuntimeExceptions thrown during evaluation. Previously, ↵Gravatar Janak Ramakrishnan2015-10-21
| | | | | | | RuntimeExceptions that were thrown after an InterruptedException was thrown would be swallowed. -- MOS_MIGRATED_REVID=105902192
* Add some strip/rstrip/lstrip testsGravatar Googler2015-10-21
| | | | | | | and fix the bugs that showed up as a result. -- MOS_MIGRATED_REVID=105896905
* Use a thin graph when querying reverse deps (or others that don't need the ↵Gravatar Miguel Alcon Pinto2015-10-21
| | | | | | | values). -- MOS_MIGRATED_REVID=105893837
* Don't assert presence of root causes if they're not persistently stored.Gravatar Janak Ramakrishnan2015-10-21
| | | | | -- MOS_MIGRATED_REVID=105889244
* Make EmptySkyValue not serializableGravatar Michajlo Matijkiw2015-10-21
| | | | | | | | Should be a singleton, should never be serialized or deserialized, but add equals and hash code as well for good measure. -- MOS_MIGRATED_REVID=105888511
* Delete unused NoSuchPackageException subclassGravatar Mark Schaller2015-10-21
| | | | | -- MOS_MIGRATED_REVID=105878456
* Global cleanup change.Gravatar Googler2015-10-21
| | | | | -- MOS_MIGRATED_REVID=105877617
* Include memleaks plugin support for experimental_ios_testGravatar Chris Parsons2015-10-21
| | | | | -- MOS_MIGRATED_REVID=105876178
* Improve documentation for resolve_commandGravatar Francois-Rene Rideau2015-10-21
| | | | | -- MOS_MIGRATED_REVID=105875176
* Check invalid empty dict attributesGravatar Francois-Rene Rideau2015-10-21
| | | | | | | | In checkAttrValNonEmpty, also check dict values for emptiness when the attribute was declared non-empty. -- MOS_MIGRATED_REVID=105871620
* Add support for Windows zip permissionsGravatar Kristina Chodorow2015-10-20
| | | | | | | | | Fixes #518. RELNOTES: Add support for Windows-created zip files with non-posix permissions. -- MOS_MIGRATED_REVID=105865785
* Unify Skylark and BUILD listsGravatar Francois-Rene Rideau2015-10-20
| | | | | | | | Use SkylarkList everywhere rather than either List or GlobList. Keep a GlobList underneath a MutableList, where applicable. -- MOS_MIGRATED_REVID=105864035
* Add netrc support to GitCloneFunction.Gravatar Erik Gilling2015-10-20
| | | | | | | -- Change-Id: Ib82d20394b85433d7b0aae4a71f07ec1af068fa0 Reviewed-on: https://bazel-review.googlesource.com/#/c/2140/ MOS_MIGRATED_REVID=105856861
* Add %crosstool_top% metasyntax for builtin cxx include directories.Gravatar Googler2015-10-20
| | | | | | | | | | | | Instead of two metasyntactic variables and one random bit of magic which changes relative paths to be children of crosstool, we now have three consistent pieces of metasyntax; except that since we can't actually remove the old syntax, we have either way for the time being. RELNOTES[NEW]: accept %crosstool_top% in cxx_builtin_include_directory -- MOS_MIGRATED_REVID=105854779
* Add e2e test for Go support.Gravatar Han-Wen Nienhuys2015-10-20
| | | | | | | -- Change-Id: I6b76e1fe76ae8a640b2ab7d70cc8bfda50801b74 Reviewed-on: https://bazel-review.googlesource.com/#/c/2160 MOS_MIGRATED_REVID=105854761
* Make 'blaze query --output=build' 25 times faster.Gravatar Laurent Le Brun2015-10-20
| | | | | -- MOS_MIGRATED_REVID=105854596
* Improve error diagnostics for Skylark aspects.Gravatar Dmitry Lomov2015-10-20
| | | | | -- MOS_MIGRATED_REVID=105851371
* Implement aspect(...) Skylark function.Gravatar Dmitry Lomov2015-10-20
| | | | | -- MOS_MIGRATED_REVID=105844221
* Move most of BlazeRuntime.beforeCommand() to CommandEnvironment.Gravatar Ulf Adams2015-10-20
| | | | | -- MOS_MIGRATED_REVID=105841866
* Move the outputService field to the CommandEnvironment.Gravatar Ulf Adams2015-10-20
| | | | | -- MOS_MIGRATED_REVID=105841398
* Move commandStartTime from BlazeRuntime to CommandEnvironment.Gravatar Ulf Adams2015-10-20
| | | | | -- MOS_MIGRATED_REVID=105840775
* Move workingDirectory to CommandEnvironment.Gravatar Ulf Adams2015-10-20
| | | | | | | Preparation for running multiple commands in parallel. -- MOS_MIGRATED_REVID=105840167
* Reduce memory churn when expanding many nested sets: Use compact hashset for ↵Gravatar Eric Fellheimer2015-10-20
| | | | | | | | | hte uniqueifer and size them smaller when we're under the memoization threshold. A heap dump (with retained garbage) showed many of these sets sitting around, most at under 60% fill ratio. -- MOS_MIGRATED_REVID=105818028
* Rollback of commit 25931a9333d50e50c5711ff0efc1a197f7ecd53a.Gravatar Peter Schmitt2015-10-20
| | | | | | | | | | | | | *** Reason for rollback *** Introduces tests that don't run on Bazel *** Original change description *** Enable Skylark tests in Bazel and opensource SkylarkIntegrationTest. -- MOS_MIGRATED_REVID=105811158
* Rollback of commit ac7195025b073948785db8c6975a53fc305c5087.Gravatar Peter Schmitt2015-10-20
| | | | | | | | | | | | | *** Reason for rollback *** Uses tests that don't run on Bazel *** Original change description *** Implement aspect(...) Skylark function. -- MOS_MIGRATED_REVID=105808850