diff options
author | 2015-10-21 19:58:43 +0000 | |
---|---|---|
committer | 2015-10-22 15:16:01 +0000 | |
commit | 06568808db8ccb6ca4bb0d663da4e3e1a9b1a308 (patch) | |
tree | 06009d374d3f2817eda9705a37ba52b2f3c07a92 /src | |
parent | f5143ecc7751acd076d61564842e26664fc5a50a (diff) |
Remove wildcard of SkyFunctionName, as it is final
Nothing can extend SkyFunctionName. It's final.
--
MOS_MIGRATED_REVID=105989976
Diffstat (limited to 'src')
4 files changed, 29 insertions, 22 deletions
diff --git a/src/main/java/com/google/devtools/build/skyframe/InMemoryMemoizingEvaluator.java b/src/main/java/com/google/devtools/build/skyframe/InMemoryMemoizingEvaluator.java index a45c5645bb..e35cc54c3d 100644 --- a/src/main/java/com/google/devtools/build/skyframe/InMemoryMemoizingEvaluator.java +++ b/src/main/java/com/google/devtools/build/skyframe/InMemoryMemoizingEvaluator.java @@ -53,7 +53,7 @@ import javax.annotation.Nullable; */ public final class InMemoryMemoizingEvaluator implements MemoizingEvaluator { - private final ImmutableMap<? extends SkyFunctionName, ? extends SkyFunction> skyFunctions; + private final ImmutableMap<SkyFunctionName, ? extends SkyFunction> skyFunctions; @Nullable private final EvaluationProgressReceiver progressReceiver; // Not final only for testing. private InMemoryGraph graph; @@ -80,20 +80,23 @@ public final class InMemoryMemoizingEvaluator implements MemoizingEvaluator { private final AtomicBoolean evaluating = new AtomicBoolean(false); public InMemoryMemoizingEvaluator( - Map<? extends SkyFunctionName, ? extends SkyFunction> skyFunctions, Differencer differencer) { + Map<SkyFunctionName, ? extends SkyFunction> skyFunctions, Differencer differencer) { this(skyFunctions, differencer, null); } public InMemoryMemoizingEvaluator( - Map<? extends SkyFunctionName, ? extends SkyFunction> skyFunctions, Differencer differencer, + Map<SkyFunctionName, ? extends SkyFunction> skyFunctions, + Differencer differencer, @Nullable EvaluationProgressReceiver invalidationReceiver) { this(skyFunctions, differencer, invalidationReceiver, new EmittedEventState(), true); } public InMemoryMemoizingEvaluator( - Map<? extends SkyFunctionName, ? extends SkyFunction> skyFunctions, Differencer differencer, + Map<SkyFunctionName, ? extends SkyFunction> skyFunctions, + Differencer differencer, @Nullable EvaluationProgressReceiver invalidationReceiver, - EmittedEventState emittedEventState, boolean keepEdges) { + EmittedEventState emittedEventState, + boolean keepEdges) { this.skyFunctions = ImmutableMap.copyOf(skyFunctions); this.differencer = Preconditions.checkNotNull(differencer); this.progressReceiver = invalidationReceiver; @@ -308,8 +311,7 @@ public final class InMemoryMemoizingEvaluator implements MemoizingEvaluator { } } - public ImmutableMap<? extends SkyFunctionName, ? extends SkyFunction> - getSkyFunctionsForTesting() { + public ImmutableMap<SkyFunctionName, ? extends SkyFunction> getSkyFunctionsForTesting() { return skyFunctions; } public static final EventFilter DEFAULT_STORED_EVENT_FILTER = @@ -336,14 +338,17 @@ public final class InMemoryMemoizingEvaluator implements MemoizingEvaluator { } }; - public static final EvaluatorSupplier SUPPLIER = new EvaluatorSupplier() { - @Override - public MemoizingEvaluator create( - Map<? extends SkyFunctionName, ? extends SkyFunction> skyFunctions, Differencer differencer, - @Nullable EvaluationProgressReceiver invalidationReceiver, - EmittedEventState emittedEventState, boolean keepEdges) { - return new InMemoryMemoizingEvaluator(skyFunctions, differencer, invalidationReceiver, - emittedEventState, keepEdges); - } - }; + public static final EvaluatorSupplier SUPPLIER = + new EvaluatorSupplier() { + @Override + public MemoizingEvaluator create( + Map<SkyFunctionName, ? extends SkyFunction> skyFunctions, + Differencer differencer, + @Nullable EvaluationProgressReceiver invalidationReceiver, + EmittedEventState emittedEventState, + boolean keepEdges) { + return new InMemoryMemoizingEvaluator( + skyFunctions, differencer, invalidationReceiver, emittedEventState, keepEdges); + } + }; } diff --git a/src/main/java/com/google/devtools/build/skyframe/MemoizingEvaluator.java b/src/main/java/com/google/devtools/build/skyframe/MemoizingEvaluator.java index 29ddf3d6ba..e54dc8d223 100644 --- a/src/main/java/com/google/devtools/build/skyframe/MemoizingEvaluator.java +++ b/src/main/java/com/google/devtools/build/skyframe/MemoizingEvaluator.java @@ -129,9 +129,11 @@ public interface MemoizingEvaluator { */ public static interface EvaluatorSupplier { MemoizingEvaluator create( - Map<? extends SkyFunctionName, ? extends SkyFunction> skyFunctions, Differencer differencer, + Map<SkyFunctionName, ? extends SkyFunction> skyFunctions, + Differencer differencer, @Nullable EvaluationProgressReceiver invalidationReceiver, - EmittedEventState emittedEventState, boolean keepEdges); + EmittedEventState emittedEventState, + boolean keepEdges); } /** diff --git a/src/main/java/com/google/devtools/build/skyframe/ParallelEvaluator.java b/src/main/java/com/google/devtools/build/skyframe/ParallelEvaluator.java index 9c8f00b04c..a7c7aee204 100644 --- a/src/main/java/com/google/devtools/build/skyframe/ParallelEvaluator.java +++ b/src/main/java/com/google/devtools/build/skyframe/ParallelEvaluator.java @@ -136,7 +136,7 @@ public final class ParallelEvaluator implements Evaluator { void accept(T object); } - private final ImmutableMap<? extends SkyFunctionName, ? extends SkyFunction> skyFunctions; + private final ImmutableMap<SkyFunctionName, ? extends SkyFunction> skyFunctions; private final EventHandler reporter; private final NestedSetVisitor<TaggedEvents> replayingNestedSetEventVisitor; @@ -152,7 +152,7 @@ public final class ParallelEvaluator implements Evaluator { public ParallelEvaluator( ProcessableGraph graph, Version graphVersion, - ImmutableMap<? extends SkyFunctionName, ? extends SkyFunction> skyFunctions, + ImmutableMap<SkyFunctionName, ? extends SkyFunction> skyFunctions, final EventHandler reporter, EmittedEventState emittedEventState, EventFilter storedEventFilter, diff --git a/src/test/java/com/google/devtools/build/skyframe/MemoizingEvaluatorTest.java b/src/test/java/com/google/devtools/build/skyframe/MemoizingEvaluatorTest.java index 5ced1bd591..6e1efebde3 100644 --- a/src/test/java/com/google/devtools/build/skyframe/MemoizingEvaluatorTest.java +++ b/src/test/java/com/google/devtools/build/skyframe/MemoizingEvaluatorTest.java @@ -115,7 +115,7 @@ public class MemoizingEvaluatorTest { } protected MemoizingEvaluator getMemoizingEvaluator( - Map<? extends SkyFunctionName, ? extends SkyFunction> functions, + Map<SkyFunctionName, ? extends SkyFunction> functions, Differencer differencer, EvaluationProgressReceiver invalidationReceiver) { return new InMemoryMemoizingEvaluator( |