aboutsummaryrefslogtreecommitdiffhomepage
path: root/src
Commit message (Collapse)AuthorAge
* Avoid crash when a test and its alias are specified on the command line for ↵Gravatar lberki2017-11-03
| | | | | | | "blaze test". RELNOTES: None. PiperOrigin-RevId: 174386473
* Automated rollback of commit 8cb1d2fb460a9caf47df58d7ff051d31080a77cb.Gravatar ulfjack2017-11-03
| | | | | | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Roll forward again without the changes to expand_location, but with the trimming fix from https://github.com/bazelbuild/bazel/commit/19617360121635a77ffec99b84d825e7d9b260b1. *** Original change description *** Automated rollback of commit ca77f608e486bf7aa762565d25bf7b9e30f2268c. This also rolls back unknown commit. *** Reason for rollback *** Affected expand_location Skylark API semantics - it no longer accepts ${abc} or plain dollar signs, but complains. *** Original change description *** Extend TemplateExpander to handle $(func param) expansion Rewrite the Expander to use the new functionality; also rewrite the Skylark expand_location function to use it. PiperOrigin-RevId: 174384095
* Automated rollback of commit 5d42ae10195cd1acb9612df3a3d520f09b0c3e39.Gravatar cpeyser2017-11-03
| | | | | | | | | | | | | *** Reason for rollback *** Breaks alphago targets. *** Original change description *** Remove CppConfiguration#getFeatures in favor of CcToolchainProvider#getFeatures. PiperOrigin-RevId: 174373331
* When force_pic is on, build linkstamp objects with PIC.Gravatar Googler2017-11-03
| | | | | | | | | | Previously, linkstamp objects would be built without -fPIC. When linked into a PIE binary, this leads to text relocations, which causes IFUNC resolution to segfault (the resolution function is called while the binary is mapped RW). RELNOTES: None. PiperOrigin-RevId: 174366114
* Remove unused LegacyParamsFilePreProcessor. Removed test cases from ↵Gravatar apell2017-11-03
| | | | | | | OptionsParserTest are implemented in ParamsFilePreProcessorTest, ShellQuotedParamsFilePreProcessorTest and UnquotedParamsFilePreProcessorTest. RELNOTES: None. PiperOrigin-RevId: 174359569
* Move getManifestForRule implementation into default method.Gravatar dannark2017-11-03
| | | | | RELNOTES: None PiperOrigin-RevId: 174355404
* Record package-infos as explicit dependencies in Strict Java DepsGravatar cushon2017-11-03
| | | | PiperOrigin-RevId: 174354036
* Mark authorization-related errors as user errorsGravatar Googler2017-11-03
| | | | | | | Since the problem or the means to fix it is usually on the user side. RELNOTES=none PiperOrigin-RevId: 174348233
* Pass build_id to mobile-install deploy scriptGravatar Googler2017-11-03
| | | | PiperOrigin-RevId: 174343502
* Switch on tracking of specific option priorities.Gravatar ccalvarin2017-11-03
| | | | | | | Make sure that multiple calls to parse() follow each other sequentially. This is necessary for blazerc expansion, which occurs first in command order, then blazerc order. RELNOTES: None. PiperOrigin-RevId: 174343241
* Linter: don't require docstrings for short functionsGravatar fzaiser2017-11-03
| | | | | RELNOTES: none PiperOrigin-RevId: 174330237
* Linter: Tolerate whitespace-only lines and complain about misaligned closing ↵Gravatar brandjon2017-11-02
| | | | | | | quotes RELNOTES: None PiperOrigin-RevId: 174319420
* Linter: allow leading underscore in provider namesGravatar fzaiser2017-11-02
| | | | | RELNOTES: none PiperOrigin-RevId: 174318660
* Skylint: improve message for missing return and unitialized variablesGravatar fzaiser2017-11-02
| | | | | RELNOTES: none PiperOrigin-RevId: 174310059
* Skylint: also allow "UNUSED_" prefix in capital lettersGravatar fzaiser2017-11-02
| | | | | RELNOTES: none PiperOrigin-RevId: 174305935
* Fix typo in issue messageGravatar brandjon2017-11-02
| | | | | RELNOTES: None PiperOrigin-RevId: 174305030
* Fix typo in BlazeModule#blazeShutdown javadoc.Gravatar ajmichael2017-11-02
| | | | | RELNOTES: None PiperOrigin-RevId: 174229364
* Roll forward support for test resource inheritance behind a flagGravatar Googler2017-11-02
| | | | | RELNOTES: None PiperOrigin-RevId: 174219672
* Don't require --keep_going to discard graph edges. It's unnecessary.Gravatar janakr2017-11-02
| | | | PiperOrigin-RevId: 174202685
* removed "This is useful for Skylark..." Duplicate text from load() docGravatar Googler2017-11-02
| | | | | RELNOTES: None. PiperOrigin-RevId: 174199997
* Enable switching singlejar and ijar targets for remote execution.Gravatar xingao2017-11-02
| | | | | | When --define EXECUTOR=remote is specified in bazel command, embedded tool singlejar and ijar will be compiled remotely from source. PiperOrigin-RevId: 174195094
* Expose Apple Multi-architecture Split Transition to Skylark.Gravatar cparsons2017-11-02
| | | | | | | This omits validation for this transition, which will follow in a future change. RELNOTES: None. PiperOrigin-RevId: 174183651
* Automated rollback of commit 02a5b0fe11de1abe1c6f124413b847f0ecf6c4dd.Gravatar cparsons2017-11-02
| | | | | | | | | | | | | | | *** Reason for rollback *** Breaks Blaze nightly Example failing test: [] *** Original change description *** Allow android_test to properly inherit resources RELNOTES: none PiperOrigin-RevId: 174182803
* Force DexMapper (aka shuffle_jars) tool to partition large packages into ↵Gravatar kmb2017-11-01
| | | | | | | | multiple shards. Also fix some weirdnesses with how shard assignments were recorded. RELNOTES: None. PiperOrigin-RevId: 174095450
* Open source ZipFilterAction for use in Android testing.Gravatar ajmichael2017-11-01
| | | | | | | https://github.com/bazelbuild/bazel/issues/903 RELNOTES: None PiperOrigin-RevId: 174079202
* Add a 'estimateCurrentNumUniqueValues' method to MultisetSemaphore.Gravatar nharmata2017-11-01
| | | | | RELNOTES: None PiperOrigin-RevId: 174062560
* Rename ResourceFilter to ResourceFilterFactoryGravatar Googler2017-11-01
| | | | | | | | | | | In the next review, to handle issues around density filtering, ResourceFilterFactory will return another object that actually handles filtering. To ensure stuff is named properly, rename ResourceFilter to ResourceFilterFactory now so that the new class can be called ResourceFilter. This is a straightforward automated refactor, followed with some automated reformatting to make linting happy. I used the name ResourceFilterFactory, rather than the more concise ResourceFilters, as this class actually contains state (both around what filtering should currently do and about what resources were filtered out) and isn't just a helper class. RELNOTES: none PiperOrigin-RevId: 174049618
* Cosmetic refactor of some of the helper methods used by ↵Gravatar nharmata2017-11-01
| | | | | | | | | ParallelSkyQueryUtils.RBuildFilesVisitor. Also a minor tweak of the batch size for feeding results to the callback. Also correctly use the packageSemaphore in SkyQueryEnvironment's non-parallel implementation of rbuildfiles. RELNOTES: None PiperOrigin-RevId: 174039067
* Clean up LocalResourceContainer.BuilderGravatar Googler2017-11-01
| | | | | | | | | | | | | LocalResourceContainer.Builder is referenced a bunch of times, but most of those calls are identical. Replace them with a couple of factory methods. This lets us make the builder private. Additionally, LocalResourceContainer called attributeError() on the 'resources' attribute, even though 'resource_files' is now used most of the time instead. Now, the error is always given for the correct attribute. RELNOTES: none PiperOrigin-RevId: 174038035
* Move CppConfiguration#toolchainNeedsPic, #getRuntimeSysroot, andGravatar cpeyser2017-10-31
| | | | | | #getSolibDirectory to CcToolchainProvider. PiperOrigin-RevId: 174032021
* Add test asserting test_suite exclusion behaviorGravatar Googler2017-10-31
| | | | | | | | | test_suite expansion occurs after the target patterns are all processed. Otherwise, excluding a package can exclude tests from entirely different packages, which is counter-intuitive. This behavior was intentionally removed in unknown commit in 2012 and then inadvertently reintroduced in unknown commit in 2015. But I think the current behavior is more intuitive (and as of https://github.com/bazelbuild/bazel/commit/0dffc49f528c4c6e641221060e41aa6896310bdf is documented). RELNOTES: None. PiperOrigin-RevId: 173984189
* Move AndroidLocalTestBase.Gravatar dannark2017-10-31
| | | | | RELNOTES:None PiperOrigin-RevId: 173976330
* Automated rollback of commit c6b6dbadd0a93936c51154b25abc5fbba8f2d1af.Gravatar janakr2017-10-31
| | | | | | | | Not a totally clean rollback because of the intervening https://github.com/bazelbuild/bazel/commit/b5158a9a677b149e04e844c40a01e9a9dde40783. *** Reason for rollback *** PiperOrigin-RevId: 173957187
* Fixes EvaluationResult BuilderGravatar Googler2017-10-31
| | | | | RELNOTES: None PiperOrigin-RevId: 173950304
* Remove --incremental_dexing_binary_types.Gravatar ajmichael2017-10-31
| | | | | | | It has been set to all for a bit now. It is not in any teams blazerc/tap configs. RELNOTES: --incremental_dexing_binary_types has been removed. All builds are supported by incremental dexing (modulo proguard and some blacklisted dx flags). PiperOrigin-RevId: 173931117
* Migrate CppConfiguration#supportsGoldLinker, supportsDynamicLinker,Gravatar cpeyser2017-10-31
| | | | | | supportsEmbeddedRuntimes, supportsExecOrigin to CcToolchainProvider. PiperOrigin-RevId: 173928009
* Fix bug where all three implementations of ↵Gravatar nharmata2017-10-31
| | | | | | | | | RecursivePackageProvider#getPackagesUnderDirectory assumed that the given directory needed to be strictly underneath all directories in the given blacklistedSubdirectories set, yet the callsites were calling this method such that the given directory was not-necessarily-strictly underneath the blacklistedSubdirectories. N.B. There is no end-to-end bug in EnvironmentBackedRecursivePackageProvider because TargetPatternFunction's usage of TargetPattern#eval is always with blacklistedSubdirectories=ImmutableSet.of(). Also note that the existing fast-path in GraphBackedRecursivePackageProvider is dead code because the Preconditions check would fail first :( RELNOTES: None PiperOrigin-RevId: 173924216
* Make BuildEventServiceTransport sender thread verify the streaming RPC is ↵Gravatar Googler2017-10-31
| | | | | | | | | | active, restarting the RPC if required. - BuildEventServiceTransport sender thread checks the RPC is still active every 1s, failing the RPC if it was ended before we reached the end of the BEP stream. - "fail_fast" is the default behavior on gRPC (it needs to be disabled using .withWaitForReady). PiperOrigin-RevId: 173921837
* Default to not including library R classes in android_binary runtime classpathGravatar Googler2017-10-31
| | | | | | | | These classes should not be used by anything since the binary regenerates updated R classes. RELNOTES: none PiperOrigin-RevId: 173906178
* Make AndroidRuleClasses#hasProguardSpecs less fragile.Gravatar ajmichael2017-10-31
| | | | | | | Keeps the semantics the same. RELNOTES: None PiperOrigin-RevId: 173899927
* Reduce iterations and copies over inputs in ActionSpawn.Gravatar Jakob Buchgraber2017-10-30
| | | | | | | | | | | | | | | | The current implementation copies all inputs into a list and then iterates over them twice to remove filesets and manifests. We can do the filtering in one pass instead and avoid the copying to a list to save memory. In addition, the Action.getInputs() method often returns inputs stored in a NestedSet and we want to allow a caller to have access to it, so that he isn't forced to flatten it. A call can do that by checking if ActionSpawn.getInputFiles() is an instance of NestedSetView. Change-Id: I2fa8904827030c04bf29b14f0f3f942877c317a4 PiperOrigin-RevId: 173881256
* Remove hazelcast dependency from BazelGravatar Alpha Lam2017-10-30
| | | | | | | | | | | | This change removes Bazel's dependency on Hazelcast. This will help to reduce size of the Bazel binary and simplify the usage of remote cache. However Hazelcast library is still kept in the repository and still being used by remote_worker. It is useful as a REST server to allow integration testing with the remote rest cache functionality. Change-Id: Ia21b970cedaec84bc6c13e839509d838acb5756f PiperOrigin-RevId: 173880600
* [Trivial] Add a designated method for retrieving java.nio.file.PathGravatar Taras Tsugrii2017-10-30
| | | | | | | | | | | As explained in the javadoc this avoids unnecessary allocations and preserves underlying Java filesystem information. This partially addresses #3952. Closes #3953. PiperOrigin-RevId: 173877045
* Move TransitiveTargetKey to a dedicated top-level classGravatar ulfjack2017-10-30
| | | | PiperOrigin-RevId: 173873310
* Compute canonical list of options using OptionValueDescription's tracking of ↵Gravatar ccalvarin2017-10-30
| | | | | | | | | | | | | instances. Stop storing the canonical list of arguments separately. For the canonicalize-flags command, we want to avoid showing options that either have no values in their own right (such as expansion options and wrapper options) and instances of options that did not make it to the final value. This is work we already do in OptionValueDescription, so we can generate the canonical form from the values tracked there, instead of tracking it separately. This means the canonical list is more correct where implicit requirements are concerned: implicit requirements are not listed in the canonical form, but now the values they overwrote will be correctly absent as well. Use this improved list for the effective command line published to the BEP. RELNOTES: Published command lines should have improved lists of effective options. PiperOrigin-RevId: 173873154
* Skylint: improve message for unused list comprehensions.Gravatar fzaiser2017-10-30
| | | | | RELNOTES: none PiperOrigin-RevId: 173846739
* Add call to checkDesugarDeps in AndroidBinary.Gravatar kmb2017-10-30
| | | | PiperOrigin-RevId: 173731752
* Add migration methods to Path.Gravatar tomlu2017-10-30
| | | | | | We add methods to Path that accept a file system instead of using the associated instance. These will be used during migration away from the methods that use the Path's file system. PiperOrigin-RevId: 173707291
* Remove CppConfiguration#getFeatures in favor ofGravatar cpeyser2017-10-30
| | | | | | CcToolchainProvider#getFeatures. PiperOrigin-RevId: 173702792
* Allow android_test to properly inherit resourcesGravatar Googler2017-10-30
| | | | | RELNOTES: none PiperOrigin-RevId: 173691842