| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
| |
--
Change-Id: I2f08a61c06a1a6fda6a8e30c347cca3336b01b95
Reviewed-on: https://bazel-review.googlesource.com/#/c/3780
MOS_MIGRATED_REVID=124544524
|
|
|
|
|
|
|
|
| |
The @SkylarkCallable annotation is very limited and to extend it
it is best to share a similar API than the @SkylarkSignature annotation.
--
MOS_MIGRATED_REVID=124473056
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, analysis-time cycle detection expects all cycles to come from ConfiguredTargetFunction.
With dynamic configurations, ConfiguredTargetFunction calls out to TransitiveTargetFunction to figure out which configuration fragments its deps need.
If there's a cycle between the current target and a dep, the dep's TransitiveTargetFunction fails, which the current cycle detection code can't handle.
But even if it could handle it, since the failure occurs in the dep we'd get error messages like:
"in cc_library rule //the:dep: cycle in dependency graph"
instead of the expected:
"in cc_library rule //the:top_level_rule: cycle in dependency graph"
This used to not be a problem because loading-phase cycle detection caught the cycle before all this triggered. But interleaved loading and analysis removes that gate.
Tested: BuildViewTest cycle detection tests with dynamic configurations turned on
--
MOS_MIGRATED_REVID=124391277
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Makes it so module map generation action will be registered for all targets that should provide module maps. This allows other rules to depend directly on modulemap artifacts without turning on --experimental_objc_enable_module_maps for all builds.
* Disabled module maps for apple_binary because of a bug.
* objc_proto_library targets will register module map generation even with experimental union flag so that its modules can be imported by the dependent targets (even though the compilation is happening much later in the linking target).
RELNOTES:
--
MOS_MIGRATED_REVID=124386048
|
|
|
|
|
|
|
|
|
|
| |
don't yet support fragments from late-bound attributes.
This is intended to extend to any other class of errors that can't
already be centrally encoded somewhere in the production logic.
--
MOS_MIGRATED_REVID=124384937
|
|
|
|
|
|
|
|
| |
Fixes #1343 due to missing iOS SDK version.
--
Reviewed-on: https://github.com/bazelbuild/bazel/pull/1350
MOS_MIGRATED_REVID=124328836
|
|
|
|
|
|
|
|
| |
an action_config specifies no action, and is automatically applied to the
action being configured.
--
MOS_MIGRATED_REVID=124240929
|
|
|
|
|
|
|
|
| |
* Support package manifest
* Add android_resource support
--
MOS_MIGRATED_REVID=124187461
|
|
|
|
|
|
|
|
| |
1. Adds ActionTemplateExpansion{Function, Value} for ActionTemplate expansion.
2. Changes ArtifactFunction to support evaluating TreeFileArtifacts and TreeArtifacts generated by ActionTemplate.
--
MOS_MIGRATED_REVID=124160939
|
|
|
|
|
|
|
| |
GlobTaskContext object. Also dedupe identical recursive calls that arise from our naive implementation of the glob algorithm.
--
MOS_MIGRATED_REVID=124159729
|
|
|
|
|
|
|
| |
around so that we still have good test coverage for 'excludes' in globs.
--
MOS_MIGRATED_REVID=124152499
|
|
|
|
|
|
|
| |
Fixes #1172.
--
MOS_MIGRATED_REVID=124122716
|
|
|
|
|
|
|
|
|
|
| |
to override the environment variables.
Fixes #1130
Fixes #1242
--
MOS_MIGRATED_REVID=124118789
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
attributes as parameters, without using an attribute_map.
As a result, users can now define
def _callback(some_attribute):
return do_something(some_attribute)
instead of
def _callback(attr_map):
return do_something(attr_map.some_attribute)
The legacy version with an attribute map is going to be deprecated in a future change.
--
MOS_MIGRATED_REVID=124116923
|
|
|
|
|
|
|
| |
* This eliminates the need to put "dummy.swift" into objc_binary targets that depend on swift_library.
--
MOS_MIGRATED_REVID=124015750
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=123988802
|
|
|
|
|
|
|
| |
This fixes test timeouts when the app tested is using Swift. In theory this also prevents similar problems with any code that uses dynamic libs packaged in the IPA.
--
MOS_MIGRATED_REVID=123976581
|
|
|
|
|
|
|
| |
It works for both labels on the command-line and labels in BUILD files.
--
MOS_MIGRATED_REVID=123967347
|
|
|
|
|
|
|
| |
--
Change-Id: I86178005713ad80da365b96070794feeb9cc05ab
Reviewed-on: https://bazel-review.googlesource.com/#/c/3751/
MOS_MIGRATED_REVID=123959813
|
|
|
|
|
|
|
|
|
| |
RELNOTES:
global function 'provider' is removed from .bzl files. Providers can
only be accessed through fields in a 'target' object.
--
MOS_MIGRATED_REVID=123956571
|
|
|
|
|
|
|
|
|
| |
The IDE currently extracts these from the output jars by
a fragile string comparison. This will allow the IDE to
do so more robustly (eg. in case the resource jar output is renamed).
--
MOS_MIGRATED_REVID=123939803
|
|
|
|
|
|
|
|
|
| |
based on my limited understanding of python syntax, the only things we don't support is //= and **=, but it looks like skylark doesn't support the corresponding infix operators.
RELNOTES[NEW]: add support for the '-=', '*=', '/=', and'%=' operators to skylark. Notably, we do not support '|=' because the semantics of skylark sets are sufficiently different from python sets.
--
MOS_MIGRATED_REVID=123889776
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=123887669
|
|
|
|
|
|
|
|
|
|
|
| |
The experimental UI also keeps track, in the progress bar, of the last test
that completed. When using curses, use colors to indicate whether the test
passed or not.
--
Change-Id: Iaa01a773c3bbf534692ed21dd420596cb63e2585
Reviewed-on: https://bazel-review.googlesource.com/#/c/3752
MOS_MIGRATED_REVID=123871492
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=123858617
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=123851529
|
|
|
|
|
|
|
| |
Fixes #1329.
--
MOS_MIGRATED_REVID=123843592
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Right now, configuration trimming happens in
ConfiguredTargetFunction.computeDependencies. This means only
the deps of other targets get trimmed.
With this change, every ConfiguredTarget gets its configuration
accurately trimmed, regardless of where it comes from or what
it's used for.
In practice, there could still be other code paths that
instantiate ConfiguredTargetValue.key without pre-trimming.
We'll have to tackle those as we hit them.
Also cleaned up some symbol naming in BuildView.update to try
to make the logic flow clearer.
TESTED: BuildViewTest#testNewActionsAreDifferentAndDontConflict now
passes with dynamic configs (among others)
--
MOS_MIGRATED_REVID=123807892
|
|
|
|
|
|
|
| |
This will be used later to detect typos and provide suggestions.
--
MOS_MIGRATED_REVID=123761611
|
|
|
|
|
|
|
|
|
| |
action_config to configure the build. Otherwise, revert to hard-coded behavior.
This change is designed to provide backwards-compatible support for crosstools that describe platform-specific linking semantics.
--
MOS_MIGRATED_REVID=123748494
|
|
|
|
|
|
|
|
|
|
|
| |
(finally) delete Constants.java.
For bazel the file Constants.java is the only source of
src/main/java/com/google/devtools/build/lib:common and since it was exporting
guava then many dependencies needed to be fixed.
--
MOS_MIGRATED_REVID=123648270
|
|
|
|
|
|
|
| |
Fixes the android part of #1316.
--
MOS_MIGRATED_REVID=123644129
|
|
|
|
|
|
|
| |
RELNOTES: The --ues_isystem_for_includes command line option is not supported anymore.
--
MOS_MIGRATED_REVID=123617061
|
|
|
|
|
|
|
| |
Consider /src/ in the path when locating the java root directory.
--
MOS_MIGRATED_REVID=123469898
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=123441206
|
|
|
|
|
|
|
| |
@bazel_tools. Currently the tool still remains in embedded_binaries, but we will migrate away from that: Eventually it can simply live just under @bazel_tools.
--
MOS_MIGRATED_REVID=123436822
|
|
|
|
|
|
|
|
| |
* Modules are now named after its full target path by default.
* module_name attribute can be used to override this logic.
--
MOS_MIGRATED_REVID=123422704
|
|
|
|
|
|
|
|
|
|
|
| |
With the change of reporting progress during loading and analysis
by a custom package tracking class, the LoadingProgressReceiver
is not used anywhere anymore. Threfore, remove it.
--
Change-Id: Ia88d2d5608dea1bb395cd5b3c3e12c16200ecb41
Reviewed-on: https://bazel-review.googlesource.com/#/c/3701
MOS_MIGRATED_REVID=123410961
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To give a better understanding of which packages are on the critical
path during loading and analysis, provide information in the same way
as during execution: show the earliest started, but not yet completed
package. As not all packages looked at during the analysis phase are
reported to the progress receiver, use a custom class to aggregate those
data.
--
Change-Id: I03c25efdecb4124e1bc06fce8be9175dc56b5500
Reviewed-on: https://bazel-review.googlesource.com/#/c/3700
MOS_MIGRATED_REVID=123408689
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=123350350
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=123347295
|
|
|
|
|
|
|
|
|
|
| |
* Adds a way to read FRAMEWORK_ keys from ObjcProvider and provide outputs as -F args to the compiler
* Adds a sample dynamic framework for testing
RELNOTES: swift_library is now able to import framework rules such as objc_framework.
--
MOS_MIGRATED_REVID=123337139
|
|
|
|
|
|
|
| |
Aesthetic change only. Safe because no one yet consumes this.
--
MOS_MIGRATED_REVID=123279233
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=123251531
|
|
|
|
|
|
|
| |
creating fresh Package instances. Also make a few Package methods public.
--
MOS_MIGRATED_REVID=123247246
|
|
|
|
|
|
|
|
|
|
| |
Fixes #1281.
RELNOTES: Symlinks in zip files are now unzipped correctly by http_archive,
download_and_extract, etc.
--
MOS_MIGRATED_REVID=123233604
|
|
|
|
|
|
|
|
|
| |
* General cleanup of the rule code.
* Adds a way to use modulemaps to import Objective-C code.
* Adds a way to pass framework flags to the compiler and adds the developer frameworks dir from Xcode as one.
--
MOS_MIGRATED_REVID=123217120
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=123214350
|
|
|
|
|
|
|
| |
Fixes #1298
--
MOS_MIGRATED_REVID=123208845
|
|
|
|
|
|
|
|
|
| |
Fix a bunch of tests to assume interleaving instead of disrete phases.
In our testing, this improves loading+analysis times by ~30%.
--
MOS_MIGRATED_REVID=123203752
|