diff options
| author |  Florian Weikert <fwe@google.com> | 2016-06-06 09:11:43 +0000 |
|---|---|---|
| committer |  Yun Peng <pcloudy@google.com> | 2016-06-06 16:41:23 +0000 |
| commit | 3ae59125807c2ba1a4a238703b0fc9780f96c32e (patch) | |
| tree | e517db8013455909d334ed447b0b498c2b1e42c8 /src/test | |
| parent | bda8ae9212621da50d6b18f185f99450fb6d6da9 (diff) | |
Skylark: callback functions can now explicitly specify their required attributes as parameters, without using an attribute_map.
As a result, users can now define
def _callback(some_attribute):
return do_something(some_attribute)
instead of
def _callback(attr_map):
return do_something(attr_map.some_attribute)
The legacy version with an attribute map is going to be deprecated in a future change.
--
MOS_MIGRATED_REVID=124116923
Diffstat (limited to 'src/test')
| -rw-r--r-- | src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java index d32519bd71..0bf7fcf76b 100644 --- a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java +++ b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java @@ -956,7 +956,7 @@ public class SkylarkRuleImplementationFunctionsTest extends SkylarkTestCase { " ctx.empty_action(", " inputs = [],", " )", - "def _foo(attr_map):", + "def _foo():", " return native.glob(['*'])", "glob_rule = rule(", " implementation = _impl,", @@ -998,9 +998,9 @@ public class SkylarkRuleImplementationFunctionsTest extends SkylarkTestCase { " output = o,", " content = 'hoho')", "", - "def _foo(attr_map):", + "def _foo(srcs):", " outs = {}", - " for i in attr_map.srcs:", + " for i in srcs:", " outs['foo_' + i.name] = i.name + '.out'", " return outs", "", |