aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main
Commit message (Collapse)AuthorAge
* Windows: resolve shortened pathsGravatar Laszlo Csomor2017-01-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | TL;DR: resolve "C:/progra~1" style paths, don't cache failed resolutions in the parent's Path.children When creating WindowsPath objects, resolve the "C:/progra~1" style paths to "C:/program files". This enables us to correctly compare paths on Windows. Without this canonicalization we incorrectly determine "C:/progra~1" and "C:/program files" to be different when they are actually the same. We only attempt to resolve such paths if the name looks like it's an abbreviated path. If resolution fails, probably due to the path not existing, then we don't cache this Path object in the parent's `children` list. This avoids stale cache entries in case the path springs into existence later in the server's lifetime. Fixes https://github.com/bazelbuild/bazel/issues/2145 We also need to rectify https://github.com/bazelbuild/bazel/issues/2173 -- PiperOrigin-RevId: 143442134 MOS_MIGRATED_REVID=143442134
* Change lib.events.Event to use UTF-8 encoding instead of a mix of ↵Gravatar Jon Brandvein2017-01-03
| | | | | | | | platform-default and latin-1 -- PiperOrigin-RevId: 143439199 MOS_MIGRATED_REVID=143439199
* Add expand_if_equal crosstool.proto messageGravatar Marcel Hlopko2017-01-03
| | | | | | | | | This will be used by LibrariesToLinkValue to switch on many different types of libraries. -- PiperOrigin-RevId: 143438434 MOS_MIGRATED_REVID=143438434
* Make "profile --html --html_details" work again.Gravatar Lukacs Berki2017-01-03
| | | | | | | | The start time of critical path component wasn't recorded correctly since #getStartWallTimeMillis() didn't work right. However, since profiler tasks store nanotime anyway, it's pointless to try to convert back and forth. -- PiperOrigin-RevId: 143438289 MOS_MIGRATED_REVID=143438289
* Make "profile --html --html_details" not crash.Gravatar Lukacs Berki2017-01-03
| | | | | | | | Fixes #2325. -- PiperOrigin-RevId: 143434786 MOS_MIGRATED_REVID=143434786
* Make an enum final, the way it should be.Gravatar Lukacs Berki2017-01-03
| | | | | | -- PiperOrigin-RevId: 143434756 MOS_MIGRATED_REVID=143434756
* Cleanup initialization of expandIfTrue/False in ↵Gravatar Marcel Hlopko2017-01-03
| | | | | | | | CcToolchainFeatures.FlagGroup constructor -- PiperOrigin-RevId: 143429631 MOS_MIGRATED_REVID=143429631
* Miscellaneous cleanups to lib.eventsGravatar Jon Brandvein2017-01-03
| | | | | | -- PiperOrigin-RevId: 143390220 MOS_MIGRATED_REVID=143390220
* Make the string strip() methods compatible with PythonGravatar Jon Brandvein2017-01-03
| | | | | | | | | | | | | | strip(), lstrip(), and rstrip() now accept a None argument as a synonym for the no-arg version. The characters that are considered as whitespace (to be removed by default in the no-arg form) are now the same as in Python 3.6. RELNOTES[INC]: The string methods strip(), lstrip(), and rstrip() now by default remove the same whitespace characters as Python 3 does, and accept None as an argument. -- PiperOrigin-RevId: 143388250 MOS_MIGRATED_REVID=143388250
* Add 'did you mean' suggestion for load() statements.Gravatar Laurent Le Brun2017-01-03
| | | | | | -- PiperOrigin-RevId: 143381556 MOS_MIGRATED_REVID=143381556
* Add 'did you mean' suggestion when accessing a struct fieldGravatar Laurent Le Brun2017-01-03
| | | | | | -- PiperOrigin-RevId: 143380643 MOS_MIGRATED_REVID=143380643
* Bazel client, Windows: case-insensitive MSYS rootGravatar Laszlo Csomor2017-01-03
| | | | | | | | | | | | Make the MSYS root retrieval case-insensitive. While there, make the MSYS root resetable so we can test it. See https://github.com/bazelbuild/bazel/issues/2323 -- PiperOrigin-RevId: 143377137 MOS_MIGRATED_REVID=143377137
* Add 'did you mean' suggestion when accessing an undefined variable.Gravatar Laurent Le Brun2017-01-03
| | | | | | -- PiperOrigin-RevId: 143373605 MOS_MIGRATED_REVID=143373605
* Bazel client, Windows: fix MSYS root retrievalGravatar Laszlo Csomor2017-01-03
| | | | | | | | | | | | | | | | | | | | | The file_windows.cc:MsysRoot::Get() function was incorrectly assuming that bash.exe is usually under c:\tools\msys64\bin\bash.exe when in reality it's c:\tools\msys64\usr\bin\bash.exe, so we need to walk up one more directory. Unfortunately the test was assuming the same so the bug wasn't caught. The new code is a bit more foolproof in that it looks for an msys-looking final path segment and assumes that to be the msys root. Fixes https://github.com/bazelbuild/bazel/issues/2323 -- PiperOrigin-RevId: 143372193 MOS_MIGRATED_REVID=143372193
* Remove WalkableGraph#exists and allow WalkableGraph#getValue and ↵Gravatar Janak Ramakrishnan2017-01-03
| | | | | | | | WalkableGraph#getException to be given non-existent keys without crashing. Add WalkableGraph#isCycle to fill the gap in testing for the difference between non-existence and depending on a cycle. -- PiperOrigin-RevId: 143205289 MOS_MIGRATED_REVID=143205289
* Cleanup in error messages, try to improve consistency.Gravatar Laurent Le Brun2017-01-03
| | | | | | -- PiperOrigin-RevId: 143204724 MOS_MIGRATED_REVID=143204724
* Fix flaky test supportGravatar Damien Martin-Guillerez2016-12-29
| | | | | | | | | | | | | Now a test marked as flaky = True will get re-executed up to three times if first attempts failed. Failed logs of first attempts will get moved in an attempts subfolder. Also fix a minor bug in the shell testing framework Fixes #540. Happy new year! -- PiperOrigin-RevId: 143182831 MOS_MIGRATED_REVID=143182831
* Make BuildConfiguration reference-equals for static configs.Gravatar Greg Estren2016-12-29
| | | | | | | | | Value equality is unsafe due to embedded transitions. This will become safe with dynamic configs. See diff for details. -- PiperOrigin-RevId: 143131700 MOS_MIGRATED_REVID=143131700
* Load JNI library on Windows from the runfiles tree as a fallbackGravatar Damien Martin-Guillerez2016-12-28
| | | | | | | | | | | | | | | | | This is the behavior of the UnixJniLoader. In order to do that, this change also moved the runfiles support on Windows in its own library that the WindowsJniLoader can use to load the JNI library from tests. Also add the JNI library on Windows to all test that use the JNI library on Unix. Fixes #2300. -- Change-Id: I2eb9207c3aa310d95912a48f64f676957c47cd34 Reviewed-on: https://cr.bazel.build/8045 PiperOrigin-RevId: 143114397 MOS_MIGRATED_REVID=143114397
* Expose to Skylark a merge() method for runfiles objectsGravatar Jon Brandvein2016-12-28
| | | | | | | | | This is a quick way to make it possible for Skylark rules to aggregate and pass on symlinks from their dependencies. -- PiperOrigin-RevId: 143111353 MOS_MIGRATED_REVID=143111353
* Expose apple.xcode_version() to skylark.Gravatar Chris Parsons2016-12-28
| | | | | | -- PiperOrigin-RevId: 143036358 MOS_MIGRATED_REVID=143036358
* Make depsets temporarily completely backward compatibleGravatar Vladimir Moskva2016-12-27
| | | | | | | | | `str(depset(...))` should return "set(...)" for now as some of the existing code may rely on it. -- PiperOrigin-RevId: 143014369 MOS_MIGRATED_REVID=143014369
* Add `depset` as an alias to `set` in SkylarkGravatar Vladimir Moskva2016-12-27
| | | | | | | | | | Renamed all occurrences of `set` to `depset`, added a `set` object constructor for (temporary) backward compatibility. `type(depset())` still temporarily returns "set", that will be changed in the future. RELNOTES: The `set` constructor is deprecated in favor of `depset` -- PiperOrigin-RevId: 142851587 MOS_MIGRATED_REVID=142851587
* Introduce --apple_crosstool_top, which sets the crosstool for sources in ↵Gravatar Cal Peyser2016-12-23
| | | | | | | | objc_*/apple_*/ios_* targets and their dependencies. -- PiperOrigin-RevId: 142793925 MOS_MIGRATED_REVID=142793925
* Expose ios_device attributes to Skylark.Gravatar Googler2016-12-23
| | | | | | -- PiperOrigin-RevId: 142784138 MOS_MIGRATED_REVID=142784138
* Don't ship a JDK to native singlejar actionsGravatar Liam Miller-Cushon2016-12-23
| | | | | | | | and update TODO about removing support for Java singlejar. -- PiperOrigin-RevId: 142778715 MOS_MIGRATED_REVID=142778715
* Do not crash when there's an error in the rule.Gravatar Carmi Grushko2016-12-23
| | | | | | | | | | | In ProtoCompileActionBuilder.registerActions(), we check for rule errors immediately after retrieving the value of :proto_compiler. However, this picks-up existing errors, not necessarily from retrieving the value of :proto_compiler. -- PiperOrigin-RevId: 142777231 MOS_MIGRATED_REVID=142777231
* RELNOTES[NEW]: Add transitive proguard_specs when android_sdk.aidl_lib is ↵Gravatar Googler2016-12-22
| | | | | | | | specified -- PiperOrigin-RevId: 142768089 MOS_MIGRATED_REVID=142768089
* Rename toolchain_flags to legacy_link_flags build variableGravatar Marcel Hlopko2016-12-22
| | | | | | -- PiperOrigin-RevId: 142767245 MOS_MIGRATED_REVID=142767245
* Rollback of commit 87fd5baeaa3f983bbec0c0dbc7b16eb52cf2267f.Gravatar Tobias Werth2016-12-22
| | | | | | -- PiperOrigin-RevId: 142758502 MOS_MIGRATED_REVID=142758502
* Move hardcoded toolchain linker flags to CROSSTOOLGravatar Marcel Hlopko2016-12-22
| | | | | | | | | | | | | This cl introduces another build variable: toolchain_flags and updates all the affected crosstools (those which started using action_configs, because the defaults from CppLinkActionConfigs are not applied then). This build variable is a requirement for follow-up refactoring exposing param_files build variable. With toolchain_flags and param_files we will have full control over flags placement on the link command line. -- PiperOrigin-RevId: 142741060 MOS_MIGRATED_REVID=142741060
* Move hardcoded -L linker flags to CROSSTOOLGravatar Marcel Hlopko2016-12-22
| | | | | | | | | | | This cl introduces another build variable: library_search_directories, removes hardcoded -L generation from blaze and updates all the affected crosstools (those which started using action_configs, because the defaults from CppLinkActionConfigs are not applied then). -- PiperOrigin-RevId: 142738674 MOS_MIGRATED_REVID=142738674
* Exposes the Android split transition configuration to Skylark.Gravatar Alex Humesky2016-12-22
| | | | | | -- PiperOrigin-RevId: 142709934 MOS_MIGRATED_REVID=142709934
* Stop passing --no-locals to dx for coverage buildsGravatar Liam Miller-Cushon2016-12-22
| | | | | | | | | This caused problems with Emma, but we have since migrated to JaCoCo which has better support for local variable tables. -- PiperOrigin-RevId: 142705846 MOS_MIGRATED_REVID=142705846
* Introduce --apple_crosstool_top, which sets the crosstool for sources in ↵Gravatar Cal Peyser2016-12-22
| | | | | | | | objc_*/apple_*/ios_* targets and their dependencies. -- PiperOrigin-RevId: 142702735 MOS_MIGRATED_REVID=142702735
* Rollback AppleCrosstoolChangeGravatar Cal Peyser2016-12-22
| | | | | | -- PiperOrigin-RevId: 142692398 MOS_MIGRATED_REVID=142692398
* Rollback of commit 87532156cf3ed7b66c6db5cb1e57dff7424031ab.Gravatar Kristina Chodorow2016-12-22
| | | | | | | | *** Reason for rollback *** -- PiperOrigin-RevId: 142691907 MOS_MIGRATED_REVID=142691907
* Make StringCanonicalizer use BlazeInterners rather than InternersGravatar Shreya Bhattarai2016-12-22
| | | | | | -- PiperOrigin-RevId: 142686266 MOS_MIGRATED_REVID=142686266
* Move the descriptorset output to the ProtoSourcesProvider and expose it to ↵Gravatar Googler2016-12-22
| | | | | | | | | | | | | skylark. This does mean that the type name 'ProtoSourcesProvider' is a little inaccurate, since descriptorSet() is an output. Alternatively we could expose the DescriptorSetProvider to skylark. RELNOTES: expose proto_library descriptor set to skylark via <dep>.proto.descriptor_set -- PiperOrigin-RevId: 142680666 MOS_MIGRATED_REVID=142680666
* cc_proto_library can build proto_library's from remote repos.Gravatar Carmi Grushko2016-12-22
| | | | | | -- PiperOrigin-RevId: 142676227 MOS_MIGRATED_REVID=142676227
* Introduce --apple_crosstool_top, which sets the crosstool for sources in ↵Gravatar Cal Peyser2016-12-22
| | | | | | | | objc_*/apple_*/ios_* targets and their dependencies. -- PiperOrigin-RevId: 142673622 MOS_MIGRATED_REVID=142673622
* proto_library can depend on proto_library's from external repos.Gravatar Carmi Grushko2016-12-22
| | | | | | | | Fixes https://github.com/bazelbuild/bazel/issues/2039. -- PiperOrigin-RevId: 142672678 MOS_MIGRATED_REVID=142672678
* Bazel client: add comments, delete dead codeGravatar Laszlo Csomor2016-12-22
| | | | | | | | | | In this change: - add TODOs and comments - inline blaze::ExitImmediately at call sites -- PiperOrigin-RevId: 142671757 MOS_MIGRATED_REVID=142671757
* Windows JNI: ensure JNI is loaded for getLongPathGravatar Laszlo Csomor2016-12-21
| | | | | | -- PiperOrigin-RevId: 142670226 MOS_MIGRATED_REVID=142670226
* Move some classes to lib.exec in preparation for layering enforcementGravatar Ulf Adams2016-12-21
| | | | | | | | | | | | This change is part of the mu-bazel effort, which aims to build a minimally useful Bazel binary with most extraneous functionality removed. As part of that, we want to enforce layering of packages. In particular, lib.actions must not depend on lib.rules or lib.exec. lib.rules must not depend on lib.exec. Moving these classes is a necessary step to enforce that layering. -- PiperOrigin-RevId: 142668172 MOS_MIGRATED_REVID=142668172
* Remove --experimental_disable_native_swift_rules flag.Gravatar Dmitry Shevchenko2016-12-21
| | | | | | -- PiperOrigin-RevId: 142666176 MOS_MIGRATED_REVID=142666176
* Allow url & output arguments to be namedGravatar Kristina Chodorow2016-12-21
| | | | | | | | This makes the skylark repository rules a little more flexible. -- PiperOrigin-RevId: 142663731 MOS_MIGRATED_REVID=142663731
* Bazel client, Windows: implement ReadFileGravatar Laszlo Csomor2016-12-21
| | | | | | | | | | | | | | | | Implement blaze_util::ReadFile on top of the ::ReadFile Windows API function. Also implement blaze_util::AsWindowsPath so we can convert MSYS paths to Windows widechar paths. Add tests. See https://github.com/bazelbuild/bazel/issues/2107 -- PiperOrigin-RevId: 142659955 MOS_MIGRATED_REVID=142659955
* Include ObjcProvider in generated Skylark documentation.Gravatar Florian Weikert2016-12-21
| | | | | | | | Fixes #1768 -- PiperOrigin-RevId: 142654511 MOS_MIGRATED_REVID=142654511
* Bazel client: remove blaze_util::WhichGravatar Laszlo Csomor2016-12-21
| | | | | | | | | This is only used in blaze_util_linux so move the method there. -- PiperOrigin-RevId: 142652521 MOS_MIGRATED_REVID=142652521