aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main
diff options
context:
space:
mode:
authorGravatar Vladimir Moskva <vladmos@google.com>2016-12-27 09:47:19 +0000
committerGravatar Damien Martin-Guillerez <dmarting@google.com>2016-12-27 10:03:45 +0000
commit98b7c0f7da1919b2fb6c18993441bb3f51845bf6 (patch)
treeb9a880c941d6cb880730fbd7f123acb836900639 /src/main
parentd200dafb29ba901ca8afb88d31b973fed9d5f725 (diff)
Make depsets temporarily completely backward compatible
`str(depset(...))` should return "set(...)" for now as some of the existing code may rely on it. -- PiperOrigin-RevId: 143014369 MOS_MIGRATED_REVID=143014369
Diffstat (limited to 'src/main')
-rw-r--r--src/main/java/com/google/devtools/build/lib/syntax/SkylarkNestedSet.java6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/syntax/SkylarkNestedSet.java b/src/main/java/com/google/devtools/build/lib/syntax/SkylarkNestedSet.java
index 6fc5c8bf13..fc78da5385 100644
--- a/src/main/java/com/google/devtools/build/lib/syntax/SkylarkNestedSet.java
+++ b/src/main/java/com/google/devtools/build/lib/syntax/SkylarkNestedSet.java
@@ -48,8 +48,8 @@ import javax.annotation.Nullable;
+ "s = s | depset([4, 5]) # s == {1, 2, 3, {4, 5}}\n"
+ "other = depset([\"a\", \"b\", \"c\"], order=\"compile\")</pre>"
+ "Note that in these examples <code>{..}</code> is not a valid literal to create depsets. "
- + "Sets have a fixed generic type, so <code>set([1]) + [\"a\"]</code> or "
- + "<code>set([1]) + depset([\"a\"])</code> results in an error.<br>"
+ + "Depsets have a fixed generic type, so <code>depset([1]) + [\"a\"]</code> or "
+ + "<code>depset([1]) + depset([\"a\"])</code> results in an error.<br>"
+ "Elements in a depset can neither be mutable or be of type <code>list</code>, "
+ "<code>struct</code> or <code>dict</code>.<br>"
+ "When aggregating data from providers, depsets can take significantly less memory than "
@@ -267,7 +267,7 @@ public final class SkylarkNestedSet implements Iterable<Object>, SkylarkValue, S
@Override
public void write(Appendable buffer, char quotationMark) {
- Printer.append(buffer, "depset(");
+ Printer.append(buffer, "set(");
Printer.printList(buffer, this, "[", ", ", "]", null, quotationMark);
Order order = getOrder();
if (order != Order.STABLE_ORDER) {