| Commit message (Collapse) | Author | Age |
|
|
|
|
| |
--
MOS_MIGRATED_REVID=94274751
|
|
|
|
|
|
|
| |
thread pool.
--
MOS_MIGRATED_REVID=94236393
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=94071970
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=93881974
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
coarsely checking for duplicates *anywhere*, e.g.:
select({':a': ['a.cc'], ':b': ['a.cc']}) + select({':a': ['b.cc'], ':b': ['b.cc']})
would fail. But this case is okay because these duplicates are in mutually
exclusive select paths (so they could never appear together anyway).
The new checking logic is:
- Duplicates can appear in different paths of the same select.
- Duplicates can *not* appear within the same path of a select.
- Duplicates can *not* appear across multiple selects (no matter what path -
this is still stricter than we need to be, but there's no strong case
for refining this case now).
--
MOS_MIGRATED_REVID=93447979
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
every possible value an attribute can take) for attributes with
multiple selects:
Given
attr = select({':a': 'w', ':b': 'x'}) + select({':a': 'y', ':b': 'z'}
the naive approach is to combine every possible value of the first select
with every possible value of the second select (producing 4 possible values
from 2^2 visitations). But since these selects have the same exact
conditions, only two values are actually possible ("wy", "xz") from 2
visitations.
This change efficiently considers that case. More generally, given n
concatenated selects with the same conditions, it brings evaluation time
down from O(2^n) to O(n) (assuming two conditions per select). It also
works for partial matches: given a concatenation of 6 selects where
1, 3, and 5 have the same conditions and 2, 4, and 6 have the same conditions,
evaluation time goes from O(2^6) to O(2^2).
--
MOS_MIGRATED_REVID=93325787
|
|
|
|
|
|
|
|
|
| |
'x{key}x'.format(key = 2) == 'x2x'
It is a very simplified version of the Python format.
--
MOS_MIGRATED_REVID=93130656
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=93026026
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=92934993
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=92715161
|
|
|
|
|
|
|
| |
Last step in refactoring of Skylark builtin functions.
--
MOS_MIGRATED_REVID=91796746
|
|
|
|
|
|
|
| |
Fixes #87.
--
MOS_MIGRATED_REVID=91784426
|
|
|
|
|
|
|
|
| |
Replace the uses of AbstractFunction, MixedModeFunction,
SkylarkFunction and SimpleSkylarkFunction by BuiltinFunction.
--
MOS_MIGRATED_REVID=91763158
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=91713784
|
|
|
|
|
|
|
|
| |
This simplifies the code a little, and prepares for properly
serializing ExternalPackage.
--
MOS_MIGRATED_REVID=91673213
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=91603959
|
|
|
|
|
|
|
| |
It appears to be unused. Use an explicit 'if' instead.
--
MOS_MIGRATED_REVID=91581070
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=91573102
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=91407816
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=91322217
|
|
|
|
|
|
|
| |
This is now not called on the regular build path except for computed defaults.
--
MOS_MIGRATED_REVID=91306062
|
|
|
|
|
|
|
| |
We need only a set of symbols, types are not used anymore.
--
MOS_MIGRATED_REVID=91299566
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=91288032
|
|
|
|
|
|
|
|
|
| |
multiple selects run the risk of exponential value growth, so we shouldn't
request a full iteration of possible values unless that's really what the
caller needs.
--
MOS_MIGRATED_REVID=91118257
|
|
|
|
|
|
|
| |
We don't need to store object methods, just global values.
--
MOS_MIGRATED_REVID=91094780
|
|
|
|
|
|
|
| |
Type information for methods is not needed anymore.
--
MOS_MIGRATED_REVID=91088042
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
change, the following syntax:
deps = [':always'] + select({':a': [':adep'], ':b': [':bdep']})
or
deps = select({':a': [':adep'], ':b': [':bdep']})
+ select({':c': [':cdep'], ':d': [':ddep']})
works.
--
MOS_MIGRATED_REVID=91016337
|
|
|
|
|
|
|
| |
SkylarkType.castMap() a little.
--
MOS_MIGRATED_REVID=90988088
|
|
|
|
|
|
|
|
|
|
| |
Clean up related to Skylark builtin functions.
Replace "hidden" field of some annotations with a "documented" field
(with reversed semantics).
--
MOS_MIGRATED_REVID=90827020
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=90707320
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=90616271
|
|
|
|
|
|
|
| |
Fixes #91.
--
MOS_MIGRATED_REVID=90185784
|
|
|
|
|
|
|
| |
HashMultimap provides no guarantee on the iteration order.
--
MOS_MIGRATED_REVID=90153110
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=90151316
|
|
|
|
|
|
|
| |
the fact that a valid Target exists, and instead request it directly from its Package.
--
MOS_MIGRATED_REVID=90107670
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=90081310
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=90061800
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=90004683
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89962232
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89957248
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89740455
|
|
|
|
|
|
|
|
|
|
|
|
| |
PackageDeserializer: handle null-value attributes (single-value attributes with
no value setting) without crashing.
Without this change, attributes with computed defaults can crash on serialization
because RawAttributeMapper.isNotNull isn't smart enough to check *indirect*
configurable attributes that the computed attribute depends on.
--
MOS_MIGRATED_REVID=89599145
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89483786
|
|
|
|
|
|
|
| |
these two versions of query consistent we need to add additional edges to the target that contains aspects, instead of adding it to the target that was in direct deps of the original one.
--
MOS_MIGRATED_REVID=89483301
|
|
|
|
|
|
|
| |
of null values).
--
MOS_MIGRATED_REVID=89443545
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
serialization logic.
Among other things, this fixes an out-of-sync bug where
ProtoOutputFormatter's version knew how to handle configurable
attributes while PackageSerializer's version crashed.
The merged logic preserves ProtoOutputFormatter's semantics:
configurable attributes work, but their values are merged together
into a flattened list, so the original select structure can't be
reproduced later.
--
MOS_MIGRATED_REVID=89435116
|
|
|
|
|
|
|
|
|
| |
This syntax is broken under Eclipse.
For some reason this syntax is valid from BuildJar
but it is not compatible with Eclipse Java 8.
--
MOS_MIGRATED_REVID=89397040
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89386727
|
|
|
|
|
|
|
| |
native module.
--
MOS_MIGRATED_REVID=89309511
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89296560
|