aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/packages
diff options
context:
space:
mode:
authorGravatar Laurent Le Brun <laurentlb@google.com>2015-04-14 16:19:08 +0000
committerGravatar Han-Wen Nienhuys <hanwen@google.com>2015-04-15 16:17:42 +0000
commitdafaff48bf815a4290273a0941c5c40a55fbc200 (patch)
treef6bf9a60e48013af45a6b4bd4a3d00e746b6f8e8 /src/main/java/com/google/devtools/build/lib/packages
parent5590dc4259c3e850282f0916fb05d5aadc7ec861 (diff)
More ValidationEnvironment cleanup, remove SkylarkType.GLOBAL.
We don't need to store object methods, just global values. -- MOS_MIGRATED_REVID=91094780
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/packages')
-rw-r--r--src/main/java/com/google/devtools/build/lib/packages/MethodLibrary.java15
1 files changed, 2 insertions, 13 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/packages/MethodLibrary.java b/src/main/java/com/google/devtools/build/lib/packages/MethodLibrary.java
index 1239ba861f..be2ae1c184 100644
--- a/src/main/java/com/google/devtools/build/lib/packages/MethodLibrary.java
+++ b/src/main/java/com/google/devtools/build/lib/packages/MethodLibrary.java
@@ -1167,25 +1167,14 @@ public class MethodLibrary {
}
}
- private static void setupValidationEnvironment(
- Map<Function, SkylarkType> functions, Map<String, SkylarkType> result) {
- for (Map.Entry<Function, SkylarkType> function : functions.entrySet()) {
- String name = function.getKey().getName();
- result.put(name, SkylarkFunctionType.of(name, function.getValue()));
- }
- }
-
/**
* Collect global functions for the validation environment.
*/
- public static void setupValidationEnvironment(
- Map<SkylarkType, Map<String, SkylarkType>> builtIn) {
- Map<String, SkylarkType> global = builtIn.get(SkylarkType.GLOBAL);
-
+ public static void setupValidationEnvironment(Map<String, SkylarkType> builtIn) {
// TODO(bazel-team): To be simplified (we need only the names, not the types).
for (Map.Entry<Function, SkylarkType> function : skylarkGlobalFunctions.entrySet()) {
String name = function.getKey().getName();
- global.put(name, SkylarkFunctionType.of(name, function.getValue()));
+ builtIn.put(name, SkylarkFunctionType.of(name, function.getValue()));
}
}
}