aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/java_tools/buildjar
Commit message (Collapse)AuthorAge
* Explicitly cast ByteBuffer in clear() call to Buffer.Gravatar Tobias Werth2018-08-14
| | | | | | | | | | | | | This works around the following error: java.lang.NoSuchMethodError: java.nio.ByteBuffer.clear()Ljava/nio/ByteBuffer; at com.google.devtools.build.lib.profiler.Profiler$BinaryFormatWriter.run(Profiler.java:949) at java.lang.Thread.run(Thread.java:748) JDK 9 introduced an overloaded methods with covariant return type. Closes #5886. PiperOrigin-RevId: 208642556
* 'DumpPlatformClasspath' now dumps the current JDK's default platform classpathGravatar cushon2018-08-08
| | | | | | | | | | | instead of indirecting through javac's bootclasspath handling and attempting to pin to a particular source version. This is a stop-gap until we can just use javac's --release flag. Using the output of DumpPlatformClasspath as the bootclasspath for the default java_toolchain side-steps issues with @local_jdk (see #5744, #5594). PiperOrigin-RevId: 207890272
* Temporarily ignore some spurious diagnostics related to running javac9 on JDK 10Gravatar cushon2018-08-07
| | | | PiperOrigin-RevId: 207773685
* Remove uses of java_toolchain.encodingGravatar cushon2018-08-07
| | | | PiperOrigin-RevId: 207734653
* Tolerate empty bootclasspaths in VanillaJavaBuilderGravatar cushon2018-08-07
| | | | PiperOrigin-RevId: 207730551
* PiperOrigin-RevId: 207121273Gravatar cushon2018-08-02
|
* Quiet 'The following options were not recognized by any processor' warningsGravatar cushon2018-07-30
| | | | PiperOrigin-RevId: 206697829
* Skip strict deps suggested fix commands with strict deps disabledGravatar cushon2018-07-27
| | | | | | | instead of just skipping the add dep errors. RELNOTES: follow-up to https://github.com/bazelbuild/bazel/commit/1ac359743176e659e9c7472645e3142f3c44b9e8 PiperOrigin-RevId: 206350053
* Perform strict deps enforcement on compilations with attribution errorsGravatar cushon2018-07-26
| | | | | | | | | | | | | Reporting strict deps errors in addition to attribution errors is helpful particularly with code-generating annotation processors that may fail due to missing transitive deps. Currently those failures prevent add_dep suggestions from being emitted, making the problem harder to diagnose. The presence of other errors may prevent some SJD issues from being detected, but in theory should never lead to spurious SJD errors from being reported, so the additional errors should generally be helpful. PiperOrigin-RevId: 206261677
* Unconditionally run the SJD machinery, which is necessary for jdeps outputGravatar cushon2018-07-26
| | | | | | | | | | | | and just skip the diagnostics at the end if strict deps errors are disabled. This is necessary to javac-turbine, where we don't report strict deps errors (we rely on JavaBuilder for enforcement) but where we still want to emit jdeps. See also bazelbuild/rules_scala#559 PiperOrigin-RevId: 206257304
* Internal changeGravatar cushon2018-07-25
| | | | PiperOrigin-RevId: 206085005
* Kill the deps mapGravatar cushon2018-07-25
| | | | PiperOrigin-RevId: 206025645
* GenClass: Assume that prefixes that don't correspond to a known ↵Gravatar cushon2018-07-23
| | | | | | non-generated source are generated. PiperOrigin-RevId: 205756917
* Use the host javac for bootstrappingGravatar cushon2018-07-22
| | | | | | | | | | | now that the bootstrap build uses the VanillaJavaBuilder it is compatible with the host JDK's javac, and avoiding -Xbootclasspath/p makes the bootstrap build more compatible with JDK 9. See #5521 RELNOTES: N/A PiperOrigin-RevId: 205605294
* Bazel server, tools: ensure Writers are closedGravatar laszlocsomor2018-07-10
| | | | | | | | | | | | | | | | | | | | Follow-up to commit 09d20311d982606093ed881d779bb05a5ee70ed3. Use try-with-resources to ensure Writer objects are closed eagerly. Eagerly closing Writers avoids hanging on to file handles until the garbage collector finalizes the object, meaning Bazel on Windows (and other processes) can delete or mutate these files. Hopefully this avoids intermittent file deletion errors that sometimes occur on Windows. See https://github.com/bazelbuild/bazel/issues/5512 RELNOTES: none PiperOrigin-RevId: 203934471
* Update turbine's experimental dep fixing suggestionsGravatar cushon2018-06-28
| | | | PiperOrigin-RevId: 202577988
* Remove unused strict deps module parameter.Gravatar Googler2018-06-27
| | | | | RELNOTES: none PiperOrigin-RevId: 202404085
* Make sure we pass the correct -encoding options to javacGravatar cushon2018-06-26
| | | | PiperOrigin-RevId: 202162534
* Improve error message for invalid srcjar inputsGravatar cushon2018-06-17
| | | | | | | Fixes #5418 RELNOTES: N/A PiperOrigin-RevId: 200934846
* Make JavaBuilder use a unique coverage metadata directoryGravatar elenairina2018-06-08
| | | | | | | | | | | for each test instead of the same directory for all the tests. The previous implementation was using one directory for instrumenting the classes of a jar. For each each jar the metadata directory was deleted if it already existed. This is problematic for local execution when multiple tests are run in parallel because some threads will try to delete the directory and some will try to perform read/write operations on it. This is an important fix for Bazel coverage users. Fixes #4398. RELNOTES: Java coverage works now with multiple jobs. PiperOrigin-RevId: 199764483
* Format all bzl files with buildifierGravatar vladmos2018-06-01
| | | | | | This CL aslo enables a presubmit check for correct formatting of all bzl files in //third_party/bazel. PiperOrigin-RevId: 198857055
* Always use `/` as the path separator for jar entriesGravatar cushon2018-05-25
| | | | | | Fixes #5260 PiperOrigin-RevId: 198110476
* Clean up code that directly imports nested classes like Builder, Entry, etc.Gravatar jcater2018-05-02
| | | | PiperOrigin-RevId: 195090893
* Don't build Error Prone plugin during bootstrappingGravatar cushon2018-04-27
| | | | | | Follow-up to https://github.com/bazelbuild/bazel/commit/bdb75bba00dbe97e9bb99db04844096f135f59ad PiperOrigin-RevId: 194559167
* Normalize parameter name commentsGravatar cushon2018-04-27
| | | | PiperOrigin-RevId: 194512971
* Use VanillaJavaBuilder for bootstrappingGravatar cushon2018-04-26
| | | | PiperOrigin-RevId: 194504697
* Add support for native header outputs to VanillaJavaBuilderGravatar cushon2018-04-26
| | | | PiperOrigin-RevId: 194503531
* Remove use of bare Immutable{List,Map,Set} Builder classes.Gravatar jcater2018-04-19
| | | | | | Always use the more-qualified class name for clarity at the site of use. There are too many classes named Builder. PiperOrigin-RevId: 193579440
* Fix a crash in javac-turbine transitive classpath fallbackGravatar cushon2018-04-18
| | | | | | | This code was failing to reset the SJD plugin before falling back, which caused a reference to a JimFS Path in the original filesystem to leak. PiperOrigin-RevId: 193421565
* When normalizing -source and --release options, allow the last one to winGravatar cushon2018-04-13
| | | | | | | | | previously --release always took precedence. if/when Bazel defaults to using e.g. --release 9, legacy -source and -target javacopts should be respected. PiperOrigin-RevId: 192844963
* Process package-info annotations in Strict Java DepsGravatar cushon2018-04-13
| | | | PiperOrigin-RevId: 192837552
* Use jadep to fix missing dependencies in turbineGravatar cushon2018-04-13
| | | | PiperOrigin-RevId: 192802011
* Don't print empty add dep commandsGravatar cushon2018-04-11
| | | | PiperOrigin-RevId: 192539741
* Tolerate empty bootclasspaths in javac-turbineGravatar cushon2018-04-05
| | | | PiperOrigin-RevId: 191809494
* Clean up after b/72379900Gravatar cushon2018-03-16
| | | | PiperOrigin-RevId: 189380767
* Clean up whitespace in add_dep messagesGravatar cushon2018-03-15
| | | | PiperOrigin-RevId: 189225279
* Emit SJD errors even if we don't know the label of a dependencyGravatar cushon2018-03-14
| | | | | | Fixes bazelbuild/bazel#4846 PiperOrigin-RevId: 189123353
* Fix javac-turbine diagnostic formatting to include source positionGravatar cushon2018-03-12
| | | | PiperOrigin-RevId: 188799934
* Delete F5 JarDexer.Gravatar Googler2018-03-02
| | | | | | | | The only two remaining users are for JAR, so directly call into BazelJavaBuilder rather than through our multiplex tool. This requires opening the visibility of BazelJavaBuilder up to public. PiperOrigin-RevId: 187690855
* Change the strict deps plugin to read jar owner from manifest.Gravatar tomlu2018-02-28
| | | | | | | | | | | | | | | | | The plugin tries to read the following attributes: Target-Label: <label> Injecting-Rule-Kind: <rule kind> These are used instead of the jar owners passed to JavaBuilder from blaze. Any owners currently passed from blaze are now ignored. This CL also half-reverts the command line syntax for JavaBuilder and Turbine. It is now: --classpath <jar1> <jar2> ... --direct_dependencies <jar1> ... RELNOTES: None PiperOrigin-RevId: 187419469
* Remove support for --rule_kindGravatar cushon2018-02-22
| | | | | | now that Bazel no longer passes it. PiperOrigin-RevId: 186708415
* Automated rollback of commit 11cc89a27544311111473dc7a17522635c2b6e70.Gravatar eaftan2018-02-21
| | | | | | | | | | | | | | *** Reason for rollback *** Superceded by https://github.com/bazelbuild/bazel/commit/e734c479956df7a675c61f531d769609d3af3e5d *** Original change description *** JavaBuilder accepts a new --testonly argument to mark compilations of test code. Error Prone will use these to distinguish between test and production code, e.g. for enforcing @VisibleForTesting. PiperOrigin-RevId: 186520809
* Add --experimental_fix_deps_tool to JavaBuilderGravatar Googler2018-02-21
| | | | | RELNOTES: None PiperOrigin-RevId: 186494122
* Rewrite visibility handling for all java_toolsGravatar ulfjack2018-02-16
| | | | PiperOrigin-RevId: 185959149
* Use a diagnostic listener, and match diagnostic codes for the reduced ↵Gravatar cushon2018-02-14
| | | | | | classpath heuristic PiperOrigin-RevId: 185746460
* Remove deprecated rule_kind argument from Turbine and JavaBuilder.Gravatar cushon2018-02-14
| | | | | | Roll forward of unknown commit PiperOrigin-RevId: 185727344
* Accept --target_label, --injecting_rule_kind in JavaBuilder and Turbine.Gravatar tomlu2018-02-13
| | | | | | | | | | | The values (if present) are written into the manifest with this format: Target-Label: <label> Injecting-Rule-Kind: <kind> In the future, JavaBuilder will make sure of this instead of command line arguments to find owners for jars for its add_dep commands. PiperOrigin-RevId: 185557317
* Use a different date time when normalizing zip entriesGravatar cushon2018-02-12
| | | | | | Fixes #4614 PiperOrigin-RevId: 185474153
* Use a different date time when normalizing zip entriesGravatar cushon2018-02-12
| | | | PiperOrigin-RevId: 185419668
* Make some tests compatible with JDK 9Gravatar cushon2018-02-08
| | | | PiperOrigin-RevId: 185003013