| Commit message (Collapse) | Author | Age |
|
|
|
| |
PiperOrigin-RevId: 164066205
|
|
|
|
|
|
|
| |
Fix bug where a null value in the expansion text lead to a NullPointerException.
RELNOTES: None.
PiperOrigin-RevId: 164061496
|
|
|
|
|
|
|
| |
evaluation of the graph with a single constant version is expected
RELNOTES: None
PiperOrigin-RevId: 164059941
|
|
|
|
|
|
|
|
| |
methods in that interface.
RELNOTES: none
PiperOrigin-RevId: 164041648
|
|
|
|
|
|
|
|
|
| |
We now use a unified way to check provider requirements everywhere.
Reland of https://github.com/bazelbuild/bazel/commit/c32e1b1efcd703b3780de47fba62974123593d71.
RELNOTES: None.
PiperOrigin-RevId: 164038621
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 164031163
|
|
|
|
|
|
|
| |
ctor. This is completely wasteful in the common case of the PathFragment already being normalized.
RELNOTES: None
PiperOrigin-RevId: 164022960
|
|
|
|
|
|
|
| |
and Long.compare are correctly handled.
RELNOTES: None
PiperOrigin-RevId: 164018569
|
|
|
|
|
|
|
| |
String representation of ctx will soon be changed, ctx.label should be used
explicitly.
PiperOrigin-RevId: 164016232
|
|
|
|
| |
PiperOrigin-RevId: 164013246
|
|
|
|
|
|
|
|
|
|
|
|
| |
Problem:
- When you're using the osx crosstool, compilation of ObjC++ does not work because `wrapped_clang_pp` is not exposed.
Solution:
- Expose `wrapped_clang_pp` in the osx toolchain.
Closes #3270.
PiperOrigin-RevId: 164004043
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 163979668
|
|
|
|
|
|
|
|
|
| |
Also throw IllegalArgumentException instead of AssertionError.
A follow-up CL will look to eliminate the SkylarkMutable#checkMutable(Location, Environment) override in favor of checkMutable(Location, Mutability). This will make it easier to manipulate Skylark values in specialized contexts aside from normal evaluation.
RELNOTES: None
PiperOrigin-RevId: 163978262
|
|
|
|
|
|
| |
As suggested in readability review for https://github.com/bazelbuild/bazel/commit/2789c97149a1f253b659aa0f2401f44705a3258f. Ended up being a fair number of changes, but I think I got them all.
PiperOrigin-RevId: 163975846
|
|
|
|
|
|
|
|
| |
(https://user-images.githubusercontent.com/744228/28495342-609be784-6efe-11e7-8403-0f3c5e892b13.png)
Closes #3436.
PiperOrigin-RevId: 163968685
|
|
|
|
|
| |
RELNOTES: none
PiperOrigin-RevId: 163966473
|
|
|
|
|
|
|
|
| |
The "BUILD files" section in best-practices has been moved to skylark/build-style.
Closes #3470.
PiperOrigin-RevId: 163962064
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 163947365
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 163942164
|
|
|
|
| |
PiperOrigin-RevId: 163889699
|
|
|
|
|
|
|
| |
PrepareDepsOfPatternsValue#TargetPatternSequence
RELNOTES: None
PiperOrigin-RevId: 163883014
|
|
|
|
|
|
|
|
|
|
|
| |
This cl changes copts to be immutable (and changes addCopts methods into
setCopts, so it's simpler to reason about copts) and exposes copts as a build
variable. It also introduces CompileBuildVariablesTest, similar to
LinkBuildVariablesTest, to test that right build variables are exposed for right
actions.
RELNOTES: None.
PiperOrigin-RevId: 163876774
|
|
|
|
|
|
|
|
| |
In the TestSummary, also indicate the total number of cached actions.
Fixes #3435.
Change-Id: I5fb3f54f54a852b7cbeb58b03b50b042e5d26455
PiperOrigin-RevId: 163871517
|
|
|
|
|
|
|
|
|
| |
If a test fails to build, we obviously cannot run it.
Therefore, it does not make sense to have a summary of
the individual test runs.
Change-Id: I0445e7a58fc5c1f4feaa592a13da1c7f9c9be083
PiperOrigin-RevId: 163866309
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks depot b/64250728
*** Original change description ***
Use RequiredProviders to validate rule prerequisites in RuleContext.
We now use a unified way to check provider requirements everywhere.
RELNOTES: None.
PiperOrigin-RevId: 163862067
|
| |
|
|
|
|
|
|
|
| |
I.e., use an accessor for type inference. The EMPTY field will be made private in a future CL.
RELNOTES: None
PiperOrigin-RevId: 163843569
|
|
|
|
| |
PiperOrigin-RevId: 163840258
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 163838735
|
|
|
|
|
|
|
|
| |
Add a `select` so Bazel won't try to build
windows_jni.dll on Linux/MacOS.
RELNOTES: none
PiperOrigin-RevId: 163832982
|
|
|
|
|
|
|
|
|
|
| |
Adds back a compiler test empty .cc file. Seems to be an omission in https://github.com/bazelbuild/bazel/commit/65cda4f219e564ccb190b2992151658dfae9904
The _is_gold_supported check in unix_cc_configure.bzl always fails without this change, since the file it's checking with isn't created. Looks like there may be other effects through _add_option_if_supported, although I only noticed because apparently I have written linker-specific code.
Closes #3484.
PiperOrigin-RevId: 163832465
|
|
|
|
|
|
|
|
|
|
|
| |
Add support for setting up the LTO indexing step when the inputs
contain bitcode.
Added a python BuildViewTestCase that provokes this, as well as a
ThinLTO GoogleBuildIntegrationTestCase to the existing NativeDeps
testing.
PiperOrigin-RevId: 163827441
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows CROSSTOOL authors to add flags to all targets for which fission
is enabled, even when a compile action does not output split debug info.
For example, when building with ThinLTO, compiles are split into a frontend
compile, that does not generate split debug info, but still needs to include
debug info if fission is enabled (even in opt mode).
RELNOTES: None.
PiperOrigin-RevId: 163825563
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add flag --convert_lipo_to_thinlto, which allows builds with LLVM to use
ThinLTO when the user specifies LIPO + FDO flags; if that flag is not set, and
the user requests a build with LLVM, the compile will now fail.
Add an attribute supports_lipo to the DefaultCpuToolchain crosstool proto and
skip default toolchains that do not support LIPO when the user has specified
LIPO flags in the toolchain selection; this enables CROSSTOOL files to cause
an implicit fallback to a hybrid / LIPO toolchain when using an LLVM toolchain
as the default.
Add a CrosstoolBuilder to MockCcSupport and add a new method
setupCrosstoolFromScratch that allows unit tests to fully control the setup.
The other methods available in MockCcSupport will always load in a default
CROSSTOOL file and may show different unit test results depending on the
content of that file.
RELNOTES: None.
PiperOrigin-RevId: 163819246
|
|
|
|
|
|
|
|
| |
Remove Converters.ExistingPathListConverter, it
wasn't used anywhere.
RELNOTES: none
PiperOrigin-RevId: 163810436
|
|
|
|
|
|
|
| |
Fix http://ci.bazel.io/blue/organizations/jenkins/Global%2FTutorial/detail/Tutorial/52/pipeline/
RELNOTES: None
PiperOrigin-RevId: 163802763
|
|
|
|
| |
PiperOrigin-RevId: 163799447
|
|
|
|
|
|
|
| |
Also added basic tests.
Change-Id: I5861816bf116486e0ee365debd3dfbda131047f7
PiperOrigin-RevId: 163764257
|
|
|
|
|
|
|
|
|
| |
context.
Fixes #3428.
Change-Id: Ib3f45bc6856651cfb29d338d0b4480ba1dd77cea
PiperOrigin-RevId: 163760940
|
|
|
|
|
|
| |
Preparatory step to make the test stop using --test_filter, as this is moving out of the base build configuration.
PiperOrigin-RevId: 163737925
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks some iOS Photos targets: []
*** Original change description ***
Framework dependency subtraction uses runfiles path instead of full artifact path
RELNOTES: None.
PiperOrigin-RevId: 163732608
|
|
|
|
|
|
|
|
|
|
| |
I noticed that one of the exceptions that causes #2470 is
SocketTimeoutException. The outer exception handlers of
HttpConnector.connect have logic to handle such an exception, so just
let them propagate.
Change-Id: Ic87b678431178e296f14f1be34acf8024ddbfc19
PiperOrigin-RevId: 163732268
|
|
|
|
|
|
|
|
| |
Follows
https://docs.google.com/document/d/1aAIVWvHPERDz2cv_PCFGwr8dvh5FcAkENFoRsNS4clk/.
RELNOTES: None.
PiperOrigin-RevId: 163728291
|
|
|
|
|
|
|
|
| |
experimental_ui_test not being executable, causes test failures on
ci.bazel.build
RELNOTES: None.
PiperOrigin-RevId: 163726712
|
|
|
|
|
|
|
| |
We now use a unified way to check provider requirements everywhere.
RELNOTES: None.
PiperOrigin-RevId: 163710961
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 163703995
|
|
|
|
| |
PiperOrigin-RevId: 163701792
|
|
|
|
|
|
| |
...as they are actually useful when debugging.
PiperOrigin-RevId: 163698478
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a data-dependency on the windows_jni.dll from
the BusyBox in BUILD.tools, so the BusyBox in
@build_tools// can actually find it at runtime.
Also update the script that builds the .dll so
that it works if the source files have an
"external/bazel_tools/" prefix.
Related to https://github.com/bazelbuild/bazel/issues/3264
Change-Id: I005e9d2c00253a59d2cd5cc9f3a93528dc4d2e9e
PiperOrigin-RevId: 163691320
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Otherwise these envvars are not available to the
Java program and it can't load its runfiles.
I tested that this is necessary both on Linux and
Windows.
Related to https://github.com/bazelbuild/bazel/issues/3264
Change-Id: I2bd8eee0793b26aeedeafc6900f7854c816b5b14
PiperOrigin-RevId: 163688341
|