aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar laszlocsomor <laszlocsomor@google.com>2017-08-01 12:13:16 +0200
committerGravatar Dmitry Lomov <dslomov@google.com>2017-08-01 12:22:03 +0200
commit8db4454dbe103343d522a05bdd9f083b4cc13ff8 (patch)
treeec399531f9c4bf0b1a2cd7f39f18c4b0c212590f
parent08271dea6693eff165901f2d9fa8bd3ed789aa1c (diff)
Android BusyBox: remove dead code
Remove Converters.ExistingPathListConverter, it wasn't used anywhere. RELNOTES: none PiperOrigin-RevId: 163810436
-rw-r--r--src/test/java/com/google/devtools/build/android/ConvertersTest.java12
-rw-r--r--src/tools/android/java/com/google/devtools/build/android/Converters.java10
2 files changed, 0 insertions, 22 deletions
diff --git a/src/test/java/com/google/devtools/build/android/ConvertersTest.java b/src/test/java/com/google/devtools/build/android/ConvertersTest.java
index 0e7385171c..937435da67 100644
--- a/src/test/java/com/google/devtools/build/android/ConvertersTest.java
+++ b/src/test/java/com/google/devtools/build/android/ConvertersTest.java
@@ -15,9 +15,7 @@ package com.google.devtools.build.android;
import static com.google.common.truth.Truth.assertThat;
-import com.google.common.base.Joiner;
import com.google.devtools.build.android.Converters.ExistingPathConverter;
-import com.google.devtools.build.android.Converters.ExistingPathListConverter;
import com.google.devtools.build.android.Converters.ExistingPathStringDictionaryConverter;
import com.google.devtools.build.android.Converters.PathConverter;
import com.google.devtools.build.android.Converters.PathListConverter;
@@ -99,16 +97,6 @@ public final class ConvertersTest {
}
@Test
- public void testExisingPathListConverter() throws Exception {
- String arg = "non-existing";
- ExistingPathListConverter converter = new ExistingPathListConverter();
- Path existingFile = tmp.newFile("existing").toPath();
- expected.expect(OptionsParsingException.class);
- expected.expectMessage(String.format("%s is not a valid path: it does not exist.", arg));
- converter.convert(Joiner.on(SEPARATOR).join(existingFile.toString(), arg));
- }
-
- @Test
public void testStringDictionaryConverter_emptyEntry() throws Exception {
StringDictionaryConverter converter = new StringDictionaryConverter();
expected.expect(OptionsParsingException.class);
diff --git a/src/tools/android/java/com/google/devtools/build/android/Converters.java b/src/tools/android/java/com/google/devtools/build/android/Converters.java
index 01342ac7df..80bf6652ad 100644
--- a/src/tools/android/java/com/google/devtools/build/android/Converters.java
+++ b/src/tools/android/java/com/google/devtools/build/android/Converters.java
@@ -329,16 +329,6 @@ public final class Converters {
}
}
- /**
- * Validating converter for a list of Paths. The list is considered valid if all Paths resolve to
- * a file that exists.
- */
- public static class ExistingPathListConverter extends PathListConverter {
- public ExistingPathListConverter() {
- super(true);
- }
- }
-
// Commas that are not escaped by a backslash.
private static final String UNESCAPED_COMMA_REGEX = "(?<!\\\\)\\,";
// Colons that are not escaped by a backslash.