aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Update to javac9-r3297Gravatar Liam Miller-Cushon2016-12-08
| | | | | | -- PiperOrigin-RevId: 141396618 MOS_MIGRATED_REVID=141396618
* Remove BUILD files for checked in Android apksigner.Gravatar Adam Michael2016-12-07
| | | | | | | | We are no longer using the checked-in apksigner jar, instead we are now reading this JAR from the Android build tools. A follow-up change will remove the actual JAR. One small step towards making the Bazel binary smaller :) -- PiperOrigin-RevId: 141355143 MOS_MIGRATED_REVID=141355143
* Clean up after transition of java_xxx_proto_library rules to proto-toolchains.Gravatar Carmi Grushko2016-12-07
| | | | | | | | | This hardcodes usage of proto-toolchains, which triggers strict-proto-deps. Since strict-proto-deps relies on a proto-compiler feature which doesn't exist yet, I've also changed the default of --strict_proto_deps to 'default', which won't trigger the check unless specifically requested. -- PiperOrigin-RevId: 141347426 MOS_MIGRATED_REVID=141347426
* Rollback of commit a5312cdfe3dee6d34a32592c00d80e8142f89615.Gravatar Cal Peyser2016-12-07
| | | | | | | | | | | | | | | *** Reason for rollback *** Under --experimental_objc_library, breaks objc_library targets with empty sources. *** Original change description *** Better error message for experimental_objc_library targets built with a crosstool that does not support objc. -- PiperOrigin-RevId: 141344598 MOS_MIGRATED_REVID=141344598
* Refactor JavaHeaderCompileAction command line and input collectionGravatar Liam Miller-Cushon2016-12-07
| | | | | | | | | Make the distinction between transitive and direct inputs clearer, and decouple command line construction from the use of params files. -- PiperOrigin-RevId: 141341256 MOS_MIGRATED_REVID=141341256
* Skip constraint checking on generated sources with null generating rules.Gravatar Greg Estren2016-12-07
| | | | | | | | | | Null generating rules shouldn't actually happen. That's its own bug that needs its own attention. This change is just a workaround to prevent NullPointerExceptions when the bug hits. -- PiperOrigin-RevId: 141329624 MOS_MIGRATED_REVID=141329624
* Description redacted.Gravatar Kristina Chodorow2016-12-07
| | | | | | -- PiperOrigin-RevId: 141325412 MOS_MIGRATED_REVID=141325412
* Use proto_lang_toolchain() directly, now that it is released in Bazel 0.4.1.Gravatar Carmi Grushko2016-12-07
| | | | | | -- PiperOrigin-RevId: 141322619 MOS_MIGRATED_REVID=141322619
* Pass isExternal field to blaze ide info protoGravatar Googler2016-12-07
| | | | | | | | | | | | | | | | Roll forward after fixing tests. Changes from rolled-back CL: Native aspect now determines 'isExternal' identically to skylark aspect. RepositoryName.isMain was unreliable (at least in testing environment), because unknown repos (occurring due to some race condition) are flagged as being in the 'default' repo, distinct from the 'main' repo. We now bypass RepositoryName entirely, and use the same label string heuristic as used in the Skylark aspect. -- PiperOrigin-RevId: 141314075 MOS_MIGRATED_REVID=141314075
* Provide deterministic order for split configured deps (roll forward part 2).Gravatar Greg Estren2016-12-07
| | | | | | | | | | | | | | | | | | | | | Also: - Make ConfiguredTargetFunction.getDynamicConfigurations more readable. - Add a bit more testing coverage for configured dep resolution. This is a roll forward of commit 7505d94c19727e3100ac5e16a960bff2cb324f23. The original changed failed for two reasons: 1) Windows-only: "ppc" wasn't recognized as a valid cpu: https://github.com/bazelbuild/bazel/issues/2191 2) Bazel requires android_binary's "manifest" attribute to be "AndroidManifest.xml": https://www.google.com/url?sa=D&q=http%3A%2F%2Fci.bazel.io%2Fjob%2Fbazel-tests%2FBAZEL_VERSION%3DHEAD%2CPLATFORM_NAME%3Dubuntu_15.10-x86_64%2FlastCompletedBuild%2FtestReport%2F This version uses "armeabi-v7a" instead of "ppc" and "AndroidManifest.xml" in the splitDeps test. -- PiperOrigin-RevId: 141313454 MOS_MIGRATED_REVID=141313454
* Global cleanup change.Gravatar Googler2016-12-07
| | | | | | -- PiperOrigin-RevId: 141307853 MOS_MIGRATED_REVID=141307853
* Remove apksigner from Bazel.Gravatar Adam Michael2016-12-07
| | | | | | | | | We were using this JAR in the interim until it was released in the Android SDK build tools. As of build tools version 24.0.3, it is released and Bazel now uses that JAR. Change-Id: I927480153aa45b71d7fbde995f9deae99c759f86 RELNOTES: None
* Release 0.4.2 (2016-12-02)Gravatar Bazel Release System2016-12-07
| | | | | | | | | | | | | | | | | | | | | | | Baseline: 6331a94 Cherry picks: + 7b835d9: Do not patch WORKSPACE in the release process Incompatible changes: - Callback functions in Skylark no longer support the cfg parameter. This is a cleanup and only affects the signatures of callbacks, since the parameter hasn't been set since September 2016. Important changes: - Alias proto_library's produce a descriptor set that contains all srcs of its dependencies. - proto_library supports strict proto deps. - Top level @androidsdk support library targets have been replaced by @androidsdk//<group id>:<artifact id>-<version> for Android SDK Support and Google Play Services libraries.
* Release 0.4.2 (2016-11-30)Gravatar Bazel Release System2016-12-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Baseline: 2a26c3c Cherry picks: + a79581e: Add gpu compile support to MSVC wrapper script + 4c67807: Improve reliability/performance of Bazel downloads + ed7ced0: Support multiple mirror URLs for external repos Incompatible changes: - Callback functions in Skylark no longer support the cfg parameter. This is a cleanup and only affects the signatures of callbacks, since the parameter hasn't been set since September 2016. Important changes: - Prevent spurious recompiles, e.g. with changing --test_arg. - proto_library now produces a descriptor set, when built on the command-line. - Add ctx.coverage_instrumented function to Skylark, to indicate whether a specific targets should be instrumented for code coverage data collection. - Use --loading_phase_threads to control the number of threads used during the loading/analysis phase. - Structs in Skylark are tested for structural equality instead of reference equality. - Skylark implementations of http_archive, new_http_archive, and http_file. - Labels like "@foo//:foo" can now be written as "@foo" in build files - Alias proto_library's produce a descriptor set that contains all srcs of its dependencies. - External downloads now retry with exponential backoff and support gzip content-encoding. - proto_library supports strict proto deps. - A urls attribute has been added to repository rules to support multiple mirror URLs for reliably downloading files. - Top level @androidsdk support library targets have been replaced by @androidsdk//<group id>:<artifact id>-<version> for Android SDK Support and Google Play Services libraries.
* Remove varargs Fingerprint#addStringsGravatar Michajlo Matijkiw2016-12-07
| | | | | | | | Doesn't add much on top of the Iterable version in the current state of things, and it is too easy to confuse with addString. -- PiperOrigin-RevId: 141300940 MOS_MIGRATED_REVID=141300940
* Fix #2199: bazel_worker_test fails with syntax error on Darwin.Gravatar Philipp Wollermann2016-12-07
| | | | | | -- PiperOrigin-RevId: 141300487 MOS_MIGRATED_REVID=141300487
* Improved support for /MD and /MT in MSVC [#2120]Gravatar Javier Dehesa2016-12-07
| | | | | | | | | | | | | | | | | msvc_tools.py now prefers the last /MT / /MD option given; if none, /MD is preferred. Additionally, the behaviour of the copt -g has been improved to enforce the debug version of the user-selected runtime, not necessarily /MTd. Issue: #2120 Closes #2141. -- Reviewed-on: https://github.com/bazelbuild/bazel/pull/2141 PiperOrigin-RevId: 141294930 MOS_MIGRATED_REVID=141294930
* move MakeDirectories() into file_platform.hGravatar Thiago Farina2016-12-07
| | | | | | | | | | | | | | This way we can remove the dependency on blaze_util (which is Bazel's client specific) from singlejar. This work was made possible by commit 49970e0136d0: ("Bazel client: platform-specific {Read,Write}File"). -- Change-Id: I6e95fb9119a271e4d48cbe2eefc1d5354ee188aa Reviewed-on: https://cr.bazel.build/7650 PiperOrigin-RevId: 141294165 MOS_MIGRATED_REVID=141294165
* Use correct comment type (# instead of //) in Skylark cookbook example.Gravatar Florian Weikert2016-12-07
| | | | | | -- PiperOrigin-RevId: 141293305 MOS_MIGRATED_REVID=141293305
* Add coverage support for java test.Gravatar Yue Gan2016-12-07
| | | | | | | | (series 4/4 of open-sourcing coverage command for java test) -- PiperOrigin-RevId: 141292977 MOS_MIGRATED_REVID=141292977
* Windows: Fix cuda option parsing when /Od is passedGravatar Yun Peng2016-12-07
| | | | | | | | | | When not using -c opt, /Od will be passed instead of /O2 -- Change-Id: I693020d51d45e054e10a94a5e1754b89c44c7ff4 Reviewed-on: https://cr.bazel.build/7670 PiperOrigin-RevId: 141291490 MOS_MIGRATED_REVID=141291490
* decide whether to strip binaries only onceGravatar Marcel Hlopko2016-12-07
| | | | | | | | | | | | CppConfiguration's constructor was computing whether to strip binaries twice: once to fill the stripBinaries member and once to fill a local variable that shadowed the member. Doing only the former suffices. -- Change-Id: I20f61e71572da79e0ec315b01c04b13f4fb14960 Reviewed-on: https://cr.bazel.build/6390 PiperOrigin-RevId: 141285267 MOS_MIGRATED_REVID=141285267
* move linker flags from compiler_flags to linker_flags; fix option syntaxGravatar Marcel Hlopko2016-12-07
| | | | | | | | | | | | | | | | | "-Wl,-z,-relro,-z,now" was in compiler_flags, which is not very useful because compiler_flags are not passed to the compilation driver for link commands. "-z -relro" is not even a valid linker flag set because of the spurious leading dash on "relro": $ gold -z -relro gold: -relro: unknown -z option -- Change-Id: Ic987312b7dec5cc68e7195b5ea88945653a93200 Reviewed-on: https://cr.bazel.build/7570 PiperOrigin-RevId: 141282978 MOS_MIGRATED_REVID=141282978
* Remove bindings created by android_sdk_repository.Gravatar Adam Michael2016-12-07
| | | | | | | | | | These targets no longer exist because the JARs they referenced are no longer shipped in the Android SDK. RELNOTES: Android SDK external bindings for support libraries, e.g. //external:android/appcompat_v4, are removed because the support library JARs that they referenced no longer ship with the Android SDK. -- PiperOrigin-RevId: 141263303 MOS_MIGRATED_REVID=141263303
* Description redacted.Gravatar David Chen2016-12-07
| | | | | | -- PiperOrigin-RevId: 141233274 MOS_MIGRATED_REVID=141233274
* Rollback of commit 14e35546302a48d1074bc2456ef4d63c27c9d3a1.Gravatar Adam Michael2016-12-07
| | | | | | | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Rollforward with fixes to android_integration_test.sh. The test now uses the new syntax for the Support Library AARs. All CIs that have been created since last December should have this library installed due to https://github.com/bazelbuild/continuous-integration/blob/master/mac/mac-android.sh#L36. *** Original change description *** Automated [] rollback of commit f699b502ef6a57dc68570486191ad1c318e8fd1b. *** Reason for rollback *** Breaks android_integration_test.sh which relies on the old targets. I don't have time to update the test to use the new targets at the moment, so rolling the change back for now. https://github.com/bazelbuild/bazel/issues/2159 RELNOTES: -- PiperOrigin-RevId: 141233182 MOS_MIGRATED_REVID=141233182
* Update docs to simplify the specification of Xcode/SDK versioning.Gravatar Dave MacLachlan2016-12-07
| | | | | | -- PiperOrigin-RevId: 141220359 MOS_MIGRATED_REVID=141220359
* Rollback of commit 12d766df10fbc5eba16ec1e6c20c8cd85f9c616f.Gravatar Damien Martin-Guillerez2016-12-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Still fails bazel-tests See http://ci.bazel.io/job/bazel-tests/BAZEL_VERSION=HEAD,PLATFORM_NAME=ubuntu_15.10-x86_64/lastCompletedBuild/testReport/ for instance *** Original change description *** Provide deterministic order for split configured deps (roll forward) Also: - Make ConfiguredTargetFunction.getDynamicConfigurations more readable. - Add a bit more testing coverage for configured dep resolution. This is a roll forward of commit 7505d94c19727e3100ac5e16a960bff2cb324f23. The original changed failed on Windows because "ppc" wasn't recognized as a valid cpu: https://github.com/bazelbuild/bazel/issues/2191 This version uses "armeabi-v7a" instead. -- PiperOrigin-RevId: 141212457 MOS_MIGRATED_REVID=141212457
* Rollforward of "Split ObjcProvider.framework_dir into static and dynamic ↵Gravatar Chris Parsons2016-12-06
| | | | | | | | | | framework directories." This is a rollforward of the first attempt, which broke swift rules. -- PiperOrigin-RevId: 141210876 MOS_MIGRATED_REVID=141210876
* Add some basic documentation to grpc protocolGravatar Michajlo Matijkiw2016-12-06
| | | | | | | | Nothing too detailed, a basic outline. -- PiperOrigin-RevId: 141205173 MOS_MIGRATED_REVID=141205173
* Attach J2ObjcAspect to java_proto_library. This is needed for J2ObjcAspect ↵Gravatar Rumou Duan2016-12-06
| | | | | | | | to reach the dependent proto_library rules, whose sources will be used to generate J2ObjC protos. -- PiperOrigin-RevId: 141187718 MOS_MIGRATED_REVID=141187718
* Windows JNI library: prepare for widechar WinAPIGravatar Laszlo Csomor2016-12-06
| | | | | | | | | | | | | | | | | | This change: - renames windows_error_handling.* to windows_util.* - moves most stuff except for the JNI method implementations into the new windows_util namespace - implements a jstring to wchar string converter - uses GetFileAttributesW in windows_file_operations.cc See https://github.com/bazelbuild/bazel/issues/2181 -- PiperOrigin-RevId: 141187291 MOS_MIGRATED_REVID=141187291
* Provide deterministic order for split configured deps (roll forward)Gravatar Greg Estren2016-12-06
| | | | | | | | | | | | | | | | | Also: - Make ConfiguredTargetFunction.getDynamicConfigurations more readable. - Add a bit more testing coverage for configured dep resolution. This is a roll forward of commit 7505d94c19727e3100ac5e16a960bff2cb324f23. The original changed failed on Windows because "ppc" wasn't recognized as a valid cpu: https://github.com/bazelbuild/bazel/issues/2191 This version uses "armeabi-v7a" instead. -- PiperOrigin-RevId: 141185293 MOS_MIGRATED_REVID=141185293
* Bazel uses apksigner from SDK build-tools instead of embedded jar.Gravatar Adam Michael2016-12-06
| | | | | | | | | | | | A followup change will remove the apksigner jar that is bundled with Bazel. RELNOTES: Bazel Android builds use the apksigner tool from the Android SDK build-tools. Bazel Android builds now require build-tools version 24.0.3 or later. -- PiperOrigin-RevId: 141181612 MOS_MIGRATED_REVID=141181612
* Fix spelling mistake.Gravatar Nathan Harmata2016-12-06
| | | | | | -- PiperOrigin-RevId: 141178325 MOS_MIGRATED_REVID=141178325
* Fix private visibility for aliased targets. Gravatar Lukacs Berki2016-12-06
| | | | | | | | | | Also a drive-by improvement on some related error messages. RELNOTES[INC]: Only targets with public visibility can be bound to something in //external: . -- PiperOrigin-RevId: 141178039 MOS_MIGRATED_REVID=141178039
* If a worker returns unparseable output, print it to the terminal.Gravatar Philipp Wollermann2016-12-06
| | | | | | | | When a persistent worker returns a WorkResponse that cannot be parsed by protobuf, it probably means that the worker has encountered an error and mistakenly printed a stack trace or error message to stdout. For users who want to know why their compiler crashes and for developers of tools that support the worker mode, it is extremely helpful to actually see these error messages, so let's print them. -- PiperOrigin-RevId: 141176835 MOS_MIGRATED_REVID=141176835
* Rollback of commit 84e7bbc03d22a98e1036c9a3abf1d451e602348b.Gravatar Damien Martin-Guillerez2016-12-06
| | | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** This change make AndroidStudioInfoAspectTest#testAndroidLibrary flaky bazel test --nocache_test_results --runs_per_test 10 //src/test/java/com/google/devtools/build/lib:ideinfo_test gives 2 to 3 failures out of 10 run. Fixes #2192 *** Original change description *** Pass isExternal field to blaze ide info proto Roll forward after fixing tests. The intellij aspect tests now correctly retains the required toolchain targets in the WORKSPACE file. -- PiperOrigin-RevId: 141174688 MOS_MIGRATED_REVID=141174688
* Add javac-9-dev-r3297-1Gravatar Liam Miller-Cushon2016-12-06
| | | | | | | | | | https://github.com/google/error-prone-javac/archive/9-dev-r3297-1.zip -- Change-Id: I10f28f2376d0073045ed0b3e0d7e4f1b1987472a Reviewed-on: https://cr.bazel.build/7630 PiperOrigin-RevId: 141167755 MOS_MIGRATED_REVID=141167755
* Rollback of commit 7505d94c19727e3100ac5e16a960bff2cb324f23.Gravatar Damien Martin-Guillerez2016-12-06
| | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Newly added test fail on Windows platform Fixes https://github.com/bazelbuild/bazel/issues/2191 *** Original change description *** Provide deterministic order for split configured deps. Also: - Make ConfiguredTargetFunction.getDynamicConfigurations more readable. - Add a bit more testing coverage for configured dep resolution. -- PiperOrigin-RevId: 141167110 MOS_MIGRATED_REVID=141167110
* Release: add a generate-rc command to the release scriptGravatar Damien Martin-Guillerez2016-12-06
| | | | | | | | | | | | | | | | This generate-rc command allows people to use the git workflow, that is: $ git checkout -b release-name baseline $ git cherry-pick commit1 commit2 ... $ ./scripts/release/release.sh generate-rc Instead of $ ./scripts/release/release.sh create name baseline commit1 commit2 .... -- Change-Id: I4a00f7ab46590450ba7ee26c6509ed747f32d956 Reviewed-on: https://cr.bazel.build/7450 PiperOrigin-RevId: 141163272 MOS_MIGRATED_REVID=141163272
* Add javac-9-dev-r3297-1Gravatar Liam Miller-Cushon2016-12-06
| | | | | | https://github.com/google/error-prone-javac/archive/9-dev-r3297-1.zip Change-Id: I10f28f2376d0073045ed0b3e0d7e4f1b1987472a
* Bazel client: add/remove include statementsGravatar Laszlo Csomor2016-12-06
| | | | | | -- PiperOrigin-RevId: 141157873 MOS_MIGRATED_REVID=141157873
* Make token_stream a cc_libraryGravatar Liam Miller-Cushon2016-12-06
| | | | | | -- PiperOrigin-RevId: 141145286 MOS_MIGRATED_REVID=141145286
* Fix typos in usage exampleGravatar Liam Miller-Cushon2016-12-06
| | | | | | -- PiperOrigin-RevId: 141116980 MOS_MIGRATED_REVID=141116980
* Provide deterministic order for split configured deps.Gravatar Greg Estren2016-12-06
| | | | | | | | | | Also: - Make ConfiguredTargetFunction.getDynamicConfigurations more readable. - Add a bit more testing coverage for configured dep resolution. -- PiperOrigin-RevId: 141095973 MOS_MIGRATED_REVID=141095973
* Override BuildConfiguration.equals() for dynamic configs.Gravatar Greg Estren2016-12-06
| | | | | | | | | | | | | | | | This makes tests that unnecessarily relied on reference equality pass with --experimental_dynamic_configs=notrim. In particular, with --nodistinct_host_configuration dynamic configurations still use distinct instances even though the options are the same. This is a roll forward of original change: https://github.com/bazelbuild/bazel/commit/2a2be3907981d9654575493c7012d95d1241f373 That was rolled back because of lots of expensive hashCode() calls. This version precomputes the hash code. -- PiperOrigin-RevId: 141095789 MOS_MIGRATED_REVID=141095789
* Fix test configured target creation code that was dropping split deps.Gravatar Greg Estren2016-12-06
| | | | | | | | | | | | | | | Short story: Dependency -> BuildConfiguration maps can have multiple values because of split transitions. This is unfortunately one of those instances where the test logic is forked from production. So this doesn't actually demonstrate bugs in production code. We already have tests in ConfigurationsForTargetsTest that directly check the production logic. So this cl's primary value is to unbreak tests that depend on the forked logic. -- PiperOrigin-RevId: 141094830 MOS_MIGRATED_REVID=141094830
* Pass isExternal field to blaze ide info protoGravatar Googler2016-12-06
| | | | | | | | | Roll forward after fixing tests. The intellij aspect tests now correctly retains the required toolchain targets in the WORKSPACE file. -- PiperOrigin-RevId: 141093346 MOS_MIGRATED_REVID=141093346
* Rollback of commit 67b4d5250edcefa7220e928e529b1f385e2dc464.Gravatar Alex Humesky2016-12-06
| | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Memory regression: [] *** Original change description *** Pass direct jars to Jack. The R class generator produces a compiled jar, not a java source file. This means all android libraries/binaries with resources will need to convert this jar to jack to ensure that they have access to jars. This change will not fix Jack builds, but it is a necessary step toward fixing them. -- PiperOrigin-RevId: 141091215 MOS_MIGRATED_REVID=141091215