aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar Michajlo Matijkiw <michajlo@google.com>2016-12-07 14:23:02 +0000
committerGravatar Laszlo Csomor <laszlocsomor@google.com>2016-12-07 15:08:30 +0000
commitf919bd1bfd8785619815d4a8f200c5c4d15b355d (patch)
treeafdef27f64e984fe0a8dd3b213f75f3f1ea85fd6
parent2a2127cdb9e185956891f646ebf7d8749576fda4 (diff)
Remove varargs Fingerprint#addStrings
Doesn't add much on top of the Iterable version in the current state of things, and it is too easy to confuse with addString. -- PiperOrigin-RevId: 141300940 MOS_MIGRATED_REVID=141300940
-rw-r--r--src/main/java/com/google/devtools/build/lib/rules/nativedeps/NativeDepsHelper.java2
-rw-r--r--src/main/java/com/google/devtools/build/lib/util/Fingerprint.java15
2 files changed, 1 insertions, 16 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/rules/nativedeps/NativeDepsHelper.java b/src/main/java/com/google/devtools/build/lib/rules/nativedeps/NativeDepsHelper.java
index d724d7f032..814b18f5f8 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/nativedeps/NativeDepsHelper.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/nativedeps/NativeDepsHelper.java
@@ -301,7 +301,7 @@ public abstract class NativeDepsHelper {
fp.addString(input.getExecPathString());
}
for (String feature : features) {
- fp.addStrings(feature);
+ fp.addString(feature);
}
return new PathFragment("_nativedeps/" + fp.hexDigestAndReset());
}
diff --git a/src/main/java/com/google/devtools/build/lib/util/Fingerprint.java b/src/main/java/com/google/devtools/build/lib/util/Fingerprint.java
index 1ca8ecf120..f1af5491ff 100644
--- a/src/main/java/com/google/devtools/build/lib/util/Fingerprint.java
+++ b/src/main/java/com/google/devtools/build/lib/util/Fingerprint.java
@@ -249,21 +249,6 @@ public final class Fingerprint {
}
/**
- * Updates the digest with inputs by iterating over them and invoking
- * {@code #addString(String)} on each element.
- *
- * @param inputs the inputs with which to update the digest
- */
- public Fingerprint addStrings(String... inputs) {
- addInt(inputs.length);
- for (String input : inputs) {
- addString(input);
- }
-
- return this;
- }
-
- /**
* Updates the digest with inputs which are pairs in a map, by iterating over
* the map entries and invoking {@code #addString(String)} on each key and
* value.