| Commit message (Collapse) | Author | Age |
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89133777
|
|
|
|
|
|
|
| |
concurrently. We update the timing with the maximum elapsed time. This could prevent us from getting the critical path (because another smaller path could mask the critical path), but in practice we do not expect this to happen.
--
MOS_MIGRATED_REVID=89133458
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89131807
|
|
|
|
|
|
|
|
| |
In the future, we will have linkstamp flags be generated by the crosstool
feature configuration, just like normal compile actions.
--
MOS_MIGRATED_REVID=89131127
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removing ActionMetadata#getInputCount instead of relying on all
implementations of ActionMetadata keeping getInputCount and
getInputs in sync. getInputCount is only used by a few tests
and has no applications in the main code at the moment, so it
is trivial to remove before we may come to rely on it more or its
semantics get more complicated.
--
MOS_MIGRATED_REVID=89130009
|
|
|
|
|
|
|
| |
RELNOTES: Referencing a path outside the execution root is now an error.
--
MOS_MIGRATED_REVID=89129910
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
This new default behavior is undesirable in many situations.
*** Original change description ***
Change the default value for test_output to "errors".
This might be controversial, but I have many times seen users run their tests, and then select the failure log path in their terminal and then cat the log to their screen so they can search for their errors. Every time, I've pointed out, "you can add test_output=errors to your .blazerc," they've thought it was great. Sometimes they say, "Why isn't that just the default?"
***
--
MOS_MIGRATED_REVID=89128948
|
|
|
|
|
|
|
| |
IDE OOMing when a large action cache is in scope during debugging.
--
MOS_MIGRATED_REVID=89127817
|
|
|
|
|
|
|
|
|
| |
SkyFunctionException#validateExceptionType. In practice, this function is only called with subtypes of Exception. Also, this changes emphasizes that the type of an error wrapped in SkyFunctionExceptions must be a subtype of Exception.
Similarly, restrict SchedulerException to only wrapping Exceptions. This is true in practice, but was missed in an earlier change.
--
MOS_MIGRATED_REVID=89127540
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89126911
|
|
|
|
|
|
|
|
|
|
| |
This happens in for loops, list comprehensions and simple assigment.
e.g.
a, b = expr
[a for a, b in expr]
--
MOS_MIGRATED_REVID=89123977
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89123900
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89123292
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89123209
|
|
|
|
|
|
|
| |
Also, use LValue in ForStatement.
--
MOS_MIGRATED_REVID=89122760
|
|
|
|
|
|
|
|
|
|
|
| |
This change allows tests to fails silently and have the test output by
function preserved.
Without it, a script that would set +e and have a failing command would
generate a failure on the fetching of the failure message, making the
whole test suite fails.
--
MOS_MIGRATED_REVID=89120786
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89118665
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In Python, tuples normally don't need parens, e.g.
a, b = c, d
for i, j in e: pass
However, they are sometimes required to avoid ambiguity:
fct((x, y))
[(1, 2), (3, 4)]
This distinction is handled with parseExpression vs parseNonTupleExpression.
--
MOS_MIGRATED_REVID=89118478
|
|
|
|
|
|
|
|
| |
This part was tentative and the Eclipse classpath generation for Bazel
is way more custom that what you would expect.
--
MOS_MIGRATED_REVID=89118179
|
|
|
|
|
|
|
| |
../lib/rules package. Unused code is removed. Anchor for lists is fixed in the doc.
--
MOS_MIGRATED_REVID=89117189
|
|
|
|
|
|
|
| |
of BuildConfigurationTest into a new test class.
--
MOS_MIGRATED_REVID=89113080
|
|
|
|
|
|
|
|
| |
This makes it easier to comment out large blocks of compilation, when testing
only particular stages.
--
MOS_MIGRATED_REVID=89099305
|
|
|
|
|
|
|
| |
We don't need a provisioning profile if we're building for a simulator
--
MOS_MIGRATED_REVID=89098211
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89095609
|
|
|
|
|
|
|
|
| |
Move castList, castMap, toMap utilities away from SkylarkFunction to SkylarkType
where the cast utility already has been moved.
--
MOS_MIGRATED_REVID=89042835
|
|
|
|
|
|
|
| |
uses the PathPackageLocator.
--
MOS_MIGRATED_REVID=89042210
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89039766
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89038414
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89038346
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89037655
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reflection, and saves ~15% of initialization time in []RuleClassProvider.create().
Before change:
Over 14 samples,
average = 976
median = 969.9
After change:
Over 14 samples,
average = 811.5
median = 813.9
--
MOS_MIGRATED_REVID=89036261
|
|
|
|
|
|
|
|
|
|
|
| |
The build mode ('dbg', 'opt', 'fastbuild') is specified as a feature. The
crosstool can use that feature to switch between different flag configurations.
As one of these is always provided, the crosstool can hang default
configurations off of those features (via implies).
--
MOS_MIGRATED_REVID=89035231
|
|
|
|
|
|
|
|
|
| |
unsupported features for a rule.
Previously this would lead to a NPE later on.
--
MOS_MIGRATED_REVID=89033249
|
|
|
|
|
|
|
| |
insert ActionInputs into SingleBuildFileCache.
--
MOS_MIGRATED_REVID=89032980
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89032399
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89030601
|
|
|
|
|
|
|
|
| |
This will allow thing in, say, jdk.WORKSPACE to be overridden in the main
WORKSPACE file.
--
MOS_MIGRATED_REVID=89030234
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89028761
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89020190
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL is just moving code from AssignmentStatement to a new class. The goal
is to share code dealing with LValues.
LValues can be found here:
- lvalue = 2
- [for lvalue in exp]
- {a: b for lvalue in exp]
- for lvalue in exp: pass
The LValue itself can have different forms:
- a
- a, b
- a[0]
- a, (b, c)
- [a[0], (b, c)]
- a[1:5]
Although we may not handle everything, we need to make sure that the same
things can be used in variable assignment and in for loops.
--
MOS_MIGRATED_REVID=89015483
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=88992212
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=88975338
|
|
|
|
|
|
|
|
|
|
|
| |
Without this change we create a xcode target for each combination (target, architecture)
which causes the xcode project generation to blow up: Xcode transparently handles
architectures. Eventually we want to match Xcode's behaviour but for now we export just
a single architecture's xcode targets which should allow developers to work in xcode as
before while preserving multi-architecture compilation for IPAs in blaze.
--
MOS_MIGRATED_REVID=88973190
|
|
|
|
|
|
|
| |
this change in a prior review, but our various Markdown interpreters actually expect there to be only one top-level (#) header per page, which is the page title.
--
MOS_MIGRATED_REVID=88972196
|
|
|
|
|
|
|
|
|
|
|
| |
is known that the action is a cache hit.
This adds momentary memory overhead when checking the action cache, but should prevent a host of potential errors.
Note that this cl assumes that an action that discovers its inputs does *not* take the names of its inputs into account when calculating its key, which is already stated as part of the javadoc of Action#getKey.
--
MOS_MIGRATED_REVID=88971626
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=88970846
|
|
|
|
|
|
|
| |
File" to avoid confusion between adding a rule and actually writing one (with Skylark).
--
MOS_MIGRATED_REVID=88970841
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=88964412
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of repeatedly scanning all transitively required include scannables, do
one pass from all include scannables; this prevents us revisiting the common
transitive closure of the include scannables.
Additionally, only scan command line includes relatively to a main source file,
not relatively to all source files. This is better than what we had before, but
it's still not exactly right - we should actually scan the command line
includes relatively to the module map file ([]
Brings include scanning times for large TUs with modules down from ~60 seconds
to < 2 seconds.
--
MOS_MIGRATED_REVID=88963159
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* New hierarchy BaseFunction > UserModeFunction, BuiltinFunction.
The old hierarchy still exists for now, to be deleted after migration:
Function > AbstractFunction > MixedModeFunction >
(UserModeFunction, SkylarkFunction > SimpleSkylarkFunction)
(UserModeFunction is already migrated, and
BaseFunction implements Function, for now.)
* Function supports *args and **kwargs when calling functions, and
mandatory named-only parameters in the style of Python 3.
Notable difference with Python: *args binds the variable to a tuple,
because a Skylark list would have to be monomorphic.
* A better, simpler, safer FFI using reflection with BuiltinFunction.
Handles typechecking, passes parameters in a more Java style.
(Not used for now, will be used later.)
* A new annotation @SkylarkSignature, intended to replace @SkylarkBuiltin,
supports the full function call protocol, including default arguments.
* Support for annotating function Factory-s rather than functions.
--
MOS_MIGRATED_REVID=88958581
|