aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar Googler <noreply@google.com>2015-03-20 16:26:08 +0000
committerGravatar Damien Martin-Guillerez <dmarting@google.com>2015-03-23 11:52:01 +0000
commitc023bc2b0f98eaa2e928b3d5a3160a9cf20f7158 (patch)
treecf4c6132cb97769a6dbad8d92a550535a61182ee
parent16bff48865a70c7206ba17ee213debe87304f380 (diff)
Automated [] rollback of [].
*** Reason for rollback *** This new default behavior is undesirable in many situations. *** Original change description *** Change the default value for test_output to "errors". This might be controversial, but I have many times seen users run their tests, and then select the failure log path in their terminal and then cat the log to their screen so they can search for their errors. Every time, I've pointed out, "you can add test_output=errors to your .blazerc," they've thought it was great. Sometimes they say, "Why isn't that just the default?" *** -- MOS_MIGRATED_REVID=89128948
-rw-r--r--docs/bazel-user-manual.html2
-rw-r--r--src/main/java/com/google/devtools/build/lib/exec/ExecutionOptions.java6
2 files changed, 4 insertions, 4 deletions
diff --git a/docs/bazel-user-manual.html b/docs/bazel-user-manual.html
index 698119799d..2c127f7b44 100644
--- a/docs/bazel-user-manual.html
+++ b/docs/bazel-user-manual.html
@@ -2727,12 +2727,12 @@ value, merely warns if Bazel thinks the timeout could be restricted further.
failed. Also shows the output log file name for failed tests. The summary
will be printed at the end of the build (during the build, one would see
just simple progress messages when tests start, pass or fail).
+ This is the default behavior.
</li>
<li><code>errors</code> sends combined stdout/stderr output from failed tests
only into the stdout immediately after test is completed, ensuring that
test output from simultaneous tests is not interleaved with each other.
Prints a summary at the build as per summary output above.
- This is the default behavior.
</li>
<li><code>all</code> is similar to <code>errors</code> but prints output for
all tests, including those which passed.
diff --git a/src/main/java/com/google/devtools/build/lib/exec/ExecutionOptions.java b/src/main/java/com/google/devtools/build/lib/exec/ExecutionOptions.java
index f6ddbe9a21..a12ece9f51 100644
--- a/src/main/java/com/google/devtools/build/lib/exec/ExecutionOptions.java
+++ b/src/main/java/com/google/devtools/build/lib/exec/ExecutionOptions.java
@@ -29,10 +29,10 @@ import java.util.Map;
/**
* Options affecting the execution phase of a build.
*
- * <p>These options are interpreted by the BuildTool to choose an Executor to
+ * These options are interpreted by the BuildTool to choose an Executor to
* be used for the build.
*
- * <p>Note: from the user's point of view, the characteristic function of this
+ * Note: from the user's point of view, the characteristic function of this
* set of options is indistinguishable from that of the BuildRequestOptions:
* they are all per-request. The difference is only apparent in the
* implementation: these options are used only by the lib.exec machinery, which
@@ -119,7 +119,7 @@ public class ExecutionOptions extends OptionsBase {
public PathFragment testTmpDir;
@Option(name = "test_output",
- defaultValue = "errors",
+ defaultValue = "summary",
category = "testing",
converter = TestStrategy.TestOutputFormat.Converter.class,
help = "Specifies desired output mode. Valid values are 'summary' to "