| Commit message (Collapse) | Author | Age |
... | |
|
|
|
|
|
|
|
|
|
|
| |
manifest merger places the application element as the last child of the manifest element. This is required for Android N.
NEW: fixed index out of range exception
RELNOTES: Merged manifests are guaranteed to have the application element as the last child of the manifest element as required by Android N.
--
MOS_MIGRATED_REVID=125493743
|
|
|
|
|
|
|
|
|
| |
SkyQueryEnvironment almost always does no useful work in preloading
target patterns. With this CL, preloading no longer happens, and we
can delete code paths that depended on preloading.
--
MOS_MIGRATED_REVID=125492408
|
|
|
|
|
|
|
|
|
|
|
|
| |
* This fixes a crash when a target has both a bridging header and a
* module map
RELNOTES: Native Swift rules no longer pull in module maps unconditionally.
Use --experimental_objc_enable_module_maps for that.
--
MOS_MIGRATED_REVID=125491042
|
|
|
|
|
|
|
| |
Another part of rolling forward #1262.
--
MOS_MIGRATED_REVID=125481356
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously each call to SkyQueryEnvironment.eval wrapped the provided
callback in a new batched callback. Nesting batched callbacks results
in unnecessary work.
With this change, SkyQueryEnvironment will construct one batched
callback in evaluateQuery (the top-level function called during query
evaluation). Because batched callbacks need to be flushed using
processLastPending(), it was convenient not to call through to the
base class's implementation of evaluateQuery, but to inline it in
SkyQueryEnvironment and add the processLastPending call at the
appropriate place.
This also clears the way for future customizations to
SkyQueryEnvironment's implementation of evaluateQuery.
--
MOS_MIGRATED_REVID=125477770
|
|
|
|
|
|
|
|
|
|
| |
When building --direct_dependency/--indirect_dependency args, use a set for the
direct jars to avoid an O(n) contains check, and make the CustomMultiArgv class
static to avoid a memory leak. Also avoid flattening the NestedSet of direct
jars for as long as possible.
--
MOS_MIGRATED_REVID=125468789
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125467098
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125465251
|
|
|
|
|
|
|
| |
Consider /src/ in the path when locating the java root directory.
--
MOS_MIGRATED_REVID=125461909
|
|
|
|
|
|
|
| |
Fixes #1371.
--
MOS_MIGRATED_REVID=125459925
|
|
|
|
|
|
|
| |
It's not used and it causes difficulties, since it's a function of the CROSSTOOL file, which we want not to affect configurations (eventually).
--
MOS_MIGRATED_REVID=125455664
|
|
|
|
|
|
|
|
|
| |
When --noinstrument_test_targets is set, shouldIncludeLocalSources (in InstrumentedFilesCollector) excludes test targets not excluded by --instrumentation_filter. Build actions enabling coverage instrumentation should know about that, so they don't do unnecessary work.
Also pulled shouldIncludeLocalSources out of a static inner class.
--
MOS_MIGRATED_REVID=125452712
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125452649
|
|
|
|
|
|
|
| |
--
Change-Id: I9187a50b8070e0615863d1e4f14373c902278489
Reviewed-on: https://bazel-review.googlesource.com/#/c/3851/
MOS_MIGRATED_REVID=125451055
|
|
|
|
|
|
|
|
|
| |
is not picked up when you run the scripts manually using "bash script.sh".
This is also in our shell style guide: "Executables must start with #!/bin/bash and a minimum number of flags. Use set to set shell options so that calling your script as bash <script_name> does not break its functionality."
--
MOS_MIGRATED_REVID=125450962
|
|
|
|
|
|
|
|
| |
Behavior of getLowerCase/getUpperCase is locale-specific, and can be rather
surprising. We should _always_ pass a locale explicitly.
--
MOS_MIGRATED_REVID=125450790
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125449782
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125449676
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125449526
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Newly passing:
//src/test/java/com/google/devtools/build/...
lib/skyframe:SkyframeTests
lib:actions_test
Also refactored FileSystems.java
--
Change-Id: I03ab9db5c1ab5e5be4ff1efbc5cf2d280084254a
Reviewed-on: https://bazel-review.googlesource.com/#/c/3843
MOS_MIGRATED_REVID=125449456
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125449364
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125448446
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-XX:TieredStopAtLevel=1 instead of -client, as the latter is ignored on 64-bit JVMs since at least JDK 6.
The new flags have been shown to cut down CPU time by 50% due to reduced time spent in JIT and improving overall run time for short running actions, some times also cutting them in half.
Here's a benchmark of Bazel building itself, giving a nice 2-4x speedup:
./output/bazel clean && ./output/bazel build //src:bazel
Bazel before this change:
INFO: Elapsed time: 197.783s, Critical Path: 194.10s
INFO: Elapsed time: 198.928s, Critical Path: 195.65s
INFO: Elapsed time: 194.913s, Critical Path: 191.56s
Bazel before this change with --strategy=Javac=worker:
INFO: Elapsed time: 130.436s, Critical Path: 124.27s
INFO: Elapsed time: 116.114s, Critical Path: 112.30s
INFO: Elapsed time: 116.852s, Critical Path: 84.45s
Bazel with this change:
INFO: Elapsed time: 121.625s, Critical Path: 119.08s
INFO: Elapsed time: 119.401s, Critical Path: 115.80s
INFO: Elapsed time: 121.198s, Critical Path: 119.03s
Bazel with this change and --strategy=Javac=worker:
INFO: Elapsed time: 54.456s, Critical Path: 51.28s
INFO: Elapsed time: 53.272s, Critical Path: 51.09s
INFO: Elapsed time: 52.966s, Critical Path: 49.86s
Bazel with this change and --strategy=Javac=worker and stripping -XX:TieredStopAtLevel=1 from JVM flags when using workers:
INFO: Elapsed time: 61.599s, Critical Path: 58.93s
INFO: Elapsed time: 48.695s, Critical Path: 45.02s
INFO: Elapsed time: 46.874s, Critical Path: 43.91s
INFO: Elapsed time: 46.174s, Critical Path: 43.32s
(The latter is a possible optimization for workers and it's also nice to know that the limited tiered compilation does not hurt their performance.)
--
MOS_MIGRATED_REVID=125448089
|
|
|
|
|
|
|
| |
Fixes #527.
--
MOS_MIGRATED_REVID=125447030
|
|
|
|
|
|
|
| |
Fixes #1423
--
MOS_MIGRATED_REVID=125445881
|
|
|
|
|
|
|
| |
instead of Java's Class<?>.
--
MOS_MIGRATED_REVID=125443529
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is no reason for shell scripts to end in .sh or .bash: shell scripts
can, and often do, have no extension because they are intended to be directly
runnable from the source tree.
Therefore, change the sh_* rules to allow any filename in their srcs
attribute.
--
MOS_MIGRATED_REVID=125442088
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Broke Bazel build on Ubuntu 15.10, e.g.:
http://ci.bazel.io/view/Bazel%20bootstrap%20and%20maintenance/job/Bazel/JAVA_VERSION=1.8,PLATFORM_NAME=ubuntu_15.10-x86_64/611/console
*** Original change description ***
Make create_embedded_tools.sh an sh script
This script is called directly (and not as an argument to the shell),
hence the #!-line needs to be correct. As the script does not use any
bash-specific feature, we can maintain it as a script for the POSIX
shell, which has the advantage that the path is canonical.
--
MOS_MIGRATED_REVID=125441679
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125441622
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks Bazel build on Ubuntu 15.10. Manually tested that rolling this back fixes the build.
*** Original change description ***
sandbox: Mount input files and directories actually read-only.
Fixes #1364.
RELNOTES[INC]: Bazel's sandbox mounts input files read-only in this release. If your build suddenly fails due to tools not being able to write to files, then this is probably working as intended (you should never modify input files in your build), but please feel free to provide feedback.
--
MOS_MIGRATED_REVID=125439581
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a new configuration option that allows disabling the creation of symlink forest for runfiles.
On Windows, symlink forest is disabled by default; only the runfiles manifest is created.
For shell tests, a function 'rlocation' is provided that converts from runfiles location to a real location.
Work towards #1212.
--
MOS_MIGRATED_REVID=125439553
|
|
|
|
|
|
|
| |
causing LocalLinuxSandboxedStrategyTest to fail due to unexpected lines in the output.
--
MOS_MIGRATED_REVID=125439352
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125436393
|
|
|
|
|
|
|
|
|
| |
default shell environment.
Fixes #1420, fixes #1358, fixes #1341, fixes #1152.
--
MOS_MIGRATED_REVID=125429839
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125429700
|
|
|
|
|
|
|
| |
This is needed for generate_workspace to behave correctly on OS X, see https://bazel-review.googlesource.com/#/c/3460.
--
MOS_MIGRATED_REVID=125428956
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125428066
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, the experimental UI always shows the 3 oldest, still running actions.
While this seems a reasonable default, some users requested to be able to change
the number of actions shown. Hence replace the hard-coded value by a flag.
While there, also fix an off-by-one error in deciding when to put the ellipsis
symbol.
--
Change-Id: I037d208360fa1d3f100c99ab1ab1f5fc140138ac
Reviewed-on: https://bazel-review.googlesource.com/#/c/3811
MOS_MIGRATED_REVID=125427168
|
|
|
|
|
|
|
| |
purpose.
--
MOS_MIGRATED_REVID=125426709
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Doesn't handle aapt that doesn't generate R.txt properly.
--
MOS_MIGRATED_REVID=125405481
|
|
|
|
|
|
|
|
| |
to remove the call from RuleConfiguredTarget.getProvider() and instead check the
types when the providers ImmutableMap is built.)
--
MOS_MIGRATED_REVID=125389561
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125385321
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For android_binary rules, we regenerate all of
the R.java of the libraries to get the final
resource IDs. Compiling all of them together can
be slow with the normal JavaBuilder, so add a
specialized class writer.
Example build with many R.java classes:
- R.java -> R.class via JavaBuilder: over 80s
- ErrorProne takes about 40% of that. So turning off
ErrorProne would be projected to be 48s.
Some of ErrorProne slowness is from static field
checks (e.g., on Flag classes), which may look
up the same Type over and over.
In comparison, if we write our own bytecode with ASM:
- ~16s total
- 4.7s to parse R.txt
- 4.8s to write class files
- 5.8s to copy and compress .jar
TODO: clean up SymbolLoader patching (upstream)
This only creates the action. We will need to
separately wire this up in blaze.
NOTE: This also makes the exising R.txt loading
used by live code multi-threaded, since that is
partly I/O-bound. Something to watch out for
(for flakiness, etc.) once this is submitted.
--
MOS_MIGRATED_REVID=125384467
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
configurations.
This is important for dynamic configurations.
invalidatePackages() invalidates every file. This includes CROSSTOOL,
which the CppConfiguration fragment depends on.
For static configurations, this doesn't matter because all configurations
and their fragments are pre-computed at the beginning of the build (or
in the case of tests before the test case starts).
For dynamic configurations, the configuration can get custom-created
each configured target. When that happens after invalidatePackages,
a new CppConfiguration instance gets created. This can impact code
like CcLibraryHelper.addDeps(), which assumes equality (CppConfiguration
has no .equals() method).
Normally that's not a problem because the same CppConfiguration instance
is used for every target in the post-invalidatePackages() graph. But
host configurations break this: we keep a non-Skyframe host config cache
in SkyframeBuildView.hostConfigurationCache. Without this change, it
doesn't get cleared out, so it keeps old pre-invalidation references that
under certain circumstances get applied to post-invalidation targets.
--
MOS_MIGRATED_REVID=125379342
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125376859
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125376554
|
|
|
|
|
|
|
|
| |
Avoids constructing and manipulating expected value sets
for containsExactlyElementsIn when containsExactly will do.
--
MOS_MIGRATED_REVID=125371446
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125368119
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125362963
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125360308
|