diff options
author | 2016-06-21 14:04:37 +0000 | |
---|---|---|
committer | 2016-06-21 14:47:46 +0000 | |
commit | 24ec1bfa0b9ed78ce5ce7b7e90612f24a60d2a54 (patch) | |
tree | 80566f1801d3f681f05efafc2cb5928f98ff2ffb | |
parent | cb535dc66fe9eb2817d05a43ecefcfdd9543f578 (diff) |
Mention that redirection from HTTP to HTTPS doesn't work
Fixes #527.
--
MOS_MIGRATED_REVID=125447030
4 files changed, 5 insertions, 4 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/bazel/rules/workspace/HttpArchiveRule.java b/src/main/java/com/google/devtools/build/lib/bazel/rules/workspace/HttpArchiveRule.java index 465e725ad2..1256c54f44 100644 --- a/src/main/java/com/google/devtools/build/lib/bazel/rules/workspace/HttpArchiveRule.java +++ b/src/main/java/com/google/devtools/build/lib/bazel/rules/workspace/HttpArchiveRule.java @@ -39,7 +39,7 @@ public class HttpArchiveRule implements RuleDefinition { A URL referencing an archive file containing a Bazel repository. <p>Archives of type .zip, .jar, .war, .tar.gz or .tgz are supported. There is no support - for authentication. Redirections are followed.</p> + for authentication. Redirections are followed, but not from HTTP to HTTPS.</p> <!-- #END_BLAZE_RULE.ATTRIBUTE --> */ .add(attr("url", STRING).mandatory()) /* <!-- #BLAZE_RULE(http_archive).ATTRIBUTE(sha256) --> diff --git a/src/main/java/com/google/devtools/build/lib/bazel/rules/workspace/HttpFileRule.java b/src/main/java/com/google/devtools/build/lib/bazel/rules/workspace/HttpFileRule.java index e0d20a8518..b4e3dc9d96 100644 --- a/src/main/java/com/google/devtools/build/lib/bazel/rules/workspace/HttpFileRule.java +++ b/src/main/java/com/google/devtools/build/lib/bazel/rules/workspace/HttpFileRule.java @@ -40,7 +40,7 @@ public class HttpFileRule implements RuleDefinition { A URL to a file that will be made available to Bazel. <p>This must be an http or https URL. Authentication is not support. - Redirections are followed.</p> + Redirections are followed, but not from HTTP to HTTPS.</p> <!-- #END_BLAZE_RULE.ATTRIBUTE --> */ .add(attr("url", STRING).mandatory()) /* <!-- #BLAZE_RULE(http_file).ATTRIBUTE(sha256) --> diff --git a/src/main/java/com/google/devtools/build/lib/bazel/rules/workspace/HttpJarRule.java b/src/main/java/com/google/devtools/build/lib/bazel/rules/workspace/HttpJarRule.java index d249e9d2ea..06769ce19a 100644 --- a/src/main/java/com/google/devtools/build/lib/bazel/rules/workspace/HttpJarRule.java +++ b/src/main/java/com/google/devtools/build/lib/bazel/rules/workspace/HttpJarRule.java @@ -38,7 +38,8 @@ public class HttpJarRule implements RuleDefinition { /* <!-- #BLAZE_RULE(http_jar).ATTRIBUTE(url) --> A URL to an archive file containing a Bazel repository. - <p>This must be an http or https URL that ends with .jar. Redirections are followed.</p> + <p>This must be an http or https URL that ends with .jar. Redirections are followed, but + not from HTTP to HTTPS.</p> <!-- #END_BLAZE_RULE.ATTRIBUTE --> */ .add(attr("url", STRING).mandatory()) /* <!-- #BLAZE_RULE(http_jar).ATTRIBUTE(sha256) --> diff --git a/src/main/java/com/google/devtools/build/lib/bazel/rules/workspace/NewHttpArchiveRule.java b/src/main/java/com/google/devtools/build/lib/bazel/rules/workspace/NewHttpArchiveRule.java index 3913004b53..b86f0f0658 100644 --- a/src/main/java/com/google/devtools/build/lib/bazel/rules/workspace/NewHttpArchiveRule.java +++ b/src/main/java/com/google/devtools/build/lib/bazel/rules/workspace/NewHttpArchiveRule.java @@ -36,7 +36,7 @@ public class NewHttpArchiveRule implements RuleDefinition { A URL referencing an archive file containing a Bazel repository. <p>Archives of type .zip, .jar, .war, .tar.gz or .tgz are supported. There is no support - for authentication. Redirections are followed.</p> + for authentication. Redirections are followed, but not from HTTP to HTTPS.</p> <!-- #END_BLAZE_RULE.ATTRIBUTE --> */ .add(attr("url", STRING).mandatory()) /* <!-- #BLAZE_RULE(new_http_archive).ATTRIBUTE(sha256) --> |